View Issue Details
1516 [SiT!] outbound email tweak always 2011-06-02 16:31 2020-12-11 11:56
Tomse  
 
normal  
confirmed Current GIT  
open  
none    
none  
   
disabling / removing of email features when outbound email is deactivated
We should disable and/or remove references to outbound emails when the outbound email is deactivated
Notes
(0003854)
ivan   
2011-06-05 17:31   
The menu is link is now hidden from the incident popup.
(0005012)
jachhunter777   
2020-12-11 11:56   
0001516: https://goo.gl/2DqXGj [^]
Thanks Ivan





View Issue Details
1278 [SiT!] other feature N/A 2010-04-15 20:16 2020-12-11 08:45
ivan  
 
normal  
confirmed  
open  
none    
none  
   
Less confusing terminology
There's been plenty of discussion over the last twelve months about a lot of the terms we currently use in SiT! being confusing.

For example we use the word 'Users' to refer to people who provide support and not people who receive support. This is contrary to just about every other support system out there.

We've got this wiki page to try and decide which terms are best, use the talk page to place your vote:

http://sitracker.org/wiki/Development/Rewording [^]
Notes
(0004433)
paulh   
2012-01-24 21:23   
agree
(0004611)
ringram74   
2012-12-07 21:22   
It looks like the commit Paul did on 11/17 to remove the productonly stuff broke the setup. Looks like he removed the productonly column, but didn't remove or replace the productonly KEY at line 701 in setup-schema.php
(0004612)
Tomse   
2012-12-08 08:46   
the GiT branch, which was fixed, is for the 3.90+ version, that hasn't been released yet.
Whereas SVN is for the 3.6x+ release, this version doesn't have the mentioned fix.

please discuss a certain bug in either the forum or at its own place.
(0004613)
paulh   
2012-12-08 14:22   
Thanks ringram74, I've just done a new commit which finally kills all the productonly stuff within the git version and setup should now work again, sorry about that
(0005011)
alexwriter   
2020-12-11 08:45   
Thanks ringram74
Have a good weekend

0001278: https://goo.gl/2DqXGj [^]





View Issue Details
1994 [Incubator] General minor always 2020-08-21 15:20 2020-08-21 15:20
emilyray BSD  
FreeBSD  
normal 6.4+Later  
new  
open  
none    
none  
   
Population Growth
It is believed that the increase in living standards and the growth of the culture are accompanied by declining birthrate. A better health care leads to the reduction in mortality. While in the developing countries, mortality has decreased, the birth rate continues to increase. If the current rate of growth will remain at the same level, by the end of the next millennium, the world’s population could reach 500 billion. There are not enough space and natural resources on Earth for so many people. Many scientists believe that in the near future, the population of our planet will stabilize. To my mind, this can be done through a conscious birth control.
The question of regulating population became rather urgent. At the beginning of the XIX century, British economist Malthus found that the human population increases exponentially and calculated the amount of food for people by the arithmetic. He and his followers believed that the only way to improve the well-being of the population is to reduce its numbers by wars, epidemics of cholera, and the plague. Modern Malthusians require compulsory measures to reduce fertility in the developing countries by family planning.
Therefore, mankind currently faces the problem of population growth and limited water, land, energy, raw materials, and food resources making a heavy human impact on the environment. This creates a situation of global ecological crisis which could lead to serious consequences for humanity.
The most effective way to reduce the human impact on the environment is the organization of closed chains and cycles of production which include the recycling of production and consumption as well as re-use of natural resources in the production. An example of this is the use of waste water in production after it.The other measure is: the transition from the simple use of resources to the cycles which include: the reproduction of resources, replacement of certain other resources, bringing less environmental damage, use of resource-saving technologies of production as well as technologies that cause less damage to the natural environment.
Indeed, one of the causes of pollution of the environment is inefficient and wasteful use of natural resources. The main way to improve production efficiency in environmental compliance is a resource.
For example, Japan is now implementing a program of transition from technology to exploit the technology interacting with nature. This will help achieve harmony in the relationship between the society and nature.
Thus, until now, the main task is to eliminate the environmental damage caused by human mismanagement of farm management. It has now become clear that the restoration of natural resources should be carried out in the course of human economic activity. This helps to prevent damage to the environment.
As for me, the best way to ensure a decent quality of life for my generation in nearest 30 years from now is to control birth control through government programs and explanation of this issue to the community. Also, the development and widespread use of technologies for reuse of raw materials will bring a lot of benefits.

About author
Emily works as an editor at https://primeessay.org/free/Personal/importance-of-personal-accountability.html. [^] She directly participates in editing and supplementing interesting and unique works for any student, ensuring their correctness and relevance. Emily studied at the Faculty of Philology and holds a master's degree
There are no notes attached to this issue.





View Issue Details
1993 [Project plugin] Other trivial always 2020-08-20 14:27 2020-08-20 14:27
lindatyler Windows  
Windows  
normal XP+Later  
new Current SVN  
open  
none    
none  
   
About writing a reaction paper
If you are one of college / university students, there are high chances that your teachers could ask you to commence working on writing a reaction paper in APA format. Some experts call this type of writing as a response paper, which is also acceptable. These types of written tasks are indeed what they sound like. Students should read a certain book, text or article, watch a podcast oAr movie, and give their response / reaction to it.Are you aware how to compose a reaction paper in the correct way? Are there any specific guidelines in completing it that should be strictly kept to? It is sound to refer custom reaction paper writing help or support if you are unsure how to do this accordingly. More abut this https://essaysservice.com/writing-a-reaction-paper-in-apa-format.html [^]
Are there any specific guidelines in completing it that should be strictly kept to? It is sound to refer custom reaction paper writing help or support if you are unsure how to do this accordingly
There are no notes attached to this issue.





View Issue Details
1991 [Incubator] General minor always 2019-12-20 13:39 2019-12-20 13:39
Luciamandela  
 
normal  
new  
open  
none    
none  
   
NORTON.COM/SETUP - LOGIN, MANAGE ACCOUNT, DOWNLOAD NORTON SETUP
Norton.com/setup - In the digital world where we live today, computers, smartphones, tablets and other gadgets have become necessities. Moreover, the dependence on the Internet is increasing day by day along with the dangers associated with it. No matter how careful and cautious you are while using the computer and Internet, you are not safe from the risks of cybercrime and infections.
https://my-notron.com [^]
http://pagenorton.com [^]
https://mcafeecomactivate.uk.net [^]
http://officecomsetup-go.uk.com [^]
https://helpoffice.uk.net [^]
Norton Setup_1.jpg (95,192) 2019-12-20 13:39
http://bugs.sitracker.org/file_download.php?file_id=269&type=bug
There are no notes attached to this issue.





View Issue Details
1985 [SiT!] setup/config minor always 2019-05-26 14:43 2019-05-26 14:43
dipohl Linux  
Linux  
normal 2.6+later  
new Current GIT  
open  
none    
none  
   
False alarm is shown in setup check
During setup a warning is shown that is a false alarm.
config.inc.php is there and db_username and db_database is set therein.
setup-error_3.90-beta.jpg (96,526) 2019-05-26 14:43
http://bugs.sitracker.org/file_download.php?file_id=268&type=bug
There are no notes attached to this issue.





View Issue Details
1918 [SiT!] calendar minor always 2014-02-12 18:42 2017-07-04 10:22
Frans All platforms  
ivan Windows Server  
normal 2000+Later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Calender shows previous month and highlights previous month
Just reporting that the calendar is showing the wrong month.
Had to change the "hour" part in the gmmktime function of the file: calendar/calendar.inc.php
I changed the hour to 12 (was 0).
File added to this incident.
Suppose the reason is some time shift caused by the time zone.

Change time zone.
calendar.inc.php (34,434) 2014-02-12 18:42
http://bugs.sitracker.org/file_download.php?file_id=243&type=bug
Notes
(0005007)
ivan   
2017-07-04 10:22   
Thanks Frans. Finally fixed in Git.

https://github.com/sitracker/sitracker/commit/f4f430ac2f4b403f0c429e31882280b3a117a8cd [^]





View Issue Details
1984 [SiT!] other feature N/A 2016-08-17 11:04 2017-07-04 10:04
paulh  
 
normal  
new  
open  
none    
none  
   
Ability to disable/delete escalation paths
You can't disable/delete an escalation path once created
There are no notes attached to this issue.





View Issue Details
1979 [SiT!] other feature N/A 2016-05-01 16:25 2016-05-01 16:26
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
when using trusted server mode Just In time provisioning would be good for users
when using trusted server mode Just In time provisioning would be good for users
Notes
(0005006)
paulh   
2016-05-01 16:26   
ca82400 adds





View Issue Details
1964 [SiT!] incidents feature N/A 2015-04-30 10:42 2016-04-03 11:42
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Don't show expired contacts when logging an incident
when logging an incident and you search for a person it lists everyone with that name even if the contract expired a long time ago

We should only show current and recently expired contracts rather than everything (otherwise you end up with a long list and showing a contract which expired 5 years ago is of no use)
Notes
(0004977)
paulh   
2015-05-09 13:18   
ba99b34 adds this





View Issue Details
1824 [SiT!] other major N/A 2012-12-20 19:25 2016-04-03 11:42
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
mysql deprecated in PHP5.5
The mysql extension within PHP is set to be marked as deprecated in PHP5.5 and removed in a subsequent release details can be found at https://wiki.php.net/rfc/mysql_deprecation [^] and http://uk.php.net/mysql_connect [^]

We use this extensively within SiT, whilst there is a possibility that a PECL extension will be available which will continue this support we can't guarantee that our user base will be able to install such extensions and we shouldn't rely on it being available as such we need to look at moving to mysqli or PDO_MySQL sooner rather than latter this is a significant piece of work
Notes
(0004624)
ivan   
2013-01-01 15:33   
Confirmed.

Not an urgent problem at the moment, so not something we need to look at for the 3.x releases. As Paul has suggested on the dev mailing list, we should look at a solution for this at 4.0 or later.
(0004989)
paulh   
2015-12-29 12:35   
current trunk now uses mysqli





View Issue Details
1698 [SiT!] other trivial have not tried 2011-08-24 14:20 2016-04-03 11:42
ivan  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Remove deprecated readable_file_size() function
Remove deprecated readable_file_size() function after 3.90 release. Function is replaced by readable_bytes_size()
Notes
(0004256)
paulh   
2011-08-24 19:58   
Agree, especially as all it does is call readable_bytes_size anyway
(0005002)
paulh   
2016-04-01 18:26   
264fc53





View Issue Details
1697 [SiT!] other trivial have not tried 2011-08-24 14:14 2016-04-03 11:42
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta2  
Remove deprecated customerExistsInDB() function
The customerExistsInDB() function in lib/contact.inc.php is not used, I've marked deprecated for 3.90 and I propose we remove it in 3.91.
Notes
(0004257)
paulh   
2011-08-24 19:59   
Agree
(0005003)
paulh   
2016-04-01 18:27   
bda36bc





View Issue Details
1909 [SiT!] templates feature have not tried 2014-01-03 15:06 2016-04-01 18:39
ivan  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  4.0  
Email variables for temporary owner and temp owner email address
Email variables for temporary owner and temp owner email address would be very useful.
Notes
(0004903)
paulh   
2014-02-02 13:29   
Agree
(0005004)
paulh   
2016-04-01 18:39   
ca9eadf





View Issue Details
1827 [SiT!] other minor always 2013-01-05 12:11 2016-04-01 18:23
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
Inconsistent email adress lengths
Email address lengths are inconsistent within SiT

Users can have upto 50chars
contacts can have 100
CC field on an incident can be 100 chars in the interface and 255 in the database
all fields on outbound email are 100
emailtemplates are limited to 100 in dbEmailTemplates

Email addresses can be upto 256 characters so I propose we standardise all of these as VARCHAR 255

I've been running into problems in the last few weeks with a couple of customers:

* One whos domain name (bit after @) was 31 chars
* Another one where the customer had alot of staff with long surnames
Notes
(0005001)
paulh   
2016-04-01 18:23   
ecf5ff3





View Issue Details
1973 [SiT!] users feature N/A 2015-11-20 09:24 2016-03-25 12:01
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
disable user should (optionally) remove user from contracts
currently disabled users hang around on contracts
Notes
(0004999)
paulh   
2016-03-25 12:01   
42d3342208ae410fd9e30ca6e23bec7b40ca695a





View Issue Details
1967 [SiT!] incidents minor always 2015-05-12 12:15 2016-03-24 20:40
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
All contacts lists terminated users
When you search on new incidents for a user inactive users show up for contracts that are all site
Notes
(0004994)
paulh   
2016-03-24 20:40   
fixed in git





View Issue Details
1978 [SiT!] contracts minor N/A 2016-03-23 10:54 2016-03-24 20:33
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
no interface to manage licence types
There is no interface to manage the licence types
Notes
(0004993)
paulh   
2016-03-24 20:33   
48544b4 adds this





View Issue Details
1977 [SiT!] users minor always 2016-02-06 19:00 2016-02-06 19:00
paulh  
 
normal  
new  
open  
none    
none  
   
Remove duplicate user dropdowns
We have two functions user_dropdown in html_drop_downs.inc.php and user_drop_down in users.inc.php which both broadly do the same task (a drop down a users) we should probably consolidate to have just one
There are no notes attached to this issue.





View Issue Details
1975 [SiT!] other major N/A 2015-12-19 19:37 2015-12-19 19:37
paulh  
 
normal  
new  
open  
none    
none  
   
remove magic quotes calls
Remove calls to set_magic_quotes_runtime as this was deprecated and removed in PHP7

also get_magic_quotes_gpc was hard coded in PHP 5.4 so we should remove

http://php.net/manual/en/function.get-magic-quotes-gpc.php [^]
There are no notes attached to this issue.





View Issue Details
1972 [SiT!] portal minor always 2015-11-19 22:55 2015-11-21 16:07
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
portal shows expired/terminated contracts under details
portal/contactdetails.php shows disabled contracts
Notes
(0004988)
paulh   
2015-11-21 16:07   
e95b2c1 fixes





View Issue Details
1971 [SiT!] portal major always 2015-11-19 22:53 2015-11-21 16:06
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
Editing site details in portal disabled site
if you change a detail in the sit portal on the site it disabled the site in sit
Notes
(0004986)
paulh   
2015-11-19 22:55   
contracts also seem to vanish though if you click on inactive they reappear though as active...
(0004987)
paulh   
2015-11-21 16:06   
458781d resolves





View Issue Details
1968 [SiT!] portal minor always 2015-06-15 06:29 2015-11-01 12:45
rockell Linux  
paulh Linux  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Incorrect software name appears above Title in portal knowledgebase
The name for the first record in the software table appears for all articles.
Add a knowledge base item with a different skill from the first record in the software table. When you view it in the portal it will have the name of the first record.
The query in kb.php is incorrect. I changed mine to this and it now works as expected. i am not sure what the code inside the if statement does so i left it as-is. The first commented query was already commented, the second commented query was in the delivered code but was incorrect. The query below my initials works for me and i have tried it using all the options available on the page.

$filter = array('start' => $start, 'view' => $view);

// $sql = "SELECT k.*, s.name FROM `{$dbKBArticles}` AS k,
// $dbKBSoftware,
// `{$dbSoftware}` as s
// WHERE ((k.docid = kbs.docid AND kbs.softwareid = s.id) OR 1=1) AND k.distribution = 'public' ";
// $sql = "
// SELECT k.*, s.name FROM `{$dbKBArticles}` AS k,
// LEFT OUTER JOIN `$dbKBSoftware`, `{$dbSoftware}`
// ON k.docid = kbs.docid AND kbs.softwareid = s.id ";


//$sql = "SELECT k.*, s.name FROM `{$dbKBArticles}` AS k, `{$dbSoftware}` as s ";
//$sql .= "LEFT OUTER JOIN `{$dbKBSoftware}` as kbs ";
//$sql .= "ON kbs.softwareid=s.id ";
//$sql .= "WHERE (k.docid = kbs.docid OR 1=1) AND k.distribution='public' ";

//CR - 2015-06-15 Corrected query so it brings up the right name
$sql = "SELECT k.*, s.name FROM `{$dbKBArticles}` AS k inner join `{$dbKBSoftware}` as ks inner join `{$dbSoftware}` as s ";
$sql .= "ON ks.docid=k.docid and s.id=ks.softwareid ";
$sql .= "WHERE k.distribution='public' ";

if ($CONFIG['portal_kb_enabled'] != 'Public')
{
    if ($view != 'all')
    {
        $softwares = contract_software();
        $sql .= "AND (1=1 ";
        if (is_array($softwares))
        {
            foreach ($softwares AS $software)
            {
                $sql .= "OR kbs.softwareid={$software} ";
            }
        }
        $sql .= ")";

        echo "<p class='info'>{$strShowingOnlyRelevantArticles} - ";
        echo "<a href='{$_SERVER['PHP_SELF']}?view=all'>{$strShowAll}</a>

";
    }
    else
    {
        echo "<p class='info'>{$strShowingAllArticles} - ";
        echo "<a href='{$_SERVER['PHP_SELF']}'>{$strShowOnlyRelevant}</a>

";
    }
}
$sql .= "GROUP BY k.docid ";
Notes
(0004983)
paulh   
2015-11-01 12:33   
Thanks for this, reproduced in current git
(0004984)
paulh   
2015-11-01 12:45   
4570303eb2853c70dde208b777aa3f097c5b6e9d fixes





View Issue Details
1969 [SiT!] notifications minor always 2015-08-18 08:25 2015-09-05 19:03
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
You don't receive a notification of incident update when updated manually assigned
When an update is manually assigned to an incident you don't get a notificatin to say its been updated
Notes
(0004982)
paulh   
2015-09-05 19:03   
64dc09105781a5ab6ed6fc782c34a66334bb789f resolves this





View Issue Details
670 [SiT!] incidents minor have not tried 2009-04-28 15:57 2015-05-09 15:04
ivan  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
Temp owner not reset when incident is closed/reopened
We had some older cases (probable still during 3.41) that were closed, but the temp owner flag was not reset by the system, and thus today when we re-opened the incident, the incident owner and tempowner got the notification... maybe when a case gets closed, the tempowner flag should be cleared automatically to avoid such issues.
Notes
(0001057)
paulh   
2009-05-14 20:04   
As for current SVN we don't strip incidents.towner on either closure or reopen, I'm tempted to suggest that we shouldn't be doing this on closure and on reopen we should strip both owner and towner an request reassignment (defaulting to last assigned owner)

The reason behind this is we could potentially reopen a call that was owned by a user who is disabled and the call could potentially be lost
(0004981)
paulh   
2015-05-09 15:04   
37d53b3 clears owner/towner and prompts to reassign





View Issue Details
1947 [SiT!] sites & contacts minor have not tried 2014-06-13 13:35 2015-05-09 14:39
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
site_details doesn't show disabled contacts
site details page doesn't show disabled contacts which is good and it doesn't clutter the interface though there is no way from a site perspective to see disabled users, would be good to have an option to show disabled (or similar) or at least some indication there are disabled contacts
Notes
(0004980)
paulh   
2015-05-09 14:39   
08b14b4 adds this





View Issue Details
1961 [SiT!] scheduler major always 2015-04-10 15:59 2015-05-09 13:52
dipohl Linux  
paulh Linux  
high 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
   
[PATCH] schedule_actions_due() - SQL query result is empty
After migrating our SiT! instance to a new server:

Red Hat Enterprise Linux Server release 7.1 (Maipo)
mysql Ver 15.1 Distrib 5.5.41-MariaDB, for Linux (x86_64) using readline 5.1
PHP 5.4.16 (cli) (built: Oct 23 2014 07:19:40)
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies

auto.php was not working any more.

Investigation showed that no due tasks were found.
running auto.php from cronjob and also when called via webbrowser does nothing.
MariaDB [sit]> SELECT * FROM `scheduler` WHERE `status` = 'enabled' AND type = 'interval' AND UNIX_TIMESTAMP(start) <= 1428674062 AND (UNIX_TIMESTAMP(end) >= 1428674062 OR UNIX_TIMESTAMP(end) = 0) AND IF(UNIX_TIMESTAMP(lastran) > 0, UNIX_TIMESTAMP(lastran) + `interval`, UNIX_TIMESTAMP(NOW())) <= 1428674062 AND IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(lastran), -1) <= IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(laststarted), 0);
Empty set (0.00 sec)

MariaDB [sit]> select * from scheduler;
+----+----------------------+--------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+---------------------+---------------------+----------+----------+-----------+-------------+-----------+-------------+---------------------+---------+
| id | action | params | paramslabel | description | status | start | end | type | interval | date_type | date_offset | date_time | laststarted | lastran | success |
+----+----------------------+--------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+---------------------+---------------------+----------+----------+-----------+-------------+-----------+-------------+---------------------+---------+
| 1 | CloseIncidents | 554400 | closure_delay | Close incidents that have been marked for closure for longer than the <var>closure_delay</var> parameter (which is in seconds) | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 300 | month | 0 | NULL | NULL | 2015-04-08 12:20:01 | 1 |
| 2 | SetUserStatus | | NULL | (EXPERIMENTAL) This will set users status based on data from their holiday calendar. e.g. Out of Office/Away sick. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 300 | month | 0 | NULL | NULL | 2015-04-08 12:20:01 | 1 |
| 3 | PurgeJournal | | NULL | Delete old journal entries according to the config setting <var>$CONFIG['journal_purge_after']</var> | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 86400 | month | 0 | NULL | NULL | 2015-04-07 21:09:01 | 1 |
| 4 | TimeCalc | | NULL | Calculate SLA Target Times and trigger OUT_OF_SLA and OUT_OF_REVIEW system email templates where appropriate. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 1800 | month | 0 | NULL | NULL | 2015-04-08 11:59:01 | 1 |
| 5 | ChaseCustomers | | NULL | Chase customers | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 3600 | month | 0 | NULL | NULL | 2015-04-08 12:23:01 | 1 |
| 6 | CheckWaitingEmail | | NULL | Checks the holding queue for emails and fires the TRIGGER_WAITING_HELD_EMAIL trigger when it finds some. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 300 | month | 0 | NULL | NULL | 0000-00-00 00:00:00 | 1 |
| 7 | PurgeExpiredFTPItems | | NULL | purges files which have expired from the FTP site when run. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 216000 | month | 0 | NULL | NULL | 2015-04-07 18:50:01 | 1 |
| 8 | CheckIncomingMail | | NULL | Check incoming support mailbox. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 300 | month | 0 | NULL | NULL | 0000-00-00 00:00:00 | 1 |
| 9 | CheckTasksDue | | NULL | Checks for due tasks. | enabled | 2008-01-01 00:00:00 | 0000-00-00 00:00:00 | interval | 3600 | month | 0 | NULL | NULL | 2015-04-08 12:23:01 | 1 |
| 10 | ldapSync | | NULL | Sync users and customers from LDAP | enabled | 2014-03-07 00:00:00 | 0000-00-00 00:00:00 | interval | 3600 | month | 0 | 00:00:00 | NULL | 2015-04-08 11:35:01 | 1 |
+----+----------------------+--------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+---------------------+---------------------+----------+----------+-----------+-------------+-----------+-------------+---------------------+---------+
10 rows in set (0.00 sec)
Notes
(0004961)
dipohl   
2015-04-10 16:01   
Issue can be fixed with the following changes:

# rcsdiff functions.inc.php
===================================================================
RCS file: RCS/functions.inc.php,v
retrieving revision 1.1
diff -r1.1 functions.inc.php
5996c5996
< $sql .= "AND UNIX_TIMESTAMP(start) <= $now AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) = 0) ";
---
> $sql .= "AND UNIX_TIMESTAMP(start) <= $now AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) is NULL) ";
6011c6011
< $sql .= "AND UNIX_TIMESTAMP(start) <= $now AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) = 0) ";
---
> $sql .= "AND UNIX_TIMESTAMP(start) <= $now AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) is NULL) ";
6029c6029
< $sql .= "AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) = 0) ";
---
> $sql .= "AND (UNIX_TIMESTAMP(end) >= $now OR UNIX_TIMESTAMP(end) is NULL) ";
(0004979)
paulh   
2015-05-09 13:52   
Thanks Dipohl this is fixed in r7600 and 8d704ee





View Issue Details
1965 [SiT!] SLAs feature N/A 2015-05-04 12:12 2015-05-09 13:37
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
Ability to disable SLA
would be good to disable an SLA so new contracts etc can't be created with the SLA
Notes
(0004978)
paulh   
2015-05-09 13:37   
ccf971c adds this functionality





View Issue Details
1061 [SiT!] other minor have not tried 2010-02-10 11:30 2015-05-04 11:58
ivan  
 
normal  
confirmed  
open  
none    
none  
   
Dependency issues in .deb package
We depend on prototype.js and scriptaculous.js and we should set up package dependencies properly rather than bundle these within the .deb file. Bundling is bad because security fixes won't percolate.
Notes
(0002344)
paulh   
2010-02-10 13:23   
I'll take a look at this
(0002351)
paulh   
2010-02-11 20:35   
From some googling and looking at what libjs-prototype installs the way to do this on Debian is to include the javascript from /javascript/

e.g.

<script language="javascript" type="text/javascript"
src="/javascript/prototype/prototype.js"></script>

rather than symlinking or anything like that, this /javascript/ is done via conf.d/javascript-common.conf this means on building the deb all instances of

{$CONFIG['application_webpath']}scripts/prototype/prototype.js

need changing to /javascript/prototype/prototype.js which isn't a biggie

(0002378)
paulh   
2010-02-16 19:40   
Replacing prototype is straight forward as we just replace {$CONFIG['application_webpath']}scripts/prototype/prototype.js unfortunately scriptaculous isn't as easy as we don't directly include this but instead use $pagescripts and htmlheader.inc.php

if (is_array($pagescripts))
{
    foreach ($pagescripts AS $pscript)
    {
        echo "<script src='{$CONFIG['application_webpath']}scripts/{$pscript}' type='text/javascript'></script>\n";
    }
    unset($pagescripts, $pscript);
}

So we can't just sed this one,
(0002720)
ivan   
2010-03-17 14:08   
I've assigned this to me so that I'll remember to change the way pagescripts works, I'll bat it back to you (paulh) once thats done
(0003042)
ivan   
2010-04-12 21:12   
In Git 623ebb0 scriptaculous is always included instead of using pagescripts. This should make dependency issues a bit easier?





View Issue Details
1950 [SiT!] outbound email major always 2014-07-04 15:06 2015-04-25 18:46
Frans Linux  
paulh Cent OS  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Another program error in incident_email.php
Program error in file incident_email.php and ftp_upload_file.php
Description: reference to variable $mv programmed as mv.

This error is also present in the version 3.9
in file incident_email.php at line 446.

$mv = rename($file['tmp_name'], $filename);
if (!mv) trigger_error("Problem moving attachment from temp directory: {$filename}", E_USER_WARNING);

Correccion: if ($mv) ...



Notes
(0004949)
Frans   
2014-07-04 15:09   
Correccion: if ( ! $mv) ...
(0004973)
paulh   
2015-04-25 18:46   
f52b9df resolves, thanks Frans





View Issue Details
1925 [SiT!] users minor have not tried 2014-03-19 16:05 2015-04-25 14:47
ivan  
paulh  
normal  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Notifications are not deleleted when a user account is disabled
When a user account is disabled notifications/system actions relating to that user remain meaning emails get sent and useless notifciations get created.
Notes
(0004972)
paulh   
2015-04-25 14:47   
b4a9788 removes these





View Issue Details
1926 [SiT!] incidents minor have not tried 2014-03-20 10:09 2015-04-25 14:46
ivan  
paulh  
normal  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Drafts are not deleted when a user is disabled
Drafts are not deleted when a user is disabled
Notes
(0004971)
paulh   
2015-04-25 14:46   
b4a9788 removes these





View Issue Details
1931 [SiT!] inventory minor have not tried 2014-04-10 13:39 2015-04-25 14:46
ivan  
paulh  
normal  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Private inventory items remain when a user is disabled
when a user is disabled Private inventory items remain and cannot be viewed or deleted by another user.

These items should either be reassigned to somebody else, or perhaps deleted, or maybe an admin should be able to do something with them.
Notes
(0004970)
paulh   
2015-04-25 14:46   
b4a9788 adds, as they where personal they shouldn't be reassigned or visible to someone else





View Issue Details
1960 [SiT!] authentication minor always 2015-03-11 14:13 2015-04-25 14:19
k1412 Linux  
Linux  
normal 2.6+later  
acknowledged 3.67 LTS  
open  
none    
none  
   
Add some variables for LDAP configuration
Hi everyone,
I use SiT with an OpenLDAP and I would use the roles in place of posixGroup.

For that, we must modify ldap.inc.php
I found it better to add some variables in the configure interface.

Behind patches and ldifs (user and role).

Good afternoon
Variables that I add in the interface are :
 - ldap_grpfulldn (TRUE)
 - ldap_grpobjecttype (organizationalRole)
 - ldap_grpattributegrp (roleOccupant)
user.ldif (547) 2015-03-11 14:14
http://bugs.sitracker.org/file_download.php?file_id=263&type=bug
roles.ldif (248) 2015-03-11 14:14
http://bugs.sitracker.org/file_download.php?file_id=264&type=bug
remove-variables-from-ldap.inc.patch (4,474) 2015-03-11 14:14
http://bugs.sitracker.org/file_download.php?file_id=265&type=bug
add-variables-to-configure-in-web-interface.patch (1,871) 2015-03-11 14:15
http://bugs.sitracker.org/file_download.php?file_id=266&type=bug
There are no notes attached to this issue.





View Issue Details
1955 [SiT!] dashboard minor always 2014-10-15 17:02 2015-04-25 14:17
dipohl Linux  
Linux  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
   
Division by zero in dashboard_my_incidents.php
From SiT! error log:

2014-10-15T17:54:25+02:00 ajaxdata.php Warning [2] Division by zero (in line 215 of file dashboard_my_incidents.php)
2014-10-15T17:54:25+02:00 ajaxdata.php Warning [2] Division by zero (in line 215 of file dashboard_my_incidents.php)
2014-10-15T17:54:31+02:00 ajaxdata.php Warning [2] Division by zero (in line 87 of file dashboard_my_incidents.php)
2014-10-15T17:54:31+02:00 ajaxdata.php Warning [2] Division by zero (in line 87 of file dashboard_my_incidents.php)
Notes
(0004960)
dipohl   
2014-10-15 17:20   
I fixed it with the following changes:

# diff dashboard_my_incidents.php dashboard_my_incidents.php.mine
87c87,89
< $i_sla_remain_percent = round((1-(($i_sla_remain/$i_sla_target)))*100);
---
> if ($i_sla_target != 0) {
> $i_sla_remain_percent = round((1-(($i_sla_remain/$i_sla_target)))*100);
> }
215c217,219
< $i_sla_remain_percent = round((1-(($i_sla_remain/$i_sla_target)))*100);
---
> if ($i_sla_target != 0) {
> $i_sla_remain_percent = round((1-(($i_sla_remain/$i_sla_target)))*100);
> }
(0004969)
paulh   
2015-04-25 14:16   
r7599 fixes, thanks dipohl





View Issue Details
1954 [SiT!] dashboard major always 2014-10-15 16:57 2015-04-25 13:54
dipohl Linux  
paulh Linux  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
   
dashboard_my_incidents.php shows closed tickets
mysql-server-5.1.73-3.el6_5.x86_64
php-mysql-5.3.3-27.el6_5.2.x86_64

Installed and activated the plugin v.1.44
Downloaded from here: http://sitracker.org/wiki/Dashboard_my_incidents [^]
I fixed the error by changing the select statement in this way:

# diff -u dashboard_my_incidents.php dashboard_my_incidents.php.mine
--- dashboard_my_incidents.php 2010-11-16 17:45:56.000000000 +0100
+++ dashboard_my_incidents.php.mine 2014-10-15 17:55:02.978146266 +0200
@@ -50,7 +50,7 @@
     $nasql .= "($now - lastupdated) AS timesincelastupdate, pr.name AS pname, pr.id as pid ";
     $nasql .= "FROM `{$dbIncidents}` AS i, `{$dbContacts}` AS c, `{$dbPriority}` AS pr ";
     $nasql .= "WHERE owner = {$sit[2]} AND contact = c.id AND i.priority = pr.id ";
- $nasql .= "AND (status!='2' OR status!='7' OR status!='9') ORDER BY pid DESC, i.id ASC ";
+ $nasql .= "AND (status not in (2,7,9)) ORDER BY pid DESC, i.id ASC ";
 
     $result = mysql_query($nasql);
     if (mysql_error()) trigger_error("MySQL Query Error ".mysql_error(), E_USER_WARNING);

Notes
(0004968)
paulh   
2015-04-25 13:54   
r7598 resolves this, thanks Dipohl





View Issue Details
1959 [SiT!] incidents block always 2015-02-26 07:24 2015-04-25 12:37
selvakumar Dell  
paulh Fedora  
normal 10  
assigned 3.67 LTS  
open  
none    
none  
   
in beta version v3.90 - not able to close incident immediately
getting error when closing the incident immediately - Billing: Addition Failed
select incident - select close - Close Immediately - enter data and close

getting Billing: Addition Failed error.
Screenshot_05 Feb. 26 12.49.gif (19,162) 2015-02-26 07:24
http://bugs.sitracker.org/file_download.php?file_id=262&type=bug
Notes
(0004967)
paulh   
2015-04-25 12:37   
reproduced using points based billing, error

)
2015-04-25T12:35:56+01:00 /sit4/incident_close.php Application Error [256] You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND transactionstatus = 10' at line 1 (in line 1517 of file /home/paulh/dev/paulheaneys-sit/lib/billing.inc.php)

[CONTEXT-BEGIN]
Array
(
    [transactionid] =>
    [amount] => -1
    [description] =>
    [rtnvalue] => 1
    [sql] => UPDATE `transactions` SET amount = -1, transactionstatus = 5 WHERE transactionid = AND transactionstatus = 10
)

[CONTEXT-END]
----------

2015-04-25T12:35:56+01:00 /sit4/incident_close.php Application Error [256] Transition reserved monies failed UPDATE `transactions` SET amount = -1, transactionstatus = 5 WHERE transactionid = AND transactionstatus = 10 (in line 1522 of file /home/paulh/dev/paulheaneys-sit/lib/billing.inc.php)

[CONTEXT-BEGIN]
Array
(
    [transactionid] =>
    [amount] => -1
    [description] =>
    [rtnvalue] =>
    [sql] => UPDATE `transactions` SET amount = -1, transactionstatus = 5 WHERE transactionid = AND transactionstatus = 10
)

[CONTEXT-END]





View Issue Details
1958 [SiT!] holidays minor always 2014-12-08 10:01 2015-04-25 12:30
paulh  
 
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
Macro not replaced on outbound holiday request emails
Hi,

YYYYYY has requested that you approve the following holidays:

Monday 8 December 2014, Full Day, Absent Sick


The user attached the following request

{holidayrequestnote}

Please point your browser to https://XXXXXX/holiday_request.php?user=156&mode=approval [^] to approve or decline these requests.
Regards
ProofID Webtrack
{holidayrequestnote} should be replaced
Notes
(0004966)
paulh   
2015-04-25 12:30   
???e85b0c6 resolves





View Issue Details
1953 [SiT!] inbound email block have not tried 2014-09-19 17:06 2015-04-25 11:52
cacheguard VMware VM  
paulh Debian GNU/Linux  
low 7 (wheezy) x64  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
IMAP over SSL don't work
Page: config.php?tab=email&cat=inboundemail

When I put "/ssl /novalidate-cert" in the "Incoming email connection options" field, the imap_open() function blocks (in the file fetchSitMail.class.php file).


- Open the page config.php?tab=email&cat=inboundemail
- Put "/ssl /novalidate-cert" in the "Incoming email connection options" field.
- Open the page /inboundemail.php


---> Blocking

- Remove the space between "/ssl" and "novalidate-cert"
- Open the page /inboundemail.php


---> Emails are fetched from the IMAPs server.
Removing the <space> between "/ssl" and "novalidate-cert" resolves the problem.


Notes
(0004965)
paulh   
2015-04-25 11:52   
The parameters need specifying without a space as per the documentation http://sitracker.org/wiki/Inbound_Email [^] though I have made a change in f9bf6dc to strip these out





View Issue Details
1963 [SiT!] incidents minor always 2015-04-24 08:20 2015-04-25 11:48
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
log cc lines don't wrap cleanly
from git 3.9 long cc lines don't always wrap cleanly see screenshot
wrapping.png (6,490) 2015-04-24 08:20
http://bugs.sitracker.org/file_download.php?file_id=267&type=bug
Notes
(0004964)
paulh   
2015-04-25 11:48   
ad930b8 resolves





View Issue Details
1962 [SiT!] search minor always 2015-04-24 08:16 2015-04-25 11:37
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta2  
search popup doesn't work
When searching (top right) on a incident number this doesn't pop up in current git

To work around add

var application_webpath = '/webtrack/';

at top of webtrack.js, obviously not the right fix
Notes
(0004963)
paulh   
2015-04-25 11:37   
b9cd80a resolves





View Issue Details
1123 [SiT!] authentication minor have not tried 2010-03-06 11:26 2015-04-20 13:19
ivan  
paulh  
normal  
resolved 3.51  
fixed  
none    
none Current GIT  
  4.0  
Trusted server mode broken
The config option 'trusted_server' claims that passwords will no longer be required with this enabled. However I don't think this has worked in a long time, the feature hasn't been maintained.

We should probably remove this for 3.60 and discuss whether to keep the feature in the long term (4.x and beyond).
Notes
(0002610)
ivan   
2010-03-06 15:29   
All the trusted_server option does right now is prevent passwords from being changed in the user profile. For 3.x I'm going to change the help on the config option but leave the option there.
(0002611)
ivan   
2010-03-06 15:33   
Reworded in svn r6201 for 3.x, a decision still needs to be made for 4.x
(0003821)
ivan   
2011-06-03 22:20   
Decision not made yet and feature freeze for 3.90 happened now, deferring until 4.0
(0004962)
paulh   
2015-04-20 13:19   
1df2703 adds in this functionality





View Issue Details
1957 [SiT!] LDAP feature have not tried 2014-11-27 11:21 2014-11-27 11:30
ivan  
 
normal  
acknowledged  
open  
none    
none  
   
Allow users to change their password when using LDAP auth
We should allow users to change their password when using LDAP auth. Currently we disable changing password See 0000979 but that's not particularly friendly.

A config option should be provided for this which defaults to the current behaviour (disable changing password).
There are no notes attached to this issue.





View Issue Details
979 [SiT!] authentication minor always 2009-10-13 20:58 2014-11-27 11:21
hphovercraft  
paulh  
normal  
resolved 3.45  
open  
none    
none Current GIT  
  3.90beta1  
Can't change password while authenticating via LDAP
When you are using LDAP to authenticate the user login, the change password functionality does not work. You can successfully change your password, and the request will go through. However, if you try to use the new password to login, it will not work. The old password will still work. Since it can't seem to push the new password back to the directory, I would probably suggest removing that capability when ldap is enabled.
Notes
(0002090)
ivan   
2009-10-14 09:29   
Thanks!
(0004933)
paulh   
2014-05-03 19:13   
a5ff8e47 prevents LDAP users changing their sit password





View Issue Details
1956 [SiT!] notifications minor always 2014-11-27 07:48 2014-11-27 07:48
baobab Linux  
Debian  
normal 7.7 Wheezy  
new  
open  
none    
none  
   
v3.9beta - notification of language - NOTICE_LANGUAGE_DIFFERS
When a NOTICE_LANGUAGE_DIFFERS issues, the link is malformed and repeats the Sit! web folder, for example if it is "sit", here is the link :

http://www.my-domain.com/sit/sit/user_profile_edit.php?mode=savesessionlang [^]

instead of (correct link) :
http://www.my-domain.com/sit/user_profile_edit.php?mode=savesessionlang [^]

create a user with a different language than the main language.
log in

a notice shall inform that the user language is not same as principal language, and propose to click in order to confirm this is right
Note : this may happen only when sit is installed in a sub-directory of the principal domain.
There are no notes attached to this issue.





View Issue Details
1927 [SiT!] other feature N/A 2014-03-20 20:37 2014-07-23 21:41
Frans Windows  
Windows  
low XP+Later  
acknowledged 3.67 LTS  
open  
none    
none  
   
Progress bar in function html_redirect
Hello,
I added these lines

    $valor = rand (10, 99);
    echo "<h2><img src='{$CONFIG['application_webpath']}images/gifs/cargando/c{$valor}.gif' /></h2>";

in the file: lib/html.inc.php
at line nbr: 113
which is in func: html_redirect
right after the lines:
    if ($headerdisplayed)
        {
            echo "<p align='center'><a href=\"{$url}\">{$GLOBALS['strContinue']}</a>

";
        }
The lines that I addes show a progress bar or progress circle,
random selected from 90 different symbols.
I add the images in a compressed file. I suppose you'll translate to english ...
It gives the user something to watch when he is waiting for the next screen to appear.
I do not know whether you prefer to have it here, a forum topic or some other internet page . . . ?
So I apologize if it is not apropiate here. I just want to help to make it better.
Greetings,
Frans
example_progress_bar.jpg (67,781) 2014-03-20 20:37
http://bugs.sitracker.org/file_download.php?file_id=245&type=bug
cargando.zip (445,334) 2014-03-20 20:38
http://bugs.sitracker.org/file_download.php?file_id=246&type=bug
cargando_23_july_2014.zip (1,643,381) 2014-07-23 21:33
http://bugs.sitracker.org/file_download.php?file_id=259&type=bug
examples.jpg (215,475) 2014-07-23 21:38
http://bugs.sitracker.org/file_download.php?file_id=260&type=bug
Notes
(0004928)
ivan   
2014-04-10 13:42   
Thanks
(0004937)
Frans   
2014-05-14 20:32   
I reached a total of 210 different animations.
(0004952)
Frans   
2014-07-23 21:35   
The uploaded file cargando_23_july_2014.zip
has 299 animations.
Just change the values in the rand function like this

  $valor = rand (100, 398);
  echo "<h2><img src='{$CONFIG['application_webpath']}images/gifs/cargando/c{$valor}.gif' alt=\" --------------------- {$valor} ------------------- \" /></h2>";

I have added the alt-tag just in case. It is not necessary.
(0004953)
Frans   
2014-07-23 21:41   
I programmed a page to show all the animations:
see uploaded file: examples.jpg


$permission = 5;

require ('core.php');
require (APPLICATION_LIBPATH . 'functions.inc.php');
require (APPLICATION_LIBPATH . 'auth.inc.php');
include (APPLICATION_INCPATH . 'htmlheader.inc.php');


echo "<table class='vertical' border=6>";
        
for ($k = 100; $k <= 397; $k += 3)
    {
    $columna1 = $k;
    $columna2 = $k+1;
    $columna3 = $k+2;
    
    echo "<tr><td>{$columna1}   <img src='{$CONFIG['application_webpath']}images/gifs/cargando/c{$columna1}.gif' alt=\"Imagen {$columna1}\" /></td>";
    echo "<td>{$columna2}   <img src='{$CONFIG['application_webpath']}images/gifs/cargando/c{$columna2}.gif' alt=\"Imagen {$columna2}\" /></td>";
    echo "<td>{$columna3}   <img src='{$CONFIG['application_webpath']}images/gifs/cargando/c{$columna3}.gif' alt=\"Imagen {$columna3}\" /></td></tr>";
    }

echo "</table>";

include (APPLICATION_INCPATH . 'htmlfooter.inc.php');





View Issue Details
1951 [SiT!] incidents minor always 2014-07-18 19:19 2014-07-22 02:09
paulh  
 
normal  
new  
open  
none    
none  
   
remove email to customer from update dropdown
This option should be removed as it confuses users and really has no place as emails are sent though the email page

This is a legacy option for when sit didn't have the ability to send emails, which was some time just before the last ice age
Notes
(0004950)
ivan   
2014-07-21 11:29   
This feature is still in use and does have a use case for email information obtained from outside the SiT! application. It's common to recieve information relating to an incident to a personal mailbox as well as the SiT! address.

Perhaps the wording could be better, but to be honest I can't think of better wording right now.

tl;dl: some discussion needed before we remove this one I think.
(0004951)
paulh   
2014-07-22 02:09   
There are two options in this drop down "email from customer" and "email to customer" I'm only proposing the removing the latter as there are valid cases for the former but we shouldn't be allowing the latter





View Issue Details
1949 [SiT!] SLAs feature N/A 2014-07-01 11:04 2014-07-01 11:04
paulh  
 
normal  
new  
open  
none    
none  
   
Resolution time in days
The resolution time is specified in days its not possible to have any smaller unit e.g. 0.5 days/4hours
There are no notes attached to this issue.





View Issue Details
1944 [SiT!] outbound email minor always 2014-06-06 21:58 2014-06-15 18:27
Frans Linux  
paulh centOS  
low 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
   
Program error in incident_email.
The size-check has a program error.
2014-06-06T12:51:05-03:00 incident_email.php Warning [2] trigger_error() expects at most 2 parameters, 3 given (in line ... of file incident_email.php)

Between size and filesize : has a comma instead of a point.
I checked in version 3.90 and I found the same error present in this file.

// Check file size before sending
if (filesize($filename) > $CONFIG['upload_max_filesize'] || filesize($filename) == FALSE)
      {
    trigger_error("User Error: Attachment too large or file upload error, filename: {$filename}, perms: ".fileperms($filename).", size:", filesize($filename), E_USER_WARNING);
   // throwing an error isn't the nicest thing to do for the user but there seems to be no way of
   // checking file sizes at the client end before the attachment is uploaded. - INL
   }
Notes
(0004947)
paulh   
2014-06-15 18:25   
Cheers Frans, good spot
(0004948)
paulh   
2014-06-15 18:27   
efa9e07 and r7597 resolve this, many thanks again Frans





View Issue Details
1946 [SiT!] incidents minor have not tried 2014-06-13 10:07 2014-06-15 18:23
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
Drafts icon shows on incident details when there is a draft owned by someone else
If a draft email exists for another user on the incident the draft icon appears though (obviously) you can't see the draft which is confusing
latest git
Notes
(0004946)
paulh   
2014-06-15 18:23   
a2f83c8 resolves this





View Issue Details
1948 [SiT!] incidents minor always 2014-06-15 16:00 2014-06-15 16:00
repostor Linux  
CentOS  
normal 6.4  
new 3.67 LTS  
open  
none    
none  
   
incident_attachment, does not store the attachment correctly
in version 3.65, it worked fine.
But after I applied 3.67, I can no longer upload attachment.

In order to get this working again; I have to manually copy the older version of the file.
So I have a workaround for it...

Here are the changes between 3.65 and 3.67.

[root@tomcat sit]# diff incident_attachments.php ../sit-3.63/incident_attachments.php
5c5
< // Copyright (C) 2010-2012 The Support Incident Tracker Project
---
> // Copyright (C) 2010-2011 The Support Incident Tracker Project
53c53
< $sql .= "VALUES ('public', '" . clean_dbstring(clean_fspath($_FILES['attachment']['name'])) . ", '{$_FILES['attachment']['size']}', '{$sit[2]}', 'user', NOW())";
---
> $sql .= "VALUES ('public', '{$_FILES['attachment']['name']}', '{$_FILES['attachment']['size']}', '{$sit[2]}', 'user', NOW())";
75c75
< "-" . clean_fspath($_FILES['attachment']['name']);
---
> "-".$_FILES['attachment']['name'];
83c83
< trigger_error('Failed creating incident attachment directory.', E_USER_WARNING);
---
> trigger_error('Failed creating incident attachment directory: '.$incident_attachment_fspath, E_USER_WARNING);
87,88c87,88
< $mv = @move_uploaded_file($_FILES['attachment']['tmp_name'], $newfilename);
< if (!$mv) trigger_error('!Error: Problem moving attachment from temp directory', E_USER_WARNING);
---
> $mv = move_uploaded_file($_FILES['attachment']['tmp_name'], $newfilename);
> if (!$mv) trigger_error('!Error: Problem moving attachment from temp directory to: '.$newfilename, E_USER_WARNING);
[root@tomcat sit]# mv incident_attachments.php incident_attachments.php.367
[root@tomcat sit]# cp -p ../sit-3.63/incident_attachments.php .

Regards Tomas
not sure how your environment differs from my, but I did this:
1. create an incident
2. I selected "files" on the incident
3. I selected "browse" button
4. I selected a file -> OK
5. I selected "attach file"

The file gets attached; but no name of the file.
Only size; date, etc.
There are no notes attached to this issue.





View Issue Details
1945 [SiT!] incidents minor sometimes 2014-06-12 14:28 2014-06-12 14:30
Frans Linux  
CentOS  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
Duplicated incidents
The users (engineers) are complaining about duplicated incidents.
I suspect they do a refresh of the page which assigns the incident to an engineer.
This refresh causes the duplication of the incident --> Reproducible.
The users pretend they don't do that (but I do not believe them).
Anyways, I included a test before creating the incident.
In the file incident_add.php, before the "insert into incidents",
I check the existence of an incident with the same title,
from the same user and for the same contact registrated
within the last three minutes.


    $lapso = $now - 180; // 180 sec = 3 min
    $ya_existe = exec_sql ("select id value from incidents where title = '{$incidenttitle}' and owner = '{$sit[2]}' and contact = '{$contactid}' and opened > {$lapso} ; ");
    if ($ya_existe != "")
        {
        $nombre = contact_realname ($contactid);
        $message = "Already exists an incident with title: {$incidenttitle}
Created by yourself for the contact {$nombre}
The incident number is ".$ya_existe.".";
        html_redirect ("main.php", FALSE, $message);
        return;
        }
Notes
(0004945)
Frans   
2014-06-12 14:30   
function exec_sql($sql) // Devuelve un solo campo de un solo registro ! El nombre del campo = "value".
    {
    $val = "";
    $result = mysql_query($sql);
    if (mysql_error()) trigger_error($sql." -- ".mysql_error(), E_USER_WARNING);
    
    // debug_log ("Frans exec_sql = ".$sql);
    
    if ($result != false)
        {
        if (mysql_num_rows($result) > 0)
            {
            $inf = mysql_fetch_object($result);

            // debug_log("Frans exec_sql inf.value = ".$inf->value);
        
            $val = $inf->value;
            }
        mysql_free_result($result);
        }
    return $val;
    }





View Issue Details
1942 [SiT!] permissions minor always 2014-06-02 13:15 2014-06-02 13:39
paulh  
 
normal  
new  
open  
none    
none  
   
Confusing permission 42 PERM_UPDATE_DELETE
This permission is used by the holding queue and the name isn't very descriptive of the role it plays
Notes
(0004944)
ivan   
2014-06-02 13:39   
Off the top of my head I think it was supposed to say whether somebody was allowed to delete entries from the holding queue. Not a great name though whether that was the purpose or not.





View Issue Details
1940 [SiT!] SLAs minor always 2014-05-29 08:47 2014-05-29 09:40
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
resolution/reprioritisation shows as missed when non defined in SLA
In sit4 we allow SLA targets to not be defined if you don't define a r/r closed incidents show as missing the r/r as its not defined in the SLA definition see attached
resolution.png (13,192) 2014-05-29 08:47
http://bugs.sitracker.org/file_download.php?file_id=257&type=bug
Notes
(0004943)
paulh   
2014-05-29 09:40   
7d86bae resolves this, forcing the targettime to be an int using intval as for some reason php was seeing 0 as a float





View Issue Details
1941 [SiT!] SLAs minor have not tried 2014-05-29 08:49 2014-05-29 08:49
paulh  
 
normal  
new Current GIT  
open  
none    
none  
   
Incorrect status summary graph
In sit4 (current git) the status summary graph doesn't seem to add up, see attached (screen shot taken 08:48 BST) not sure how it can calculate 50minutes of active where it should have been 22 mins

the server local time is in UTC but that doesn't make up for the difference

chart.png (17,348) 2014-05-29 08:49
http://bugs.sitracker.org/file_download.php?file_id=258&type=bug
There are no notes attached to this issue.





View Issue Details
1939 [SiT!] outbound email feature N/A 2014-05-26 16:39 2014-05-26 16:42
Frans Linux  
Cent OS  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
Feature: history outgoing email
New feature.
Keep the history of all outgoing emails in the database.
I have added my solution to this feature request.
So, it is easier (less work) to include it in the new release or the new version.
I translated some texts from spanish to english, maybe I forgot one.
create the table.sql (827) 2014-05-26 16:39
http://bugs.sitracker.org/file_download.php?file_id=253&type=bug
calling_the_function_to_save_record.txt (433) 2014-05-26 16:40
http://bugs.sitracker.org/file_download.php?file_id=254&type=bug
save_a_record.php (1,028) 2014-05-26 16:40
http://bugs.sitracker.org/file_download.php?file_id=255&type=bug
rep_hist_outgoing_email.php (5,177) 2014-05-26 16:41
http://bugs.sitracker.org/file_download.php?file_id=256&type=bug
Notes
(0004942)
Frans   
2014-05-26 16:41   
I have added a report which exports the records to a file: filter is date.





View Issue Details
1938 [SiT!] reports minor always 2014-05-19 13:45 2014-05-19 14:30
Frans linux  
centos  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
Statistics shows wrong day in first column.
Using dashboard_statistics: open the statistics page
using the button of this dashboard table.
The first column has the names of the days.
One day is missing.
The reason for the missing day is the time zone, which is negative in south America.
Solution added.
File : statistics.php
Lines 241->245 and 255->259 and 263->266.
Change the first parameter of the first mktime.
Change zero hours to 12 hours.
statistics.php (25,491) 2014-05-19 13:45
http://bugs.sitracker.org/file_download.php?file_id=251&type=bug
statistics_daybreakdown.inc.php (1,617) 2014-05-19 14:25
http://bugs.sitracker.org/file_download.php?file_id=252&type=bug
Notes
(0004940)
Frans   
2014-05-19 14:24   
Same correction in the file: inc\statistics_Daybreakdown.inc.php
(0004941)
Frans   
2014-05-19 14:30   
The file statistics_Daybreakdown.inc.php
has an error in the line: 34
echo "<h2>".sprintf($strStatsFromDayStatistics, $dateString);
Must be $dayString :
echo "<h2>".sprintf($strStatsFromDayStatistics, $dayString);





View Issue Details
1936 [SiT!] incidents minor always 2014-05-12 14:23 2014-05-16 16:05
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
When using an incident number prefix incident links on notices no longer work
If you have a incident number prefix (say [INC) the popups no longer work on notices you get the following javascript error:

Uncaught ReferenceError: INC10 is not defined

HTML is javascript:incident_details_window([INC10])
Notes
(0004939)
paulh   
2014-05-16 16:05   
b7e3151 resolves with new trigger variable





View Issue Details
1937 [SiT!] outbound email feature N/A 2014-05-14 20:37 2014-05-14 20:39
Frans Linux  
CentOS  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
Feature: Send email non-incident related.
Feature request: sending email using a template.
1. From menu support: option "Send email".
2. From window incoming email: option "Send replay".
N/A
Description added in zip-file.
send_email_using_template.zip (128,665) 2014-05-14 20:37
http://bugs.sitracker.org/file_download.php?file_id=248&type=bug
Incoming_email.jpg (122,770) 2014-05-14 20:37
http://bugs.sitracker.org/file_download.php?file_id=249&type=bug
Menu_Support.jpg (26,059) 2014-05-14 20:38
http://bugs.sitracker.org/file_download.php?file_id=250&type=bug
Notes
(0004938)
Frans   
2014-05-14 20:39   
The zip-file contains the source-code.





View Issue Details
1935 [SiT!] setup/config minor have not tried 2014-05-07 09:57 2014-05-07 09:57
sandeep.maddela  
 
normal  
new 3.67 LTS  
open  
none    
none  
   
errors in login page
Notice: Undefined index: syslang in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 20

Notice: Undefined variable: hmenu in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 37

Notice: Undefined offset: 10 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 48

Notice: Undefined offset: 1020 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 58

Notice: Undefined offset: 1030 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 69

Notice: Undefined offset: 103010 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 88

Notice: Undefined offset: 103090 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 97

Notice: Undefined offset: 1040 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 103

Notice: Undefined offset: 20 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 112

Notice: Undefined offset: 2010 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 121

Notice: Undefined offset: 2020 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 127

Notice: Undefined offset: 2030 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 133

Notice: Undefined offset: 203010 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 146

Notice: Undefined offset: 30 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 172

Notice: Undefined offset: 40 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 181

Notice: Undefined offset: 50 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 188

Notice: Undefined offset: 60 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 195

Notice: Undefined offset: 6050 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 209

Notice: Undefined offset: 70 in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 224

Notice: Undefined index: lang in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 227

Notice: Undefined index: auth in C:\Program Files (x86)\EasyPHP-12.1\home\sit-3.67\lib\strings.inc.php on line 234
There are no notes attached to this issue.





View Issue Details
1934 [SiT!] notifications minor always 2014-05-06 08:49 2014-05-06 15:08
paulh  
 
normal  
new Current GIT  
open  
none    
none  
   
new held email template produces broken link
the new held email (holding queue) produces the following body

There's a new email in the holding queue. You can view it at: http:///holding_queue.php [^]

Which is missing the server name etc from the URL
Notes
(0004935)
paulh   
2014-05-06 15:01   
(edited on: 2014-05-06 15:03)
This fails due to the application_url function in lib/functions.inc.php thinking $CONFIG['application_uriprefix']) is empty and trying to use $_SERVER['HTTP_HOST'] which obviously isn't set as this is being called from a cron job


Though this config option is set

(0004936)
paulh   
2014-05-06 15:08   
On further investigation $CONFIG['application_uriprefix']) wasn't actually set in the DB or the config file even though the config pages showed it as set, this is because core.php trys to get this and set the config variable though this doesn't work in cron as _SERVER isn't populated





View Issue Details
1263 [SiT!] triggers minor have not tried 2010-04-12 13:22 2014-05-06 14:57
sancho78rus Linux  
Linux  
normal 2.6+later  
confirmed 3.60 LTS  
open  
none    
none  
   
NOTICE_NEW_HELD_EMAIL trigger dont work
NOTICE_NEW_HELD_EMAIL trigger dont work for new email.
And should it work if incident logged via portal?
Notes
(0003034)
kieran   
2010-04-12 13:37   
As per http://sitracker.org/forum/viewtopic.php?f=4&t=1417049 [^] the SQL code fetches ALL waiting emails but we only want one.

As for the incident logged via portal, no because that's not an email. 4.0 has a TRIGGER_PORTAL_INCIDENT_CREATED trigger though.
(0003035)
sancho78rus   
2010-04-12 13:47   
May be can you include TRIGGER_PORTAL_INCIDENT_CREATED in 3.61 if itis not hard to do? Because its very important trigger.
(0003037)
kieran   
2010-04-12 14:08   
Unfortunately, 3.x is bug fixes only and this counts as a feature.

It'll be very easy for you to add though, the code is here:

http://gitorious.org/sit/xerosis-sit/commit/75b132d5d56f8fd987256ada5e5b92ec3ca77cc5 [^]

The only difference is the last file for 3.x will be:
trigger('TRIGGER_PORTAL_INCIDENT_CREATED', array('incidentid' => $incidentid));
(0003038)
sancho78rus   
2010-04-12 14:34   
i cannot find where to paste in lib/triggers.inc.php
(0003039)
kieran   
2010-04-12 14:53   
Sorry, lib/triggers.inc.php is called lib/triggertypes.inc.php in 3.x.
(0003040)
sancho78rus   
2010-04-12 17:29   
thanks! it works now! (I mean TRIGGER_PORTAL_INCIDENT_CREATED)
(0003108)
kieran   
2010-04-24 21:24   
Test fixed pushed to git 10ca386, might be backported to 3.61 depending on testing.

http://sit.pastebin.com/zJ3qT9Sr [^] for details of creating an appropriate trigger.
(0003186)
ivan   
2010-05-29 11:27   
(pastebin above pasted here for posterity)

id triggerid userid action template parameters checks
39 TRIGGER_WAITING_HELD_EMAIL 1 ACTION_NOTICE NOTICE_MINS_HELD_EMAIL notifymins=1 {holdingmins} > {notifymins}
(0003187)
ivan   
2010-05-29 11:45   
I tried this today with 4.x and latest Git and I can't get a notice to appear. Bumping this to 3.62 now since there's no time to fix before 3.61 release (it's already overdue) and this is a longstanding issue that affects a non-core feature.
(0003296)
ivan   
2010-07-14 15:37   
Un-targetting this since there's no resource to fix it just now and I wouldn't say it was critical for the next release.
(0003302)
Tomse   
2010-07-16 22:19   
I've added the above mentioned trigger to the database, here are some issues:

Link to holding_queue.php points to http://holding_queue.php [^] - code string looks fine though, it has {applicationurl} shown.
every minute a new notice arrives and adds itself to the list.
no minute time is presented. (new message in holding queue for)





View Issue Details
1933 [SiT!] outbound email feature N/A 2014-05-04 17:01 2014-05-04 17:01
paulh  
 
normal  
new  
open  
none    
none  
   
Set display name on outbound emails
Currently the from field is set to just the support email address it would be nice to include a friendly name in this header as well e.g. "<Company Support>" support@company.com
There are no notes attached to this issue.





View Issue Details
1921 [SiT!] Skills minor always 2014-02-14 02:33 2014-05-03 19:38
OldMalden Linux  
paulh Linux  
normal 2.6+later  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
3.90 beta 1 Can't assign skills to users
Set up skills - Edit User Skills
Click Save and it presents a blank page ../sit/edit_user_skills.php
As description
Checking beta release.
Notes
(0004917)
paulh   
2014-03-02 17:13   
Hi, I've attempted to reproduce this one though don't seem to be able to with either 3.90beta1 or latest got, can you reproduce and post your web server error log?
(0004919)
OldMalden   
2014-03-02 18:22   
[Sun Mar 02 13:02:32 2014] [error] [client 10.178.1.8] File does not exist: /srv/www/htdocs/styles, referer: http://buzzard/sit/styles/silverblue/silverblue.css [^]
[Sun Mar 02 13:02:40 2014] [error] [client 10.178.1.8] File does not exist: /srv/www/htdocs/styles, referer: http://buzzard/sit/styles/silverblue/silverblue.css [^]
[Sun Mar 02 13:03:48 2014] [error] [client 10.178.1.8] PHP Fatal error: parse_str(): Input variables exceeded 1000. To increase the limit change max_input_vars in php.ini. in /srv/www/htdocs/sit/edit_user_skills.php on line 132, referer: http://buzzard/sit/edit_user_skills.php [^]

----

It's an error in the silverblue.css

Changed the css file to refer to ../styles in the silverblue.css.

Now just the variables error

Kerry Walsh
(0004920)
paulh   
2014-03-04 20:08   
Thanks OldMaiden, I've fixed the CSS in my local branch and will push shortly I've also reproduced the skills save issue and this happens when you have a large number of skills >1000 I'll look to get this fixed for the next beta

Thanks again
(0004934)
paulh   
2014-05-03 19:38   
55aac66 resolves this





View Issue Details
1932 [SiT!] authentication feature N/A 2014-05-03 18:46 2014-05-03 18:46
paulh  
 
normal  
confirmed  
open  
none    
none  
   
Support OpenID Connect authentication
Mantis 78 was logged to add support to authenticate via OpenID, OpenID is effectively dead (Google are dropping support imminently May2014) with OpenID Connect being the logical successor.

Logging a new feature request as OpenID and OpenID Connect are very different specs (very confusing given the name)
Notes
(0004931)
paulh   
2014-05-03 18:46   
Given linked incident





View Issue Details
1562 [SiT!] authentication tweak have not tried 2011-06-08 20:23 2014-05-03 18:43
ivan  
ivan  
normal  
resolved 3.64 LTS  
open  
none    
none Current GIT  
  3.90beta1  
Error: Your session has expired or you have not yet logged in
This is a message not an error, seems silly to make it an error.

I also think we should consider renaming it to

"Your session has expired, please log in to continue"

but that might be controversial.
Notes
(0003956)
paulh   
2011-06-14 19:28   
makes sense
(0004930)
paulh   
2014-05-03 18:43   
already fixed in git





View Issue Details
1802 [SiT!] authentication feature N/A 2012-09-13 16:06 2014-05-03 18:33
peisele Windows  
paulh Windows  
normal XP+Later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
  3.90beta2  
Email address as login for customer
It should be great if customers can use their email address to login
Notes
(0004521)
ivan   
2012-09-13 17:12   
I agree.

Thanks for the feature request!
(0004929)
paulh   
2014-05-03 18:33   
ceb0904 adds the ability to authenticate contacts via email address





View Issue Details
1929 [SiT!] SLAs feature always 2014-03-24 12:02 2014-04-10 13:43
47R3YU Linux  
Linux  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
SLA-Targets should always include the previous SLA-Targets
I start an ticket by selecting the "problem definition"-target. the "inital response"-target still runs its countdown and prompts me the message, that i didn't fulfill it.

Also, it isn't possbile to choose a previous SLA-Target, once you advanced. My wish would be, that the completion of a SLA-Target automatically stops the timers of the previous targets.
There are no notes attached to this issue.





View Issue Details
1928 [Incubator] General feature have not tried 2014-03-21 21:25 2014-03-21 21:25
raggedroster10  
 
normal  
new  
open  
none    
none  
   
New Parameters
Should the new parameters be adjusted further?
cbc56.html (4,528) 2014-03-21 21:25
http://bugs.sitracker.org/file_download.php?file_id=247&type=bug
There are no notes attached to this issue.





View Issue Details
1924 [SiT!] feedback minor have not tried 2014-03-17 17:55 2014-03-17 17:55
ivan  
 
normal  
new 3.66 LTS  
open  
none    
none  
   
SiT! requests feedback even when the engineer says "don't notify the incident is closed"
SiT! requests feedback even when the engineer says "don't notify the incident is closed"

This gives away that the incident is closed.

We should only request feedback when the engineer marks the incident to notify the customer.
There are no notes attached to this issue.





View Issue Details
883 [SiT!] portal minor have not tried 2009-08-17 16:03 2014-03-08 14:03
ivan  
 
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Portal users can't see about page, credits or license
I think portal users should be able to see the about page, or at least a version of it, it's important the people know this is a GPL application.
Notes
(0002183)
paulh   
2009-12-03 19:34   
I'm in two minds about this, especially letting people know the version as alot of organisations don't wish to give away two many details as it opens then up to potential vulnerabilities.

Perhaps if we have this there should be a config option to prevent it?
(0002209)
ivan   
2009-12-04 10:31   
It was the license and information about what software is included in SiT! and credits that I was most keen to display. The version number isn't terribly important to portal users really.

I agree an option could be created for this. My feeling is that we should show an about page, but not show version number unless the option is checked (off by default).

Confirming this myself (bad practice, but paul was doing it first :p) hehe
(0004926)
paulh   
2014-03-08 14:03   
fixed in git





View Issue Details
1923 [Incubator] General feature have not tried 2014-03-07 21:50 2014-03-07 21:50
rightfulshell72  
 
normal  
new  
open  
none    
none  
   
Monitor
Summary of Commands and Variables
gcx56.html (7,450) 2014-03-07 21:50
http://bugs.sitracker.org/file_download.php?file_id=244&type=bug
There are no notes attached to this issue.





View Issue Details
1875 [SiT!] i18n minor always 2013-05-03 10:28 2014-03-04 20:53
gigarun Linux  
paulh Debian server  
low 12  
assigned 3.67 LTS  
open  
none    
none  
  3.68  
Default language
Hello ; i'm a french tester ; my problem is :
in control panel - configure - system i disable all languages except french
and i put the default language on french.
When i create an user ; is default language while opening a session is still En-Gb...So each user need to edit is own profile and modify lang.
i need the french lang by default for each profiles. (users ; customers...)
Thanks
Notes
(0004796)
gigarun   
2013-05-03 10:30   
like 0001873 also !
(0004798)
Tomse   
2013-05-04 08:47   
(edited on: 2013-05-04 08:48)
I've seen this

thanks for reporting this

(0004922)
paulh   
2014-03-04 20:53   
b205b2e resolves for users in Git, need to sort contacts and also port to SVN





View Issue Details
1804 [SiT!] sites & contacts minor always 2012-09-24 08:28 2014-03-04 20:34
nicdev Windows  
paulh Windows Server  
normal 2000+Later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
  3.90beta2  
Missing country SERBIA from country list
In SiT!, the language dropdown is hardcoded (function country_drop_down), and it does not include "SERBIA" and possibly others.

It could be good to turn this into a DB table, to avoid further issues in the future?

Ciao
Notes
(0004528)
paulh   
2012-09-24 09:17   
Confirmed, don't think the country list has been updated in the last few years so 'new' countries recognized by ISO haven't been added, we should review the whole list.
(0004529)
paulh   
2012-09-24 09:53   
http://www.textfixer.com/resources/dropdowns/country-list-iso-codes.txt [^]
(0004530)
ivan   
2012-09-24 14:13   
Agreed. A DB table would be good, or the least a file to include or something so that it's easy to update.
(0004531)
nicdev   
2012-09-24 14:30   
Thank you Paul and Ivan.

what do you prefer? For me a DB table jumps to mind first, but involves a lot of changes (especially for the 3.x LTS branch), so from a time limit point of view I suggest a txt file, in /inc/ directory of 3.9x, and just an update of the Country list in that function in 3.x.

If we can come to agreement I propose to do the code changes :-)
(0004921)
paulh   
2014-03-04 20:34   
Fixed in 4ec2bd5, we now store the countries in the db and reference based on ISO code which should permit i18n in the future and also easy addition





View Issue Details
1922 [SiT!] incidents text always 2014-02-17 17:32 2014-03-02 16:57
skyrack_technology Linux  
paulh Linux  
normal 2.6+later  
resolved 3.65 LTS  
fixed  
none    
none Current SVN  
   
New incidents added from customer portal contain \r\n (unfixed bug 0001296 from v3.60)
When adding new incidents as customer from "portal", the text is not subsequently displayed properly, specifically, returns are not included and are instead replaced with \r\n.

This appears to be unfixed bug, ID 0001296 from v3.60

Log in to portal as customer, add incident with multi-line problem description.
Submit.
View same incident again in customer portal.
Fix:

in functions.inc.php
for function new_update()
comment out as follows:
//$text = clean_dbstring($text);

[seems to work, though I'm not set up to do a full regression test across whole platform]
Notes
(0004916)
paulh   
2014-03-02 16:57   
This was resolved in git over a year ago and now fixed in svn (r7595)





View Issue Details
1296 [SiT!] incidents minor always 2010-04-23 14:11 2014-03-02 16:56
waynem Windows  
paulh Windows  
normal XP+Later  
resolved 3.60 LTS  
fixed  
none    
none Current SVN  
   
new incident added, text in description has returns converted to \r\n
when adding new incident, problems description containing returns, all returns are converted to "\r\n"
add incident,

make sure serveral lines of text are added, leave blank lines between a few of the lines
problem is due to "cleanvar($text);" being called in function new_update
\lib\functions.inc.php' line 8096.

because cleanvar has already been called in \portal\add.php the second call converts returns to "\r\n"


eg.
    $text = cleanvar($text);

change to
    //$text = cleanvar($text);


Notes
(0003364)
paulh   
2010-08-21 17:46   
Can reproduce with latest SVN, steps

1) In customer portal create incident
2) View in portal you get "hello\r\n\r\nthis should\r\napparent\r\n\r\nincrease the number of lines"


when you view as a sit engineer all is fine
(0004915)
paulh   
2014-03-02 16:56   
This was resolved in git over a year ago and now fixed in svn (r7595)





View Issue Details
1916 [SiT!] SLAs feature N/A 2014-02-10 11:47 2014-02-13 10:29
Frans Windows  
Windows Server  
normal 2000+Later  
acknowledged 3.67 LTS  
open  
none    
none  
   
Define working days and start/end of working day for service level.
SiT! has the posibility to define working days and start/end of working day.
This works fine when it applies to all customers.
Now we have the situation that we have customers in different countries (south America)
and they have differences in working days/hours.
We also have different contract agreements with the customers.
For one part we have: the "service levels".
By the way: I redefined this to "type of contract" (but in spanish).
The best example of a special "contract agreement" is 24/7.
Service garanteed for 24 hours a day 7 days a week.
In this case the calculation of SLA fails completely.
So the proposal is to define the working days and working hours
at the level of the contract or the "service levels".
My first idea was to link it to the customer (=site), but this
does not cover the situation that this customer has two different
contracts one with normal workhours other 24/7.
So the best solution is to define it in the "service level".
The proposal is to add three fields:
 - working days
 - start of working day
 - end of working day
to the service levels.
That is the easy part.
The most difficult will be to change all the calculation to use these new definitions.
Notes
(0004905)
paulh   
2014-02-10 19:36   
Hi Frans,

I agree this would be useful though is a significant change and previous attempts to modify how durations are counted which don't fit into a straightforward formula have resulted in significant performance impacts on moderately large systems.

I agree we should aspire to this though we need to be careful
(0004907)
Frans   
2014-02-12 20:02   
I suppose the performance impact is due to the calculation/recalculation in the tables of the dashboard. Maybe this information should be stored in a database table to avoid recalculation.
Another related issue: the holidays of one customer may not be same as other customers because they are in another country !
(0004911)
ivan   
2014-02-13 10:29   
I think this is a very unusual and special case. The working day settings are intended to apply to the organisation who is providing the support not to the organisation you are providing support to.

While I understand the issue I don't think addressing this is something that would benefit a lot of people.





View Issue Details
1825 [SiT!] SLAs major always 2012-12-20 22:44 2014-02-13 10:25
SLionB Linux  
paulh Linux  
immediate 2.6+later  
assigned 3.67 LTS  
open  
none    
none  
   
calculate working time is buggy, does not support holidays
I has broken my head with this ugly function at the heart of SiT!
Based on it are SLAs, so if it is buggy its a huge problem.
put start_time, end_time and start creating incidents.
Clock is counting even if it is not working hours.
It also support holidays.
I hope it will help a lot of people.
Implement my replacement function;

function calculate_working_time($t1, $t2,$holidays)
{
    DEFINE ('ONEMINUTE', 60);

    // ESTABLISH THE MINUTES PER DAY FROM START AND END TIMES
    global $CONFIG;
    $start_ts = $CONFIG['start_working_day'];
    $end_ts = $CONFIG['end_working_day'];
    $working_days = $CONFIG['working_days'];

    // FUTURE UPDATE MUST HAVE READABLE DATES AND NOT SECONDS FROM MIDNIGHT
    //$start_time = '09:00';
    //$end_time = '17:00';
    //$start_ts = strtotime($start_time);
    //$end_ts = strtotime($end_time);

    $minutes_per_day = (int)( ($end_ts - $start_ts) / 60 );

    // CONVERT HOLIDAYS TO ISO DATES
    foreach ($holidays as $x => $holiday)
    {
        $holidays[$x] = date('Y-m-d', strtotime($holiday));
    }

    // CHECK FOR VALID DATES
    if (!$start = $t1) die('Invalid START Date');
    if (!$end = $t2) die('Invalid END Date');
    $start_p = date('Y-m-d H:i:s', $start);
    $end_p = date('Y-m-d H:i:s', $end);
 
    // MAKE AN ARRAY OF WORK MINUTES
    $workminutes = array();

    // ITERATE OVER THE DAYS
    $start = $start - ONEMINUTE;
    while ($start < $end)
    {
        $start = $start + ONEMINUTE;
        // ELIMINATE HOURS BEFORE BUSINESS HOURS
        $daytime = date('H:i', $start);
        if(($daytime < date('H:i',$start_ts))) continue;
        // ELIMINATE HOURS PAST BUSINESS HOURS
        $daytime = date('H:i', $start);
        if(($daytime > date('H:i',$end_ts))) continue;
        // ELIMINATE WEEKENDS - SAT AND SUN
        $weekday = date('w', $start);
        if (!in_array($weekday,$working_days))continue;
        // ELIMINATE HOLIDAYS
        $iso_date = date('Y-m-d', $start);
        if (in_array($iso_date, $holidays)) continue;
        $workminutes[] = $iso_date;
        // END ITERATOR
    }

    // HOW MANY WORK MINUTES?
    $number_of_workminutes = number_format(count($workminutes)-1);
    return $number_of_workminutes;
}
calculate_working_time.zip (1,951) 2013-02-17 19:41
http://bugs.sitracker.org/file_download.php?file_id=218&type=bug
Notes
(0004673)
paulh   
2013-02-03 15:30   
Thanks for the report and patch, unfortunately this is a long standing issue we've had I've tried to fix it before (see the commented out code in the function) unfortunately the counting approach is somewhat slow and on larger systems where calls last several months and there are several hundred open it takes long time to render incidents.php, I'll look at your code and look to fix this in an imminent release - I'm currently thinking we may need to cache this on the updates table per record to improve performance.
(0004695)
SLionB   
2013-02-07 11:13   
I had tried both the original function as the commented out one and is not accurate.
Instead this one is accurate.

at the end I forgot the number_format function used for debugging.

// HOW MANY WORK MINUTES?
$number_of_workminutes =count($workminutes)-1;
return $number_of_workminutes;

I dont have performance issues at the moment as I dont have so many open incidents for very long period of times.
Caching on the updates table will not function as this one which counts every active minute.
(0004708)
SLionB   
2013-02-17 19:46   
Inspired by the Microsoft's Excel networkdays function, I created a calculate_working_time that is based on a php networkdays function.
It calculates automatically the minutes of network days in between two dates and then adds the working minutes for the first and last day.
As there are no loops anymore, this is the best performance you could achieve even with many incidents open, with durations for months and years.





View Issue Details
1915 [SiT!] scheduler minor have not tried 2014-02-06 14:45 2014-02-06 14:45
Frans Windows  
Windows Server  
normal 2000+Later  
new 3.67 LTS  
open  
none    
none  
   
Condition in schedule_actions_due
    
I think the following line in the function schedule_actions_due()
     $sql .= "AND IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(lastran), -1) <= IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(laststarted), 0)";
has no sense, because ....
1 - When the job is running the condicion results in TRUE, and the job will be selected to run again,
    which is not the intention of this function ! (lastran < laststarted)
2 - When the job is not running the condicion is true: ok.
    
I thought to change this line to:
    $sql .= "AND IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(laststarted), -1) <= IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(lastran), 0)";
but this situation never exists, because the function schedule_action_done updates both fields in one sql.

I think the original intention of the programmer is to check that the job is NOT running, like this:
    $sql .= "AND laststarted = NULL";
Please inform me of the correct solutuon.
There are no notes attached to this issue.





View Issue Details
1912 [SiT!] dashboard minor always 2014-01-23 14:43 2014-02-02 10:55
Frans Windows  
paulh Windows Server  
normal 2000+Later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
   
Removing id 1 from dashboard removes also ids 10,11,12, ...
When removing a table from the dashboard,
suddenly also other tables disappear !
- Add tables to the dashboard. Be sure to include tables with id=1,10,11,12.
- Remove table with ID = 1.
- Check the result.
- Tables with id=10,11,12 also are removed.
Solution added.
manage_user_dashboard.php (4,104) 2014-01-23 14:43
http://bugs.sitracker.org/file_download.php?file_id=235&type=bug
Notes
(0004899)
paulh   
2014-02-01 10:34   
Thanks Frans, I can reproduce this one. Many thanks for the fix
(0004900)
paulh   
2014-02-02 10:55   
thanks Frans this is now resolved in r7539 and 494f3a7





View Issue Details
1911 [SiT!] scheduler minor always 2014-01-17 14:47 2014-02-01 09:57
metatech Linux  
Linux  
normal 2.6+later  
new 3.67 LTS  
open  
none    
none  
   
Long running auto.php can lead to scheduler tasks being disabled
When the execution of auto.php takes more than 1 minute, another auto.php instance is executed by cron in parallel.
This can generates errors and disable some tasks.
For instance, the "tms_backup" generates an SQL dump, then compresses it.
When the compression takes in total more than 1 minute, another auto.php recreates the SQL dump, which replaces the first one, which in turn aborts the first compression.
The task gets disabled permanently by the scheduler and must be reactivated manually.
See description.
There are no notes attached to this issue.





View Issue Details
1408 [SiT!] scheduler major always 2010-10-02 22:30 2014-02-01 09:57
Tomse  
 
normal  
new Current SVN  
open  
none    
none  
   
When job takes longer than time-to-next run of auto.php it's detected as missed
When running a job that takes longer time to finish, than the next run of auto.php the job is started multiple times.

set auto.php to run every minute.

run tms_backup with 7z as compression.
make sure there is enough data for it to take longer than 1 minute (or run on a slow computer)

it's easiest to see if you are using tms_backup v2.x because of it's view page.
for most scheduled jobs, this is not a problem, but another job that can cause trouble would be the "CheckIncommingMail" in case of a slow line to the mailserver and/or lots of attachments.
There are no notes attached to this issue.





View Issue Details
1913 [SiT!] holidays minor always 2014-01-24 12:51 2014-01-24 13:41
Frans Windows  
Windows Server  
normal 2000+Later  
new 3.67 LTS  
open  
none    
none  
   
Days to approve : shows the previous day.
holidays.php.
Show the days to approve.
The list shows all the days previous to the requested days
Example: Requested 12/02/2014. Shows 11/02/2014.
The time zone conversion causes this.
The database table has the value 12/02/2014.

Time zone south america.
A user requests holidays.
Show the days to approve.
The list shows all the requested days minus one.
The time zone conversion causes this.


Solution
I added 8 hours to the unixtime in line 114 of holidays.php.

   $dates->date = mysql2date($dates->date, TRUE);
   $dates->date += 8*3600; // Add 8 hours for timezone conversion. Frans


holidays.php (11,201) 2014-01-24 12:51
http://bugs.sitracker.org/file_download.php?file_id=236&type=bug
Notes
(0004894)
Frans   
2014-01-24 13:00   
The same happens in holiday_request.php: line 63.
(0004895)
Frans   
2014-01-24 13:20   
The same happens in holiday_request.php: line 248 (or 250).
(0004896)
Frans   
2014-01-24 13:25   
The same happens in holiday.php: line 193.
(0004897)
Frans   
2014-01-24 13:41   
holidays.php line 198
change date to ldate
echo ldate('jS F Y', $dates->date);
To show in the right language !





View Issue Details
1910 [Incubator] General feature have not tried 2014-01-10 06:09 2014-01-10 06:09
overconfidentic  
 
normal  
new  
open  
none    
none  
   
Monitor
Summary of Commands and Variables
uc (55).html (2,370) 2014-01-10 06:09
http://bugs.sitracker.org/file_download.php?file_id=234&type=bug
There are no notes attached to this issue.





View Issue Details
109 [SiT!] search feature N/A 2008-07-18 10:58 2013-12-22 19:47
ivan  
 
low  
confirmed  
open  
none    
none  
  4.1  
Tidy search page
Refactorise the search page, a lot of code is copied, it would be good to get a neat function or two if that's possible.
Notes
(0001136)
paulh   
2009-05-27 22:00   
More code than user functionality thus bumping
(0003008)
ivan   
2010-04-10 20:09   
Agreed to bump in irc meeting today





View Issue Details
65 [SiT!] triggers feature N/A 2008-07-11 17:53 2013-12-22 19:43
kieran  
 
normal  
acknowledged  
open  
none    
none  
   
Dynamic trigger variables
Instead of having triggers like:

Initial response due at 1pm

it'd be nice to have

Initial response due in 32 minutes

which change as the IR gets nearer.
Notes
(0003006)
ivan   
2010-04-10 20:06   
Agreed to bump in irc meeting today
(0004893)
paulh   
2013-12-22 19:43   
Updating as uncertain of priority with current workloads





View Issue Details
524 [SiT!] triggers feature N/A 2009-02-23 10:44 2013-12-22 19:42
ivan  
 
normal  
confirmed  
open  
none    
none  
  4.0  
Holiday approved email should be a trigger
When a holiday is approved (see holiday_approve.php) an email is sent, this should be a trigger so that this is properly configurable.
Notes
(0004573)
paulh   
2012-11-03 14:42   
as agreed on IRC





View Issue Details
1244 [SiT!] incidents minor have not tried 2010-04-08 14:53 2013-12-22 19:40
sancho78rus Linux  
ivan Linux  
normal 2.6+later  
resolved 3.60 LTS  
fixed  
none    
none Current GIT  
   
Closed incidents appears in waiting queue
It happens when you mark an incident for closure and then subsequently close it immediately, it will stay in the waiting queue for 7 days more.
Notes
(0002972)
ivan   
2010-04-08 15:47   
Thanks
(0002974)
paulh   
2010-04-08 16:28   
This is because the time to next action isn't cleared
(0003425)
anonymous   
2010-10-04 18:00   
Hi,

I can confirm this issue as it is happening to me as well. Is there any workaround?

thanks
Paul
(0004892)
paulh   
2013-12-22 19:40   
e54c62c in git clears timeofnextaction on closure





View Issue Details
1207 [SiT!] feedback feature N/A 2010-03-30 19:34 2013-12-22 19:37
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Feedback request on marking an incident for closure
We should probably only request feedback when an incident is actually closed and not just marked for closure
Notes
(0002904)
ivan   
2010-03-30 23:49   
Agreed, can't remember the history behind this, I have a feeling somebody requested that this happen on Marked for closure, but thinking about it now I can't see sense in it. It only makes sense to request feedback when you finally close the incident. We need to remember though that if we do this we need to make sure the auto-close also requests feedback.
(0002905)
Tomse   
2010-03-31 08:20   
as an addition to this.. when you mark it as closure, the form is being sent.

if an engineer manually closes it before it automatic happens, then the form is being sent again.

I haven't tested if the form is being sent when the incident automatically goes from mark for closure to closed
(0004891)
paulh   
2013-12-22 19:37   
Resolved in git ed40d26





View Issue Details
1893 [SiT!] inbound email feature N/A 2013-08-24 13:10 2013-12-21 17:46
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
Make inbound email visibility configurable
Inbound emails are hard coded to be hidden from the portal (line 303 of inboundemail.php), this should be configurable as given the emails have come from the customer (most likely) they should be shared by default
Notes
(0004887)
paulh   
2013-12-21 17:46   
57f2659 makes this configurable though defaults to hide (to maintain compatibility)





View Issue Details
1904 [SiT!] i18n minor always 2013-12-01 11:39 2013-12-21 17:34
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta2  
port pt-BR
port pt-BR from 3.x thanks to Bruno Renan for updating the translation
Notes
(0004886)
paulh   
2013-12-21 17:34   
1d144b4 merges this





View Issue Details
515 [Project plugin] Other feature have not tried 2009-02-20 20:31 2013-12-21 13:44
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current SVN  
   
interface to add categories
interface to add categories
Notes
(0004677)
paulh   
2013-02-03 15:36   
Changing to acknowledged, this plugin isn't maintained anymore though these are all useful additions
(0004885)
paulh   
2013-12-21 13:44   
added interface in svn





View Issue Details
1903 [SiT!] incidents tweak N/A 2013-11-25 19:41 2013-12-01 11:44
Frans  
 
low  
acknowledged 3.67 LTS  
open  
none    
none  
   
Feature : predefined texts
Select the error description from a list o predefined texts.
The same goes for the solution.
I added a short description which is in spanish, but you will get the idea.
I only want to report it as a new feature request, that's all.

Textos_predefinidos.pdf (169,954) 2013-11-25 19:41
http://bugs.sitracker.org/file_download.php?file_id=229&type=bug
Notes
(0004881)
paulh   
2013-12-01 11:44   
HI Frans,

I agree this could be a very useful addition





View Issue Details
1900 [SiT!] i18n trivial always 2013-10-23 21:48 2013-11-03 13:56
Frans Windows  
Windows  
none XP+Later  
confirmed Current GIT  
open  
none    
none  
  3.90beta2  
Change in size of language file.
Something happened with es-MX.inc.php.

Comparison:

Version 3.67
es-MX.inc.php: 96.379 bytes

Version 3.90
es-MX.inc.php: 68.917 bytes

I compared these two and there are a lot of missing entries
in the new version 3.90.

Notes
(0004879)
paulh   
2013-11-03 13:54   
3.9 is quite a significant change so there have been numerous string changes though it does look like some of the strings which have been translated in 3.x have not been translated to 3.9,

Thanks for letting us know.





View Issue Details
1899 [SiT!] other feature N/A 2013-09-27 10:12 2013-11-03 13:55
paulh  
 
normal  
confirmed  
open  
none    
none  
   
Prompt for skills when creating a product
We should prompt for skills when creating products otherwise we end up with a whole load of products with no skills
Notes
(0004880)
paulh   
2013-11-03 13:55   
Discussed with Ivan and he agrees





View Issue Details
1901 [SiT!] incidents feature N/A 2013-10-24 15:55 2013-11-03 13:51
Frans  
 
normal  
acknowledged  
open  
none    
none  
   
Date and time of the incident.
Feature request
When reporting an incident it is not posible to change the date and time of the incident.
It happens that the customer calls us when we are not in the office.
So we attend by cell phone and the next day we report this in SiT!
We would like to have the possibility to enter the day and the time of the incident.
Notes
(0004878)
paulh   
2013-11-03 13:51   
Interesting idea, I can see the use of this, unfortunately its not currently possible and would have significant impact on the SLAs (as they are likely to immediately be out) unless we allow changing of update times/SLA achieved times which has potential impacts on the accuracy of the data





View Issue Details
1902 [SiT!] plugin hooks tweak N/A 2013-11-01 14:51 2013-11-03 13:48
Frans  
paulh  
normal  
resolved  
fixed  
none    
none Current SVN  
  3.68  
Plugin contexts for incident_update.
Can you please add two more "Plugin contexts".

plugin_do('incident_update_form');

plugin_do('incident_update');
incident_update.php (34,457) 2013-11-01 14:51
http://bugs.sitracker.org/file_download.php?file_id=228&type=bug
Notes
(0004876)
Frans   
2013-11-01 14:52   
Version 3.67.
(0004877)
paulh   
2013-11-03 13:48   
Thanks Fran, I've added contexts to incident_update, these are named (inline with our 3.9 naming scheme)

incident_update_form
incident_update_submitted
incident_update_saved

This has been committed in r7587 and 71dd9f2)

Thanks again





View Issue Details
1898 [SiT!] users feature N/A 2013-09-18 20:54 2013-09-27 20:45
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Store users manager
It would be useful to record a users line manager in sit (perhaps on edit user page) as if we had this information we could direct alerts to the line manager for certain events such as for holiday requests, incidents about to leave SLA etc
Notes
(0004875)
paulh   
2013-09-27 20:45   
added in 1b84503





View Issue Details
1896 [SiT!] users minor always 2013-09-05 19:30 2013-09-14 17:12
paulh  
paulh  
normal  
resolved 3.66 LTS  
fixed  
none    
none Current GIT  
  3.90beta2  
Unable to set substitute to None
If you try and set the substitute for an skill to the user None after a substitute has been set it doesn't save this and keeps the previous engineer
Notes
(0004874)
paulh   
2013-09-14 17:12   
df616e1 resolves





View Issue Details
1897 [SiT!] incidents minor always 2013-09-05 23:53 2013-09-05 23:53
repostor Windows  
Windows  
normal XP+Later  
new 3.63p1  
open  
none    
none  
   
problem to create incidents: for contact@site1 assigned to contract@site2
Hi,

Here is how to reproduce the problem.
1. Create site A & B
2. Create contractA assigned to siteA
3. Create contactA at siteA, and another contactB at siteB
4. Assign contactB to contractA
   Note that contactB is belonging to another site (siteA), siteB does not have any contracts

Now login to SiT as contactB, and try to create an incident.
It shows an error that this contact has no enititlement.

If I update this contactB to be assigned to siteA instead, it works.
But I want the contactB to show up and belong to siteB.

Is this a bug, or a how to work problem?

Regards Tomas
Hi,

Here is how to reproduce the problem.
1. Create site A & B
2. Create contractA assigned to siteA
3. Create contactA at siteA, and another contactB at siteB
4. Assign contactB to contractA
   Note that contactB is belonging to another site (siteA), siteB does not have any contracts

Now login to SiT as contactB, and try to create an incident.
It shows an error that this contact has no enititlement.

If I update this contactB to be assigned to siteA instead, it works.
But I want the contactB to show up and belong to siteB.

Is this a bug, or a how to work problem?
There are no notes attached to this issue.





View Issue Details
1895 [SiT!] other feature N/A 2013-09-01 16:53 2013-09-01 16:53
paulh  
 
normal  
new  
open  
none    
none  
   
Replace drop downs with auto complete
Some of the dropdowns within SIT become difficult to use when there is lots of data (contacts etc) we should consider replacing these with autocomplete boxes,

contract_add_contact.php would be a good one to start with
There are no notes attached to this issue.





View Issue Details
1894 [SiT!] other feature N/A 2013-08-29 20:26 2013-08-29 20:27
paulh  
 
normal  
new  
open  
none    
none  
   
Mobile version of sit
It would be very good to have a mobile version of sit, which would include just core functionality such as open, edit, view incidents, perhaps browse contacts and sites.

This should be the default for mobile browsers though have a link to switch back to the full version.

This is a step up from a mobile friendly theme in actually reducing the options to make it mobile friendly
There are no notes attached to this issue.





View Issue Details
1016 [SiT!] theme feature N/A 2009-11-30 20:18 2013-08-29 20:27
paulh  
 
normal  
confirmed  
open  
none    
none  
   
mobile friendly theme
Would be good to have a mobile friendly theme.

Key goals would be:

* Small in size (no downloading a few hundred k of Javascript)
* Able to view details on a small(ish) screen

The current theme is usable on a mobile (as long as you only want the top level items) though does download quote alot of javascript which can take some time and is costly (£££)
Notes
(0002163)
ivan   
2009-12-01 09:50   
I made a start on this about a month or so ago before I got too busy to continue with it, I'll try and commit what I did so far.
(0002165)
paulh   
2009-12-03 16:14   
Ideally this doesn't want to be a theme have to select though get automatically if you access from a mobile browser.

This way you have the 'full' theme when your on your main machine and the light theme when your on your phone
(0002634)
ivan   
2010-03-09 11:54   
http://detectmobilebrowser.com/ [^]

<?php
$useragent=$_SERVER['HTTP_USER_AGENT'];
if(preg_match('/android|avantgo|blackberry|blazer|compal|elaine|fennec|hiptop|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|mobile|o2|opera m(ob|in)i|palm( os)?|p(ixi|re)\/|plucker|pocket|psp|smartphone|symbian|treo|up\.(browser|link)|vodafone|wap|windows ce; (iemobile|ppc)|xiino/i',$useragent)||preg_match('/1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s\-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|\-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw\-(n|u)|c55\/|capi|ccwa|cdm\-|cell|chtm|cldc|cmd\-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc\-s|devi|dica|dmob|do(c|p)o|ds(12|\-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(\-|_)|g1 u|g560|gene|gf\-5|g\-mo|go(\.w|od)|gr(ad|un)|haie|hcit|hd\-(m|p|t)|hei\-|hi(pt|ta)|hp( i|ip)|hs\-c|ht(c(\-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i\-(20|go|ma)|i230|iac( |\-|\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\/)|klon|kpt |kwc\-|kyo(c|k)|le(no|xi)|lg( g|\/(k|l|u)|50|54|e\-|e\/|\-[a-w])|libw|lynx|m1\-w|m3ga|m50\/|ma(te|ui|xo)|mc(01|21|ca)|m\-cr|me(di|rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(\-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)\-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|\-([1-8]|c))|phil|pire|pl(ay|uc)|pn\-2|po(ck|rt|se)|prox|psio|pt\-g|qa\-a|qc(07|12|21|32|60|\-[2-7]|i\-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h\-|oo|p\-)|sdk\/|se(c(\-|0|1)|47|mc|nd|ri)|sgh\-|shar|sie(\-|m)|sk\-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h\-|v\-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl\-|tdg\-|tel(i|m)|tim\-|t\-mo|to(pl|sh)|ts(70|m\-|m3|m5)|tx\-9|up(\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|\-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(\-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|xda(\-|2|g)|yas\-|your|zeto|zte\-/i',substr($useragent,0,4)))
header('Location: http://detectmobilebrowser.com/mobile' [^]);
?>





View Issue Details
1791 [SiT!] outbound email trivial always 2012-07-28 19:12 2013-08-24 19:39
windland Linux  
paulh CentOS  
normal 6.2  
resolved  
fixed  
none    
none Current GIT  
   
X-Originating-IP header causes SPAMASSASSIN to mark all sent emails as SPAM
All sent emails are considered SPAM (and rightly so!), by some mail servers running SPAMASSASSIN.
The cause of the problem is on the "X-Originating-IP" header having my internet IP address, instead of the server IP.

From the changelog, this was introduced in the 3.30 version:
Changes in v3.30 - Released 15 October 2007
* Send X-Originating-IP Header on outgoing emails to help prevent/diagnose abuse

At this current time,this doesn't make sense anymore, since it clearly does more harm than good.

My fix, was simply commenting the following line:

$extra_headers .= ": ".substr($_SERVER['REMOTE_ADDR'],0, 15)."\n";

on the following files:

/lib/functions.inc.php
/lib/incident.inc.php
auto.php
incident_email.php
All sent emails, will arrive in the form of a SPAM report with the original e-mail attached.

Example (Some names, hosts and IPs where altered for obvious reasons):

Spam detection software, running on the system "example.com", has
identified this incoming email as possible spam. The original message
has been attached to this so you can view it (if it isn't spam) or label
similar future email. If you have any questions, see
the administrator of that system for details.

Content preview: Message from SIT: Some One has approved your request
   for all days requested [...]

Content analysis details: (8.3 points, 5.0 required)

 pts rule name description
---- ---------------------- --------------------------------------------------
 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
 0.0 RCVD_IN_SORBS_DUL RBL: SORBS: sent directly from dynamic IP address
                            [AAA.BBB.CCC.DDD listed in dnsbl.sorbs.net]
 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
                            [AAA.BBB.CCC.DDD listed in zen.spamhaus.org]
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
 0.0 HELO_NO_DOMAIN Relay reports its domain incorrectly
 2.5 TO_NO_BRKTS_DIRECT To: misformatted and direct-to-MX

The original message was not completely plain text, and may be unsafe to
open with some email clients; in particular, it may contain a virus,
or confirm that your address can receive spam. If you wish to view
it, it may be safer to save it to a file and open it with an editor.
Notes
(0004499)
windland   
2012-07-28 20:02   
In the "Steps to reproduce" textarea, the line that causes the problem should read:
$extra_headers .= "X-Originating-IP: " . substr($_SERVER['REMOTE_ADDR'],0, 15) . "\n";

instead of:

$extra_headers .= ": ".substr($_SERVER['REMOTE_ADDR'],0, 15)."\n";
(0004500)
ivan   
2012-07-30 11:20   
Most webmail services use this header in the way that we do (i.e. Identifying the client IP), what makes you think that this is a bug?
(0004501)
itpp2012   
2012-07-30 15:09   
I discussed this on irc with the TS yesterday and found that the value is filled with a local LAN address, LAN addresses do not belong in headers. Ea. over here they add 'X-SourceIP' which are always WAN addresses. I've also commented them out as I don't want LAN addresses exposed to WAN traffic. This is apart from spamassassin issues. It's not a bug persee but an item from 2007 that today is no longer valid for its use. I'd rather see a config switch for those who do think its useful.
(0004507)
windland   
2012-08-04 23:11   
I'm in sync with itpp2012. You could call it a feature instead of a bug, but it still affects some users. Maybe nobody complained before because they where lazy/didn't want to bother finding the problem and reporting it, but I'm sure other people ran into it. SPAMASSASSIN is too popular to be just my server having this issue.

So, I agree that sending that header should be an optional feature that can be switched on/off.
(0004687)
ivan   
2013-02-03 15:50   
You've convinced me to treat this as a bug, we should at the very least make it configurable.
(0004873)
paulh   
2013-08-24 19:39   
2cd1bac adds a config variable, defaults to true to maintain compatability





View Issue Details
873 [SiT!] portal tweak have not tried 2009-08-15 18:26 2013-08-24 19:28
ivan  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
   
The count of articles in the portal KB is wrong
The count of articles in the portal KB is wrong

for me I see "Showing 1 to 4 of 4" when I have only 1.

(Only 1 record in my kbarticles table)
kbcountbug.png (82,589) 2009-08-15 18:27
http://bugs.sitracker.org/file_download.php?file_id=55&type=bug
Notes
(0002184)
paulh   
2009-12-03 19:35   
Unable to reproduce this with current trunk can people test/confirm
(0002238)
paulh   
2009-12-24 12:59   
Reminder sent to: ivan
Are you able to reproduce this one with the latest code?
(0003489)
paulh   
2010-11-30 21:15   
Can repro, problem with the SQL join

SELECT k.*, s.name FROM `kbarticles` AS k, `software` as s LEFT OUTER JOIN `kbsoftware` as kbs ON kbs.softwareid=s.id WHERE (k.docid = kbs.docid OR 1=1) AND k.distribution='public' GROUP BY k.docid ORDER BY k.docid DESC LIMIT 0, 20

SELECT k.*, s.name FROM `kbarticles` AS k, `software` as s LEFT OUTER JOIN `kbsoftware` as kbs ON kbs.softwareid=s.id WHERE (k.docid = kbs.docid OR 1=1) AND k.distribution='public'

Second returns 10 (one for each skill defined) where as first returns just 1 due to group by
(0003490)
paulh   
2010-11-30 21:16   
kbsoftware is empty in this case,
(0004872)
paulh   
2013-08-24 19:28   
GROUP BY clause previously added to git





View Issue Details
1124 [SiT!] feedback trivial always 2010-03-06 11:45 2013-08-24 19:21
Tomse  
paulh  
normal  
resolved Current SVN  
unable to reproduce  
none    
none Current GIT  
   
Using text field type in feedback, gives a very small text box for the contact
The textbox, the contact, is being given to type into, is very small
this should be larger.
feedback-textform.png (2,678) 2010-03-21 11:06
http://bugs.sitracker.org/file_download.php?file_id=100&type=bug
Notes
(0002764)
paulh   
2010-03-20 18:50   
Hi Tomse,

I'm unable to reproduce this issue, get large enough text boxes (60x6), I've just fixed an HTML issue though which could be causing odities, can you retest?
(0002780)
Tomse   
2010-03-21 11:05   
(edited on: 2010-03-21 11:06)
it looks good now..

I'm attaching a snip of a screendump, because now the formfield's text area is pushed all the way up against the border to the right.

Firefox on both Ubuntu and Windows 7
also IE8 on Win7

I'm not sure if we should add a new bug for this though

(0002788)
paulh   
2010-03-21 13:00   
Hi Tomse,

Could you possibly upload a larger screenshot as I can't see anything on that image

Cheers
Paul
(0002858)
ivan   
2010-03-24 21:25   
Reminder sent to: Tomse
Could you upload a larger screenshot of this?
(0002975)
Tomse   
2010-04-08 16:30   
what you are seeing (or not) is the lack of the border to the right..

I'll make an update about it when I come home
(0003019)
paulh   
2010-04-11 17:59   
(edited on: 2010-04-11 18:06)
Tomse showed me this on his setup, the HTML he has is:

<textarea name ='Q4' rows='
' cols='text' ></textarea>

compared to

<textarea name ='Q1' rows='5' cols='60' ></textarea>

which I'm getting with SVN, need to investigate

EDIT: managed to repro now

(0004871)
paulh   
2013-08-24 19:21   
Unable to repro in git, assumed resolved





View Issue Details
1223 [SiT!] sites & contacts minor always 2010-04-04 21:21 2013-08-24 19:14
sancho78rus Linux  
paulh Linux  
normal 2.6+later  
resolved 3.60 LTS  
fixed  
none    
none Current GIT  
   
Cannot reset Site salesperson
If you once set site's manager - you cannot delete it.
Notes
(0002926)
ivan   
2010-04-05 10:58   
I'm not sure what you mean.

Do you mean a sites Admin Contact (http://sitracker.org/wiki/Admin_Contact [^])

Can you post a list of steps to reproduce this?
(0002929)
sancho78rus   
2010-04-05 11:49   
sorry. i mean Salesperson of site
(0002932)
ivan   
2010-04-05 14:30   
I can confirm this with the latest 3.x branch, once you set a salesperson you can only change the salesperson you can't set it back to "None".
(0004870)
paulh   
2013-08-24 19:14   
d07278c resolves this, add an additional parameter to flag to the user drop down to allow non, defaults to false to maintain compatibility





View Issue Details
1253 [SiT!] sites & contacts feature always 2010-04-10 12:10 2013-08-24 18:53
Tomse  
 
normal  
resolved Current SVN  
fixed  
none    
none Current GIT  
   
Browse contacts shows dataprotected info
When browsing contacts, the result list shows dataprotected info like email and phone number, there is no indicator that those are dataprotected, the data protected fields should probably be replaced with some indicators that it's dataprotected.

by doing this, will limit the user errors of actually contacting the contact in those data protected ways after browsing. the only way one should be able to view those data should be by editing the contact.
Notes
(0002994)
paulh   
2010-04-10 14:25   
Agree, we hide the protected field on contact_details.php so we should be consistent
(0004869)
paulh   
2013-08-24 18:53   
0d1ab62036e62fb2138a392b114e2da4ed7911f0 doesn't show the fields if data protection is enabled





View Issue Details
1496 [SiT!] plugin hooks feature always 2011-04-21 18:39 2013-08-24 18:33
nicdev  
paulh  
normal  
resolved 3.63 LTS  
fixed  
none    
none Current GIT  
   
Add plugin do to incident_details.php for new plugn
We need to add a plugin_do() to the incident_details page for the plugin "plugin_extended_escalations":

the position is between line 145 and 146
what we used in the plugin is:
plugin_do('incident_details_escalated');
Notes
(0004868)
paulh   
2013-08-24 18:33   
cbe4472 adds these hooks





View Issue Details
1252 [SiT!] other text always 2010-04-10 08:53 2013-08-24 17:39
Tomse  
 
normal  
resolved Current SVN  
fixed  
none    
none Current GIT  
   
forgotten password sent, go back to login page
re: forgotpwd.php

(login page) Forgotten pass --> enter email -->

the return text is all the way to the left (should be centered)

More messages from this page are not centered (just follow the reset password through, also type in wrong username when that screen appears)
Notes
(0003239)
paulh   
2010-06-05 11:24   
Agree this is inconsistent

Not sure about it being a dupe of 1265 though
(0004867)
paulh   
2013-08-24 17:39   
129e6c931964d70084aec2fb048c1f2bb5faf413 centres this





View Issue Details
1580 [SiT!] incidents tweak have not tried 2011-06-14 16:02 2013-08-24 16:56
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
manage dashboard redirect broken
manage_dashboard.php calls html_redirect after the html header was included.
Notes
(0003947)
paulh   
2011-06-14 19:12   
Which line? Checked the file and can't see where html_redirect is called after including the header.

html_redirect and the includes are in different case blocks as far as I can see
(0003959)
ivan   
2011-06-14 19:40   
hmm I think I was wrong. I spotted the echo on line 120 and that threw me into thinking the header was already output. This bug is actually that an error is echo'd rather than passed to another html_redirect()
(0003961)
paulh   
2011-06-14 19:44   
OK confirmed, if theres an error we don't redirect at the moment anyway
(0004864)
paulh   
2013-08-24 16:56   
1a9e62e resolves





View Issue Details
1581 [SiT!] incidents tweak have not tried 2011-06-14 16:14 2013-08-24 13:46
ivan  
 
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
   
admin.php redirect broken
admin.php calls html_redirect after the html header was included. Made more complex because this page is shared for portal contacts and sit users.
Notes
(0003948)
paulh   
2011-06-14 19:13   
yeap, this is in portal/admin.php
(0004863)
paulh   
2013-08-24 13:46   
Fixed in

commit c84d7611f2e2b2d9c0099a153d4c45ae967b4c5e
Author: Ivan Lucas
Date: Wed Jun 15 22:30:02 2011 +0100

    Put the header include the correct place so the redirect works, the header must not be included before the red





View Issue Details
1890 [SiT!] i18n feature N/A 2013-08-18 12:31 2013-08-24 13:35
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta2  
Port fi-FI translation
Port the Finnish translation from 3.x to git
Notes
(0004861)
paulh   
2013-08-24 13:35   
7f6d3968e87f81ff6529c78ddb5a52f70f9237af ports this





View Issue Details
1892 [SiT!] incidents minor always 2013-08-24 12:58 2013-08-24 13:19
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta2  
Incident edit allows you to change the skill to one outside of the listed skills on the product
When editing an incident you get a full list of software items rather than those just listed on the contract which allows you to change the incident to a skill the customer isn't entitled to, this is inconsistent with the list when you open an incident and makes it very difficult for an engineer to know if a skill is supported under the contracted

Agreed with Ivan that we will change the functionality in 3.9
Notes
(0004860)
paulh   
2013-08-24 13:19   
a95be483e406fcf86b8c6692afa1fddbe2eabf25 resolves this and only shows the supported skills





View Issue Details
1888 [SiT!] inbound email minor always 2013-07-23 14:27 2013-08-24 13:09
nicdev Windows  
paulh Windows Server  
normal 2000+Later  
resolved Current SVN  
fixed  
none    
none Current SVN  
  3.68  
Inbound emails are not marked correctly as hidden from the portal
When an email arrives, the inboundemail.php script(line 303) marks the update as "No":
 $customer_visible = 'No';
It should instead be "hide"
e63203a15cefdc6c7d765c48beedd05342c05132 and r7584 resolve
Notes
(0004857)
ivan   
2013-07-23 14:57   
I can confirm this, the code says 'No' but the database schema for the updates table expects 'hide'. Problem exists in Git/3.90 as well.





View Issue Details
1891 [SiT!] Skills minor N/A 2013-08-24 12:54 2013-08-24 12:54
paulh  
 
normal  
new Current GIT  
open  
none    
none  
   
Merge skill_drop_down and softwareproduct_drop_down
These two functions:

skill_drop_down($name, $id)

softwareproduct_drop_down($name, $id, $productid, $visibility='internal')

Do broadly the same job with the code being very similar we should remove skill_drop_down and make productid optional on softwareproduct_drop_down (and perhaps remove the product from the function name)
There are no notes attached to this issue.





View Issue Details
1856 [SiT!] other minor always 2013-04-01 19:39 2013-08-19 16:36
paulh  
 
normal  
confirmed  
open  
none    
none  
   
When an engineers backup leaves the organisation the user should be notified to update their backups
When a users backup engineer leaves the organisation (account disabled) then they won't have a valid backup listed.

The user should be prompted to update their backups
Notes
(0004859)
ivan   
2013-08-19 16:36   
This should be implemented as a trigger that fires when a user account is disabled. (maybe we ought to have one for user account created too)

The bit about notifying to update the backups for skills should perhaps be left to the user.





View Issue Details
1855 [SiT!] other feature N/A 2013-04-01 19:37 2013-08-19 16:34
paulh  
 
normal  
confirmed  
open  
none    
none  
   
Notification when one of your backups removes the skill from their list
If one of your backups removes the skill from there list that they are they backup for a user then the user should receive an alert suggesting a new backup is choosen
Notes
(0004858)
ivan   
2013-08-19 16:34   
This should fire a trigger obviously so that the type of notification can be user-configurable.





View Issue Details
1889 [SiT!] security feature have not tried 2013-08-06 10:32 2013-08-06 10:32
ivan  
ivan  
urgent  
assigned  
open  
none    
none  
   
Better password hashing
We should allow users to configure the hash they would like to use for passwords by selecting from a list of hash algorithms that PHP supports.

We can store hashed passwords as we do now in the password column but with a prefix to indicate the has thats being used. e.g. sha1:d40283f5267bc0ef2ecd52c3794d20fdcff43f01 or ripemd128:20e4f5eae40e886050edf2c0efd6fb85

If there is no prefix we can assume it's the old style MD5 (as current). Using this method we can detect if somebody is using a hash from a previous configuration and prompt the user to change their password which can then be hashed using the new algorithm.
There are no notes attached to this issue.





View Issue Details
1887 [SiT!] incidents feature N/A 2013-07-13 13:13 2013-07-14 21:55
paulh  
 
normal  
confirmed  
open  
none    
none  
   
[META] Store more metadata about updates on incidents
Currently we store alot of metadata about an incident as part of the body text, examples of this include:

* Status Changes (awaiting customer -> Active)
* Priority
* External / Escalation ID
* Email addresses on emails (to, cc, from, bcc etc)

Storing these it the bodytext makes it very difficult to add value to this information such change the way its displayed, hide certain info (e.g. bcc), chart the life of an incident, search for particular statues without full etxt searches

We should look at storing this metadata in a more structured and meaning full way.
Notes
(0004856)
ivan   
2013-07-14 21:55   
definately. We've discussed this several times in the past, but somehow the daunting task of making the change has prevented us getting further than just talking about it.





View Issue Details
1886 [SiT!] triggers feature have not tried 2013-07-06 16:12 2013-07-13 17:55
ivan  
 
normal  
confirmed  
open  
none    
none  
   
Allow triggers to be edited
Currently after a trigger is created the only way to alter it is to delete it and recreate it. That's a bit of a pain so it would be good to allow the user to edit an existing trigger (for example to change the rules).
Some code for this already exists in the trigger class (3.90) but it's not exposed in the GUI.
Notes
(0004853)
paulh   
2013-07-13 17:55   
agree
(0004854)
paulh   
2013-07-13 17:55   
agree





View Issue Details
1883 [SiT!] templates minor have not tried 2013-07-03 13:47 2013-07-13 17:36
ivan  
 
normal  
confirmed 3.65 LTS  
open  
none    
none  
   
{nextslatime} shows date/time rather than number of minutes
The template variable {nextslatime} should show a number of minutes, but instead it's showing a date time.

e.g.
"The SLA target Initial Response will expire in 1st Jan 1970 @ 1:08am minutes."

should show

68 minutes (I think).
Notes
(0004852)
paulh   
2013-07-13 17:36   
Agree, in triggers its calling format_date_friendly where as it should probably be format_seconds





View Issue Details
825 [SiT!] notices minor always 2009-07-29 15:31 2013-07-13 15:45
Tomse  
 
normal  
resolved 3.45  
fixed  
none    
none Current GIT  
   
creating a kb article with no title should give an error, it doesn't
creating a kb article with no title should give an error, it doesn't
it continues successfully

kb_article.php
Notes
(0001910)
ivan   
2009-09-07 19:51   
It used to create an article named "untitled"
(0001912)
paulh   
2009-09-07 20:56   
so it did, now it just creates a article with an empty title.

I think we should mandate the saving of a title.
(0004851)
paulh   
2013-07-13 15:45   
Now mandatory in git/3.9





View Issue Details
824 [SiT!] i18n minor always 2009-07-29 15:21 2013-07-13 14:16
Tomse  
 
normal  
resolved 3.45  
fixed  
none    
none Current GIT  
   
move_update.php needs to be i18n
xerosis pointed out to me some erros might occur if I made the static texts into strings.

So I cannot do this one.
Notes
(0004848)
paulh   
2013-07-13 14:16   
i18n'ed in git/3.9





View Issue Details
614 [SiT!] outbound email minor always 2009-03-26 15:33 2013-07-13 14:13
paulh  
 
normal  
resolved 3.45  
fixed  
none    
none Current GIT  
   
Setting next action time when sending an email doesn't show text in the body
If you set a next action time when sending and an email it doesn't put this in the update
Notes
(0001538)
ivan   
2009-08-15 11:32   
Confirmed in trunk svn r5759
(0004847)
paulh   
2013-07-13 14:13   
Works in 3.9//current git





View Issue Details
447 [SiT!] reports minor have not tried 2009-01-27 11:17 2013-07-13 14:06
paulh  
paulh  
normal  
resolved  
fixed  
none    
none  
   
external_engineers report SQL
The filter SQL is appended twice to the sql statement at line151 as $sql has already had teh filter added and then we append $filterSQL
Notes
(0001533)
ivan   
2009-08-15 09:53   
I can confirm this at trunk r5756
(0004843)
paulh   
2013-07-13 14:06   
     
 0702e9f resolves





View Issue Details
811 [SiT!] reports minor have not tried 2009-07-26 13:45 2013-07-13 13:59
ivan  
 
normal  
confirmed 3.45  
svn5660 open  
none    
none  
   
report_incidents_by_skill.phpand report_incidents_by_engineer.php uses bodytext of "External ID" to determine escalation
$sqlL = "SELECT count(id) FROM `{$dbUpdates}` AS u ";
$sqlL .= "WHERE u.bodytext LIKE \"External ID%\" AND incidentid = '".$obj->id."'";


This is a very unreliable way to determine escalation and breaks if a language other than english is used. Or even if somebody uses the text "External ID" as part of an incident discussion.
Notes
(0001437)
paulh   
2009-07-26 19:52   
Acknowledging this, theres quite a few FIXMES scattered around SiT for this.

It was implemented this was as at the time (and too this day) its the only way to identify if a call has been escalated in its life time, this should be resolved by Neat Escalations (Mantis 10)
(0003917)
ivan   
2011-06-12 17:03   
report_incidents_by_engineer.php uses the same method.





View Issue Details
1153 [SiT!] calendar trivial always 2010-03-16 20:34 2013-07-13 13:56
Tomse BSD  
paulh FreeBSD  
normal 6.4+Later  
resolved Current SVN  
fixed  
none    
none Current GIT  
   
cannot book a whole day in the monthtly view
when standing in the monthly view and want to book a whole day "Book Holiday"
You can book in either AM or PM, if you book, in addition, in the other field the same day, the block moves to the newly chosen field, rather than adding a new one.

sit-20110831-1.png (15,174) 2011-08-31 16:44
http://bugs.sitracker.org/file_download.php?file_id=198&type=bug
Notes
(0002717)
paulh   
2010-03-16 20:40   
Can reproduce this with the latest code, though we'd fixed this one ages ago
(0004278)
ivan   
2011-08-31 16:44   
I can confirm this problem still exists with current Git (3.90)
(0004842)
paulh   
2013-07-13 13:56   
This has been fixed in a previous commit to git, you have to book both halfs separately though it no longer switches





View Issue Details
865 [SiT!] incidents minor always 2009-08-15 13:44 2013-07-13 13:54
Tomse  
paulh  
normal  
resolved Current SVN  
fixed  
none    
none Current GIT  
   
contract_add.php - doesn't remember all filled out fields
svn 5750

When filling out all fields, and one required is missing, the return page
doesn't remember all the filled out fields, and collapses the bottom.

This could lead to missing choices of "no requirements" when submitting the second time
Notes
(0001908)
paulh   
2009-09-07 19:32   
Confirmed this is still a problem in 3.x, the admin contact and Contacts radio button are not remebered
(0004841)
paulh   
2013-07-13 13:50   
5235689 resolve this





View Issue Details
1805 [SiT!] security major have not tried 2012-09-28 11:28 2013-07-13 13:14
ivan  
ivan  
normal  
assigned 3.65 LTS  
open  
none    
none  
   
BCC email address stored in log
When sending email the BCC email address is stored in log

To: test@example.com
From: test@example.com
Reply To: test@example.com
BCC: test@example.com
Subject: [48196] - Testing
Notes
(0004538)
Tomse   
2012-10-06 13:40   
The log you're refering to is the incident log (not related to debug_log)
(0004569)
paulh   
2012-11-03 13:37   
I think, for audit purposes, we need to retain this information as we need to know its been sent though I think it should be hidden from the portal as we don't want the customer seeing this
(0004689)
paulh   
2013-02-03 15:56   
The problem here is not that we are storing the bcc (which we need for audit) but that if the email is marked as visible in the portal customers can see the data which is wrong, we should separate the headers into a separate field





View Issue Details
35 [SiT!] incidents feature have not tried 2008-07-11 16:17 2013-07-13 13:13
ivan  
 
normal  
confirmed  
open  
none    
none  
  4.0  
Status changes in body text
As is stands, when a status is changed, an update like the following is put
into the update body:

Status: Active -> Awaiting Customer Action

This is bad because a) we can't search this b) we can't i18n it and c) the
portal users can see these updates, which differ from the external
statuses.

We currently store the currentstatus (most of the time, see SF#1930157) so
we can easily work this out on the fly without entering it into the update
body.


Date: 2008-06-21 19:22
Sender: kieran_hogg
Logged In: YES
user_id=1872958
Originator: YES

was quicker than I thought, test away!
                            

Date: 2008-06-21 19:12
Sender: kieran_hogg
Logged In: YES
user_id=1872958
Originator: YES

Okay, this won't work as it stands, I'll try and fix but it might get
reverted and put off til next release.
                            

Date: 2008-06-21 18:36
Sender: kieran_hogg
Logged In: YES
user_id=1872958
Originator: YES

I've just commited a fix for this, status changes are done in the log
rather than the body now. I'd like some feedback on this as it changes
something that's been the same for a long time. Also, despite the changes
being for i18n purposes, ironically we can't i18n it (without sounding
wooden) until next release, but it wasn't i18ned before so nothing lost.
Providing people like this change, for 3.35, we can do:

"New Status (Active) by Joe Bloggs"
pros: all the words are i18ned
cons: sounds wooden and probably won't make sense when translated

"Set to Active by Joe Bloggs"
pros: reads better
cons: not i18ned
                            
Notes
(0000107)
paulh   
2008-10-07 10:54   
Could probably come up with something fancy using the incidentstatus on updates though need to be careful of:

* reverse order logs
* Paging, would need to get one either side and only show some
(0001085)
ivan   
2009-05-20 13:11   
Changing this to a feature request, it's not really a bug is a change of design
(0001093)
kieran   
2009-05-23 17:48   
Not a priority atm.
(0003758)
paulh   
2011-04-18 20:35   
1a810ee895c937780de6969933e53de99b4b47ac goes someway to not hard coding the SLA update sin the body
(0004092)
ivan   
2011-07-05 12:15   
Bumping to v4.0 to help us meet our Roadmap targets for 3.90





View Issue Details
1877 [SiT!] i18n major N/A 2013-05-15 20:54 2013-07-06 18:54
paulh  
ivan  
normal  
resolved Current GIT  
open  
none    
none Current GIT  
  3.90beta1  
Port hu-HU translation to git
Currently the translation by Weibel György is only in svn we should port/update this for 3.9 and add to git
Notes
(0004840)
ivan   
2013-07-06 18:54   
Ported to Git 9128f7e90d2e17c9ebfea863fd571f15dab26c74





View Issue Details
827 [SiT!] i18n minor always 2009-07-29 16:17 2013-07-06 17:58
Tomse  
 
high  
confirmed 3.45  
open  
none    
none  
   
Translation page should be paginated
the translation page is growing quite large, and FF3.50 is quite slow when working with this page.

It should be paginated
Notes
(0001466)
paulh   
2009-07-29 19:20   
Not sure about paging in this instance, what about tabing? Perhaps by the first letter after the str of the variable?

It would also be useful if less than a certain percentage isn't translated show these untranslated words on the first tab rather than having to browse through them all?
(0001468)
ivan   
2009-07-29 20:20   
Paging by letter sounds more useful than a fixed limit per page initially, but some letters have far more strings than others. So maybe a mixture of letter navigation and fixed length pages is the answer. Either way we def. need to split that page up, it's HUGE. :-)
(0001502)
ivan   
2009-08-04 17:56   
Tomse got...

Fatal error: Maximum execution time of 30 seconds exceeded in C:\Inetpub\wwwroot\translate.php on line 261

...with this page now, it really is too big!
(0001503)
Tomse   
2009-08-04 19:00   
I guess it depends on the OS, hardware etc.
when I got the error I used a laptop with windows on it.

using my freebsd server went quite smooth.
(0002709)
modir   
2010-03-16 13:54   
Just as a side note: What would help me even more would be a page with untranslated strings. Or if I could select "all strings" or "only untranslated".
(0002710)
sancho78rus   
2010-03-16 15:47   
there must be option 'show all on one page' - it helps to search strings on page.
(0002711)
Tomse   
2010-03-16 15:55   
(edited on: 2010-03-16 15:58)
modir, if you are far in the translations and are missing some..
du a search in the browser (usually ctrl-f) and search for * this will help you find the strings that are missing.

I can recommend reading my little post here if you haven't done already:
http://sitracker.org/forum/viewtopic.php?f=11&t=1416984 [^]

hope this can help you at the moment.

(0002712)
ivan   
2010-03-16 16:22   
I'm having a look into this one since it's obviously causing a few problems for our much loved translators. I'll see what I can do.
(0002713)
modir   
2010-03-16 16:43   
Tomse, No I have not seen this forum post yet. Your post in the forum does "only" solve my problem, but not the problem this feature request is about.

With the note I added to this feature request I wanted to address several problems:

1) Too much information on one page.
2) Too long loading time.
3) Helping the translator to quickly translate some untranslated string (e.g. I often translate about 10 strings whenever I log into SIT. This doesn't take a lot of my time but still helps the project)

(I know that I am mixing here my request with "pagination/tabbing". But I wanted to give another view on problems users have with this functionality of the software. I am well aware that core developers are maybe more in the need for pagination because they are using the translation-functionality in a different way.)
(0002714)
ivan   
2010-03-16 17:05   
I'm working on the ability to show just untranslated strings or all strings. Once I've got that working I can make it display at most a certain number (say 25) strings on a single page and let you navigate backwards and forwards through the pages.

This is targeted for v4.0 but I'm very tempted to backport it to 3.60 once it's working since it's something that's obviously needed and it shouldn't affect anything else.
(0002715)
Tomse   
2010-03-16 17:19   
@Modir

I agree, and I know what you are up against,
this is also why I added this bug report, in the first place.


I'm very pleased with ericthefish finding the time to implement the pagination into 3.60 there are alot of things still needed to be done for 3.60.
So I really aprecitate the time you give us ericthefish!.
(0004637)
ivan   
2013-01-05 16:50   
Changing status to 'Assigned' not sure why it was marked for feedback. Tomse if you want to bump this please do.
(0004770)
ivan   
2013-04-17 16:48   
Look for a workaround for this as we may not have time to fix for 3.90. Perhaps chrome browser?
(0004813)
Tomse   
2013-05-04 14:45   
An idea is to split up the translation sections into alphabetic sorting based on the string names

$strActive = A

$strBilling = B

this way the translation can have

A B C D ..... links in the top of the page

and since we use the string names we'd be limited to A-Z
(0004839)
paulh   
2013-07-06 17:58   
We agree this is a useful feature though is a significant amount of work and Chrome works successfully





View Issue Details
1878 [SiT!] i18n major N/A 2013-05-15 20:55 2013-07-06 17:52
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current SVN  
  3.90beta1  
Port es-CO translation to git
Currently the Spanish Columbia translation by Andrés Felipe Manzano Chate is only in SVN we should port to 3.9 and add to git
Notes
(0004826)
ivan   
2013-05-16 13:22   
Thanks Paul
(0004838)
paulh   
2013-07-06 17:52   
Copied over some strings updated to reflect new names





View Issue Details
103 [SiT!] other feature N/A 2008-07-18 10:31 2013-07-06 17:27
ivan  
 
normal  
confirmed  
open  
none    
none  
  4.0  
Remove FIXME's
As of 18th July 08 there are over 140 FIXME's sprinkled throughout the codebase, this is far too many.

We should look at every single one and resolve the issue's highlighted.
Notes
(0000169)
ivan   
2008-11-06 22:32   
At 7 November there are 182 FIXME's in the codebase!
(0000391)
paulh   
2008-12-28 13:09   
At 28th Dec there are 153 FIXMEs (excluding dojo) made up as follows:

54 i18n
9 XHTML
3 Marked for 3.35
1 Marked for 3.40
(0001132)
paulh   
2009-05-27 21:53   
Down to 118 FIXMEs. Lets try and get under 100 for 3.5
(0003016)
paulh   
2010-04-11 12:22   
Still on 118

23 i18n
7 XHTML
2 Marked for 3.35
4 Marked for 3.4x
(0003924)
paulh   
2011-06-13 21:07   
74 fixmes as of today
(0004733)
ivan   
2013-03-02 16:31   
81 fixme's now, we're getting worse :-(
(0004742)
paulh   
2013-03-10 20:58   
72 FIXMEs as of today
(0004750)
paulh   
2013-03-12 20:33   
(edited on: 2013-03-12 20:35)
Down to 56, yay

(0004751)
paulh   
2013-03-13 20:59   
Down to 50
(0004753)
paulh   
2013-03-14 20:43   
down to 35 now,

8 in inbox
3 in billing
3 in triggers
(0004765)
paulh   
2013-04-01 20:27   
15 FIXMEs now

8 in inbox + 1 relating to inbox
3 in triggers
2 in soap
1 in templates
(0004769)
paulh   
2013-04-13 19:08   
Now on 12
(0004832)
paulh   
2013-07-06 14:50   
5 FIXMES

lib/triggers.inc.php: //FIXME 4.0 - add back displaying triggers as HTML - see function below
lib/triggers.inc.php: // FIXME 3.90, add edit back in - edit functionality needs to be written
lib/triggers.inc.php: * @todo FIXME 4.0 - displaying triggers as HTML
lib/soap_core.inc.php: // FIXME all this was copied from login.php this probably wants making into a function
soap.php: // Return an error -- FIXME better error wouldn't go amiss

2 in SOAP which isn't a released feature and 3 in triggers
(0004837)
ivan   
2013-07-06 17:27   
only 2 in SOAP left now

lib/soap_core.inc.php: // FIXME all this was copied from login.php this probably wants making into a function
soap.php: // Return an error -- FIXME better error wouldn't go amiss

Since SOAP is a experimental feature that's not enabled for 3.90 bumping this issue to 4.0





View Issue Details
1795 [SiT!] incidents minor always 2012-08-14 11:23 2013-07-06 17:25
rvmilaan Linux  
ivan Linux  
normal 2.6+later  
resolved 3.65 LTS  
fixed  
none    
none Current SVN  
  3.68  
Input was expected to be numeric but received string
Application Warning [512]
Input was expected to be numeric but received string [incidents] instead in base.inc.php @ line 274 trigger_error() clean_int() include()
login to www.vanmilaan.nl/helpdesk
user korstanje1
ww hpcoadmin
goto closed incidents
Notes
(0004508)
Tomse   
2012-08-15 18:41   
I've seen this on above mentioned URL,
though I cannot test it myself at this time.

Reporter/rvmilaan : runs 3.66 according to metadata
(0004511)
ivan   
2012-08-18 15:26   
I can confirm this. Thanks for the bug report.
(0004512)
ivan   
2012-08-18 15:37   
svn r7539





View Issue Details
1831 [SiT!] inbound email minor always 2013-01-13 13:33 2013-07-06 17:25
paulh  
paulh  
normal  
resolved Current SVN  
fixed  
none    
none Current SVN  
  3.68  
Missing seperator in To field if email sent to more than one email address
If an email has been received with more than one recipient in the to field and one of these only has an email address (and not a friendly name) the seperate between recipient is missing

e.g.

To: Paul Heaney <Paul.Heaney@EXAMPLE.co.uk>, XXXX.support@EXAMPLE.co.ukSupport <Support@EXAMPLE.co.uk>,

Should be,

To: Paul Heaney <Paul.Heaney@EXAMPLE.co.uk>, XXXX.support@EXAMPLE.co.uk, Support <Support@EXAMPLE.co.uk>,
Send an email to three people the middle recipient being just an email address and not from your address book
Notes
(0004651)
paulh   
2013-01-19 19:01   
r7558 and 24a2cfb resolve this, the comma wasn't being appended on to or cc addresses only containing an email address





View Issue Details
1371 [SiT!] inbound email minor always 2010-07-18 21:18 2013-07-06 17:24
sancho78rus Linux  
paulh Linux  
normal 2.6+later  
resolved 3.62 LTS  
fixed  
none    
none Current SVN  
  3.68  
Bad cirillic attachments names.
it shows like ???????????.txt
Notes
(0003339)
paulh   
2010-08-01 12:40   
Can reproduce with latest SVN
(0004653)
paulh   
2013-01-19 19:36   
r7559 and 21e93d4 resolve this, we where encoding file names twice





View Issue Details
1275 [SiT!] inbound email minor have not tried 2010-04-14 22:25 2013-07-06 17:24
ivan  
paulh  
normal  
resolved 3.60 LTS  
fixed  
none    
none Current SVN  
  3.68  
non-ascii characters in inbound email attachment filenames are corrupted
If a filename of an attachment to an inbound email uses non-ascii characters the file is corrupted. More often than not it seems you can still view and save the attachment but the filename is nonsense.

TBH I'm not sure how valid it is to have strange characters in attachment filenames but we ought to handle it better even if we end up naming the attachment untitled.odf or something like that.

I tried various filenames using the test string data at http://sitracker.org/wiki/Development/Test_Data [^]
Notes
(0003340)
paulh   
2010-08-01 12:50   
After reading http://tools.ietf.org/html/rfc2231 [^] and http://en.wikipedia.org/wiki/MIME [^] I'm still not 100% certain this is valid though as other clients (gmail, thunderbird) etc display this properly and their nothing to stop users sending emails with such attachments we should probably support this
(0004654)
paulh   
2013-01-19 19:36   
r7559 and 21e93d4 resolve this, we where encoding file names twice





View Issue Details
1343 [SiT!] inbound email major always 2010-06-14 21:01 2013-07-06 17:23
nicdev  
paulh  
normal  
resolved 3.61 LTS  
fixed  
none    
none Current SVN  
  3.68  
Update incidents when emails arrive regarding "awaitng closure" incidents
When an email arrives and the incident is awaiting closure we should update the incident and mark it active rather than put the email in the holding queue.

I'm pretty sure we did used to do that.

It could perhaps be made a config option. Not sure.
See the forum: http://sitracker.org/forum/viewtopic.php?f=10&t=1417109 [^]
Notes
(0003258)
paulh   
2010-06-19 12:27   
Updated the forum though suspect this could actually be a bug in the mail handler as most places do treat them as not the same (which is correct)
(0003811)
ivan   
2011-06-02 10:30   
I agree with Paul that this is a bug after looking more closely at it. Gonna change the description.
(0004656)
paulh   
2013-01-19 19:42   
still an issue in svn
(0004657)
paulh   
2013-01-20 12:38   
r7560 and e8363f6 resolve this





View Issue Details
1823 [SiT!] outbound email minor always 2012-12-06 21:30 2013-07-06 17:22
ringram74 Linux  
paulh Linux  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
  3.68  
First response email has slash in subject if incident was generated by incoming email with quote (') in subject
When an incident is generated from an incoming email and that email has a quote in the subject line, the first response email will contain the escape slash in the subject line. For instance, if you send an email to the support inbox for SiT with a subject of "Help needed with Russ's computer!", when the incident gets assigned to an engineer and an email is triggered, that outgoing email with have a subject of "[1] Help needed with Russ\'s computer!". The slash isn't there in the ticket title in the web interface, however.
Have SiT configured to check an email inbox.
Send email to the support inbox with a quote in the subject line
Assign the incident that was generated from your email to user
I'm running SiT v3.67p1 on CentOS 6.3 with PHP 5.3.3 with a MySQL 5.1.66 backend.
Notes
(0004608)
FlyingScotsman   
2012-12-06 23:40   
Shouldn't the category be inbound email?
(0004609)
ringram74   
2012-12-06 23:42   
No. The inbound email is handled correctly by adding the slash so it goes into the database properly. The outbound email should be removing the slash and is not.
(0004658)
paulh   
2013-01-20 12:54   
Can reproduce this, as ringram74 says this only affects the welcomeing email sent by the triggers, the web interface and subsequent emails are OK
(0004660)
ivan   
2013-02-03 11:52   
I think commit f8d33900 in Git fixes this. Need to check.
(0004662)
paulh   
2013-02-03 15:12   
I'll check with my test system when I can back to a machine which can route email
(0004670)
ivan   
2013-02-03 15:25   
Also committed in the 3.x branch svn 7564
(0004690)
paulh   
2013-02-04 19:36   
can confirm Ivans previous fixes resolves this issue





View Issue Details
1830 [SiT!] outbound email feature always 2013-01-11 19:03 2013-07-06 17:21
paulvh  
paulh  
low  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
  3.90beta1  
Incident Details send email to use and carbon copy incident
The link on an incident for the user's email opens up your email client and creates an email message addresses to that user. This adds in the information regarding the incident ID and incident title and carbon copies the inbound email address so this communication is logged in the incident.
--- ../sit-3.67/incident_details.php 2012-08-18 10:40:26.000000000 -0400
+++ /var/www/incident_details.php 2013-01-11 13:58:04.866787602 -0500
@@ -124,7 +124,7 @@ else
     $site .= list_tag_icons($incident->siteid, TAG_SITE); // site tag icons
     $site .= "
\n";
     echo sprintf($strContactofSite, $contact, $site)." ";
- echo "<a href=\"mailto:{$incident->email}\">{$incident->email}</a>
\n";
+ echo "<a href=\"mailto:{$incident->email}?subject=[{$incidentid}] {$incident->title}&cc=".$CONFIG['email_address']."\">{$incident->email}</a>
\n";
     echo "</div>\n";

     if ($incident->ccemail != '')
Notes
(0004663)
paulh   
2013-02-03 15:18   
Thanks alot of this this, I agree this would be useful and will look to merge this code into a imminent release (this will probably be the new 3.9x/4.x versio0
(0004691)
paulh   
2013-02-04 20:24   
Cheers Paul this is now merged into git as of 94170f2 (with a minor change as we support different incident formats in sit4, I've also added your name to the contributes





View Issue Details
1822 [SiT!] plugins crash always 2012-12-05 22:01 2013-07-06 17:19
ringram74 Linux  
paulh CentOS  
normal 6.3  
resolved 3.67 LTS  
open  
none    
none Current SVN  
  3.68  
Incident creation from inbound email fails when subject contains quote
I'm not entirely sure if this is a problem just with the auto_create_tags plugin or if it's a problem with the create_incident() function, but when an inbound email is processed, the incident creation fails if there is a quote (') in the subject line. The debug log shows the following error for an email with "Leaky faucet in 4th floor men's room" as the subject:

2012-12-05T12:49:04-08:00 auto.php Application Warning [512] MySQL Query Error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's room%'' at line 1 (in line 605 of file auto_create_tags.php)
2012-12-05T12:49:04-08:00 auto.php Warning [2] mysql_num_rows() expects parameter 1 to be resource, boolean given (in line 608 of file auto_create_tags.php)
2012-12-05T12:49:04-08:00 auto.php Auto_create_tags - Duplicate check = 1(1 = No duplicates 0 = Duplicates found
2012-12-05T12:49:04-08:00 auto.php Application Error [256] MySQL Query Error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's room', '0', '132', '1', 'standard', '1', '' at line 1 (in line 87 of file incident.inc.php)
Context: [CONTEXT-BEGIN]
Array
(
    [title] => Leaky faucet in 4th floor men's room
    [contact] => 132
    [servicelevel] => standard
    [contract] =>
    [product] =>
    [software] => 2
    [priority] => 1
    [owner] => 0
    [status] => 1
    [productversion] =>
    [productservicepacks] =>
    [opened] => 1354740542
    [lastupdated] => 1354740542
    [now] => 1354740542
    [dbIncidents] => incidents
    [dbUpdates] => updates
    [sit] =>
    [sql] => INSERT INTO `incidents` (title, owner, contact, priority, servicelevel, status, maintenanceid, product, softwareid, productversion, productservicepacks, opened, lastupdated) VALUES ('Leaky faucet in 4th floor men's room', '0', '132', '1', 'standard', '1', '', '', '2', '', '', '1354740542', '1354740542')
    [result] =>
)

[CONTEXT-END]
----------
Send email to support inbox with a quote in the subject line
cleanvar.patch (1,069) 2012-12-07 19:44
http://bugs.sitracker.org/file_download.php?file_id=213&type=bug
Notes
(0004597)
Tomse   
2012-12-06 08:37   
I cannot reproduce this on a system that doesn't have the mentioned plugins.

can you try and disable the plugin to see if that helps ?
(0004598)
ivan   
2012-12-06 11:18   
reclassifying this as Crash, assuming it can be confirmed.
(0004599)
ivan   
2012-12-06 11:19   
Oops, 'crash' not major.
(0004600)
ringram74   
2012-12-06 16:13   
Ok, after disabling the auto_create_tags plugin (sorry I didn't think to do that in the first place) incoming emails are turned into new incidents regardless of whether or not they have a quote in the subject line. Also, I dug around in the code a bit and I can almost fix this by adding a addslashes() around where the subject gets passed into the create_incident() function on line 300 of auto_create_tags.php. Unfortunately, if I do that, the subject of the response email that is sent to the customer ends up with a slash in it.
(0004601)
ringram74   
2012-12-06 17:42   
I just noticed that I get the slash in the subject line of the first response email after assigning it, anyway. Is that something that can be fixed or is it something that developers have decided is acceptable? Just curious.
(0004602)
FlyingScotsman   
2012-12-06 19:25   
This could be addressed by doing a stripslashes() call on any output that is retrieved by the script accessing the database.

Obviously adding slashes is a security feature, so it'll be stored in the database as men\'s. When being displayed a strip slashes would allow output of men's without compromising security.
(0004603)
Tomse   
2012-12-06 20:39   
Just to make clear
The plugin is a third-party developed plugin.
you can see the plugins that doesn't say "SiT Developers"
are third-party created plugins (including my own "Carsten Jensen")
http://sitracker.org/wiki/Plugins_Directory [^]

instead of addslashes() you should use mysql_real_escape_string() function
or the better SiT built-in function clean_var()

after using this, I don't think it's neccessary to use stripslashes().
(0004604)
ringram74   
2012-12-06 20:44   
Ok. Good to know.
The plugin page on the wiki indicates that problems with that plugin should be reported here. Is that not accurate?
(0004605)
Tomse   
2012-12-06 20:50   
bug reporting for that plugin here is fine, the developer has access to here, hence the notice. that wasn't my point though.
Lets stick to bug reporting here and move to the forum for discussions around plugins and off-topic subjects please.
(0004606)
FlyingScotsman   
2012-12-06 20:51   
I'm not sure what the difference is between 3.66 and 3.67p1 (I'm sure the main thing was a security fix to setup.php) but on 3.66 I just logged in as a contact and created an incident with title ' and description ' and the title is displayed correctly, the description however is not. The description is displayed as \' which means the slashes are not being pulled out like they are for the title.
(0004607)
Tomse   
2012-12-06 20:55   
@FlyingScotsman.

this is offtopic, please move to the forum or create a new bug report
(0004610)
ringram74   
2012-12-07 19:45   
I just uploaded a quick patch that will fix this issue. It just adds cleanvar(), as suggested by Tomse, around the $origsubject when it gets passed into the create_incident() function.
(0004665)
paulh   
2013-02-03 15:21   
Can reproduce this in the auto_create_tags plugin
(0004692)
paulh   
2013-02-04 20:33   
r7565 merges this patch, thanks for you assistence





View Issue Details
1761 [SiT!] menu trivial always 2012-01-19 18:51 2013-07-06 17:18
paulvh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta1  
Cosmetic Menu choices
Customers -> Sites -> Browse
change to
Customers -> Sites -> Browse Sites

Customers -> Contacts -> Browse
change to
Customers -> Contacts -> Browse Contacts


Customers -> Maintenance -> Browse
change to
Customers -> Maintenance -> Browse Contracts

Diff in Additional Information for lib/strings.inc.php
***************
*** 122,124 ****
  $hmenu[2010] = $hmenu[2010] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}sites.php"),
                         20=> array ( 'perm'=> 2, 'name'=> $strNewSite, 'url'=>"{$CONFIG['application_webpath']}site_add.php?action=showform")
--- 122,124 ----
  $hmenu[2010] = $hmenu[2010] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowseSites, 'url'=>"{$CONFIG['application_webpath']}sites.php?search_string=*&displayinactive=false"),
                         20=> array ( 'perm'=> 2, 'name'=> $strNewSite, 'url'=>"{$CONFIG['application_webpath']}site_add.php?action=showform")
***************
*** 128,130 ****
  $hmenu[2020] = $hmenu[2020] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}contacts.php?search_string=A"),
                         20=> array ( 'perm'=> 1, 'name'=> $strNewContact, 'url'=>"{$CONFIG['application_webpath']}contact_add.php?action=showform")
--- 128,130 ----
  $hmenu[2020] = $hmenu[2020] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowseContacts, 'url'=>"{$CONFIG['application_webpath']}contacts.php?search_string=*"),
                         20=> array ( 'perm'=> 1, 'name'=> $strNewContact, 'url'=>"{$CONFIG['application_webpath']}contact_add.php?action=showform")
***************
*** 134,136 ****
  $hmenu[2030] = $hmenu[2030] +
! array (10=> array ( 'perm'=> 19, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}contracts.php?search_string=A"),
                         20=> array ( 'perm'=> 39, 'name'=> $strNewContract, 'url'=>"{$CONFIG['application_webpath']}contract_add.php?action=showform"),
--- 134,136 ----
  $hmenu[2030] = $hmenu[2030] +
! array (10=> array ( 'perm'=> 19, 'name'=> $strBrowseContracts, 'url'=>"{$CONFIG['application_webpath']}contracts.php?search_string=*"),
                         20=> array ( 'perm'=> 39, 'name'=> $strNewContract, 'url'=>"{$CONFIG['application_webpath']}contract_add.php?action=showform"),
Notes
(0004413)
paulh   
2012-01-22 12:12   
Thanks Paulvh.

I agree as we have "New Contact" under the contact menu we should be consistent and have "Browse Contact" (or remove Contact from the new link)
(0004693)
paulh   
2013-02-04 20:44   
Thanks again paulvh this has been merged into the next major release in git commit 8d6baca





View Issue Details
1833 [SiT!] sites & contacts trivial always 2013-01-16 01:12 2013-07-06 17:17
greattaco Windows  
paulh Windows Server  
low 2000+Later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
  3.90beta1  
Site Types edit
When editing Site types, the button says 'edit' instead of save or update
Notes
(0004644)
Tomse   
2013-01-16 09:18   
I've seen this.
We should change this to Save or Update

Thanks for the report greattaco
(0004703)
paulh   
2013-02-10 16:43   
This is fixed in git b2c26c6 thanks for the report





View Issue Details
1048 [SiT!] authentication minor always 2010-01-20 20:42 2013-07-06 17:17
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta1  
remove authenticateSQL
authenticateSQL() isn't called so we should remove
Notes
(0002300)
ivan   
2010-01-20 21:52   
Yup, agreed
(0004704)
paulh   
2013-02-10 16:49   
b3362a4 removes





View Issue Details
1839 [SiT!] reports minor always 2013-02-22 15:16 2013-07-06 17:16
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta1  
statistics.php?mode=breakdown shows temporary owner when not set
When no temporary owner is set this above page shows the temporary owner as the system name, it should not be showing a name at all
Notes
(0004709)
ivan   
2013-02-22 16:22   
Saw over paulh's shoulder. confirmed.
(0004711)
paulh   
2013-02-22 20:01   
4f3ca01 fixes this as well as showing the priority on the page





View Issue Details
1844 [SiT!] theme feature N/A 2013-03-01 13:55 2013-07-06 17:16
yohann Linux  
paulh Linux  
low 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current GIT  
  3.90beta1  
add a little code in inc/htmlheader.inc.php so that every page have a unique body
add the page name to the body id

so theming of the login screen can be done like this:

body#index_page htlmelement { attribute }

si provided patch
fancytheme.patch (540) 2013-03-01 13:55
http://bugs.sitracker.org/file_download.php?file_id=220&type=bug
Notes
(0004720)
paulh   
2013-03-01 19:43   
Thanks yohann, that looks useful will merge
(0004721)
paulh   
2013-03-01 19:45   
Thanks Yohann, I've tweaked the patch slight as it included the full path if sit was installed i a sub directory which resolved in a / appearing which is invalid HTML, I've also applied this to the portal header and incident details header.

This has been merged in commit baa8722 to git and will be included in version 3.9





View Issue Details
1424 [SiT!] LDAP minor sometimes 2010-12-05 03:34 2013-07-06 17:15
johng  
paulh  
normal  
resolved 3.62 LTS  
fixed  
none    
none Current SVN  
  3.68  
LDAP service tries to disable a customer who is already disabled and fails
If a customer account in LDAP is disabled, SIT will try to repeatedly disable the account.
Notes
(0003498)
johng   
2010-12-05 03:35   
Solution:

# svn diff *
Index: auto.php
===================================================================
--- auto.php (revision 7)
+++ auto.php (working copy)
@@ -944,7 +944,9 @@
                                 if (strtolower($contact_attributes[$CONFIG['ldap_logindisabledattribute']][0]) == strtolower($CONFIG['ldap_logindisabledvalue']))
                                 {
                                     // We want to disable
- $sit_db_contacts[$contact_attributes[$CONFIG['ldap_userattribute']][0]]->disable();
+ if ($sit_db_contacts[$contact_attributes[$CONFIG['ldap_userattribute']][0]]) {
+ $sit_db_contacts[$contact_attributes[$CONFIG['ldap_userattribute']][0]]->disable();
+ }
                                 }
                             }
                         }
@@ -968,7 +970,7 @@
                 // TODO reassign incidents?
                 foreach ($sit_db_contacts AS $c)
                 {
- debug_log ("Disabling {$c->username}", TRUE);
+ debug_log ("Disabling {$c->username} because they don't exist in LDAP", TRUE);
                     $c->disable();
                 }
             }
Index: lib/classes.inc.php
===================================================================
--- lib/classes.inc.php (revision 7)
+++ lib/classes.inc.php (working copy)
@@ -491,19 +495,24 @@
         $toReturn = true;
         if (!empty($this->id))
         {
- $sql = "UPDATE `{$GLOBALS['dbContacts']}` SET active = 'false' WHERE id = {$this->id}";
-
- $result = mysql_query($sql);
- if (mysql_error()) trigger_error(mysql_error(),E_USER_WARNING);
- if (mysql_affected_rows() != 1)
- {
- trigger_error("Failed to disable contact {$this->username}", E_USER_WARNING);
- $toReturn = false;
- }
- else
- {
- $toReturn = true;
- }
+ $sql = "SELECT 1 FROM `{$GLOBALS['dbContacts']}` WHERE id = {$this->id} AND active = 'false'";
+ $result = mysql_query($sql);
+ if (mysql_error()) trigger_error(mysql_error(),E_USER_WARNING);
+ if (mysql_fetch_array($result,MYSQL_NUM)) {
+ debug_log("Failed to disable contact {$this->username}, was already disabled");
+ }
+ else
+ {
+ $sql = "UPDATE `{$GLOBALS['dbContacts']}` SET active = 'false' WHERE id = {$this->id}";
+
+ $result = mysql_query($sql);
+ if (mysql_error()) trigger_error(mysql_error(),E_USER_WARNING);
+ if (mysql_affected_rows() != 1)
+ {
+ trigger_error("Failed to disable contact {$this->username}", E_USER_WARNING);
+ $toReturn = false;
+ }
+ }
         }

         return $toReturn;
(0003563)
ivan   
2011-02-10 09:46   
Thanks johng
(0003564)
paulh   
2011-02-10 09:59   
Looks like I merged some of this patch in http://gitorious.org/sit/paulheaneys-sit/commit/b0c685f [^] (see linked bug)
(0003603)
paulh   
2011-02-14 21:33   
Confirm second issue about sync task becoming disabled
(0004726)
paulh   
2013-03-02 13:19   
current svn resolves this, see associated bugs





View Issue Details
1797 [SiT!] setup/config trivial always 2012-08-27 18:13 2013-07-06 17:15
Tomse BSD  
paulh FreeBSD  
low 6.4+Later  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
During fresh install trigger errors
Application Warning [512]
Table 'sit4.sit4_billingmatrix' doesn't exist in setup.inc.php @ line 594 trigger_error() setup_check_column_exists() require()

The SiT schema may need updating to fix this problem.

Warning [2]
mysql_fetch_row() expects parameter 1 to be resource, boolean given in setup.inc.php @ line 596 mysql_fetch_row() setup_check_column_exists() require()

Warning [2]
in_array() expects parameter 2 to be array, null given in setup.inc.php @ line 601 in_array() setup_check_column_exists() require()

Application Warning [512]
Table 'sit4.sit4_servicelevels' doesn't exist in setup.inc.php @ line 594 trigger_error() setup_check_column_exists() require()

The SiT schema may need updating to fix this problem.

Warning [2]
mysql_fetch_row() expects parameter 1 to be resource, boolean given in setup.inc.php @ line 596 mysql_fetch_row() setup_check_column_exists() require()

Warning [2]
in_array() expects parameter 2 to be array, null given in setup.inc.php @ line 601 in_array() setup_check_column_exists() require()
Just some minor things to correct
Notes
(0004535)
ivan   
2012-10-06 10:31   
Confirmed.
(0004727)
paulh   
2013-03-02 13:26   
During a fresh install of the latest git this error no longer appears
(0004729)
paulh   
2013-03-02 13:38   
Sorry this is still present, just not displayed to screen

2013-03-02T13:37:51+00:00 /sit4/setup.php Application Warning [512] Table 'sit4.billingmatrix' doesn't exist (in line 594 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
2013-03-02T13:37:51+00:00 /sit4/setup.php Warning [2] mysql_fetch_row() expects parameter 1 to be resource, boolean given (in line 596 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
2013-03-02T13:37:51+00:00 /sit4/setup.php Warning [2] in_array() expects parameter 2 to be array, null given (in line 601 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
2013-03-02T13:37:51+00:00 /sit4/setup.php Application Warning [512] Table 'sit4.servicelevels' doesn't exist (in line 594 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
2013-03-02T13:37:51+00:00 /sit4/setup.php Warning [2] mysql_fetch_row() expects parameter 1 to be resource, boolean given (in line 596 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
2013-03-02T13:37:51+00:00 /sit4/setup.php Warning [2] in_array() expects parameter 2 to be array, null given (in line 601 of file /home/paulh/git/paulheaneys-sit/lib/setup.inc.php)
(0004730)
paulh   
2013-03-02 14:20   
f70ce35 resolves this, we don't consider the upgrade options on a new install





View Issue Details
1629 [SiT!] permissions minor have not tried 2011-06-22 22:28 2013-07-06 17:14
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Site types page has skills permission
site_types.php requires the Add Skill (56) permission for some strange reason, I think we need to find an alternative or else create a new permission for this.
Notes
(0004075)
paulh   
2011-06-27 19:56   
Think I was being lazy at the time
(0004735)
paulh   
2013-03-04 20:20   
321df84 adds a dedicated permission





View Issue Details
1498 [SiT!] calendar major always 2011-04-25 20:14 2013-07-06 17:13
mpower Linux  
paulh Linux  
high 2.6+later  
resolved 3.63p1  
fixed  
none    
none Current SVN  
  3.68  
Calendar displays wrong months
When setting public holidays calendar starts with december but should be january. Todays date shows up as the month before. For example today is April 25, setting public holidays shows today at march 25. When hovering the mouse over a day, the month and day show correctly. Seems that the calendars should start with January and not December.
Click on set public holidays
Screen shot 2011-04-25 at 1.14.25 PM.png (95,664) 2011-04-25 20:14
http://bugs.sitracker.org/file_download.php?file_id=138&type=bug
Screen shot 2011-05-03 at 9.24.31 AM.png (138,069) 2011-05-03 16:55
http://bugs.sitracker.org/file_download.php?file_id=139&type=bug
Notes
(0003763)
mpower   
2011-04-25 20:17   
This bug seems to apply to all calendars when trying to book employee holidays the same issue also applys
(0003764)
Tomse   
2011-04-25 20:55   
can you turn on the debugger and go to the scheduler page, and paste a screenshot to the _forum_. I've tried to reproduce the error you describe, and I'm not successful.
(0003772)
ivan   
2011-05-03 16:01   
Confirming from the screenshot. I would guess that this has something to do with timezones.

@mpower: if you could provide the info that Tomse has requested that would be very helpful towards figuring out what causes this and ultimately fixing it.
(0003773)
mpower   
2011-05-03 16:57   
I am not sure what the _forum_ is but I uploaded the screenshot here.
Also, here is a dump from the log file incase you find anything useful here.

2011-05-03T09:23:49-06:00 /scheduler.php Warning [2] include(/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php): failed to open stream: No such file or directory (in line 170 of file /home/entelit/httpd/helpdesk/lib/base.inc.php)
2011-05-03T09:23:49-06:00 /scheduler.php Warning [2] include(): Failed opening '/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') (in line 170 of file /home/entelit/httpd/helpdesk/lib/base.inc.php)
2011-05-03T09:23:49-06:00 /scripts/sit.js.php Warning [2] include(/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php): failed to open stream: No such file or directory (in line 170 of file /home/entelit/httpd/helpdesk/lib/base.inc.php)
2011-05-03T09:23:49-06:00 /scripts/sit.js.php Warning [2] include(): Failed opening '/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') (in line 170 of file /home/entelit/httpd/helpdesk/lib/base.inc.php)
2011-05-03T09:24:01-06:00 /home/entelit/httpd/helpdesk/auto.php ERROR: Warning include(/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php): failed to open stream: No such file or directory in /home/entelit/httpd/helpdesk/lib/base.inc.php at line 170
2011-05-03T09:24:01-06:00 /home/entelit/httpd/helpdesk/auto.php ERROR: Warning include(): Failed opening '/home/entelit/httpd/helpdesk/i18n/English (CA).inc.php' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') in /home/entelit/httpd/helpdesk/lib/base.inc.php at line 170
2011-05-03T09:24:02-06:00 /home/entelit/httpd/helpdesk/auto.php ERROR: Application Error File specified in $CONFIG['default_i18n'] can't be found in /home/entelit/httpd/helpdesk/lib/functions.inc.php at line 7779
2011-05-03T09:24:02-06:00 /home/entelit/httpd/helpdesk/auto.php Scheduler actions due: CloseIncidents, SetUserStatus, TimeCalc, CheckIncomingMail
2011-05-03T09:24:02-06:00 /home/entelit/httpd/helpdesk/auto.php ERROR: Application Error File specified in $CONFIG['default_i18n'] can't be found in /home/entelit/httpd/helpdesk/inboundemail.php at line 65
(0003774)
Tomse   
2011-05-03 17:17   
hello mpower.
the forum is http://sitracker.org/forum [^]
it's alittle easier to communicate (better mail notifications etc) there hence my question to do so :-)
(0004738)
paulh   
2013-03-10 19:08   
Thanks for this report, this is now fixed in SVN r7571 and git e4b751e and will be in the next release





View Issue Details
1845 [SiT!] calendar minor always 2013-03-08 18:50 2013-07-06 17:13
patogerman Linux  
paulh Linux  
normal 2.6+later  
resolved 3.67 LTS  
fixed  
none    
none Current SVN  
  3.68  
Fail to Show February
When show calendar to define availability days system show February month with 31 days.
bug calendar.png (41,596) 2013-03-08 18:50
http://bugs.sitracker.org/file_download.php?file_id=221&type=bug
Notes
(0004736)
paulh   
2013-03-09 12:38   
Thanks for the report, we have another report of similar issues (1498) I'd not been able to reproduce this issue with my install yet though we will continue investigations, the most likely cause is going to be due to a timezone issue.

Cheers
Paul
(0004737)
paulh   
2013-03-09 12:40   
Looking at the screenshots again I've just realised this and the linked bug start with December and run through to November with 'January' only having 28 days so it looks like its the headers which are out by a day as according to the screenshot 8/Feb/2013 is the current date when it fact the current date was in March
(0004739)
paulh   
2013-03-10 19:09   
Thanks for this report, this is now fixed in SVN r7571 and git e4b751e and will be in the next release





View Issue Details
1711 [SiT!] incidents crash have not tried 2011-09-04 17:02 2013-07-06 17:12
ivan  
paulh  
normal  
resolved 3.64 LTS  
fixed  
none    
none Current SVN  
  3.68  
Reopening an incident via an email with attachment orphans the attachment
When reopening an incident via an email that has an attachment, the attachment cannot be viewed, a 404 error occurs from download.php
This appears to be because the attachment is original placed in /updates/#number# and not moved by the reopen process.
Notes
(0004641)
paulh   
2013-01-06 15:47   
I can reproduce this with the latest code
(0004757)
paulh   
2013-03-15 19:45   
r7573 and da64bce resolve this





View Issue Details
1853 [SiT!] feedback minor always 2013-03-15 20:23 2013-07-06 17:12
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
feedback forms sent out when no feedback form exists
If you don't have any feedback forms set SiT still generates records in the feedbackrespondents table and sends links to customers requesting feedback though when they try and complete it they are told the form does not exist
Notes
(0004758)
paulh   
2013-03-15 20:35   
f6d6e4f resolves, we now check for the presence of the form





View Issue Details
1577 [SiT!] holidays tweak have not tried 2011-06-14 15:20 2013-07-06 17:11
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
holiday request redirect broken
holiday_request.php calls html_redirect.php after the html header was included.
Notes
(0003944)
paulh   
2011-06-14 19:06   
confirm
(0004759)
paulh   
2013-03-30 14:18   
c367994 resolves





View Issue Details
1242 [SiT!] sites & contacts minor always 2010-04-08 11:30 2013-07-06 17:11
sancho78rus Linux  
paulh Linux  
normal 2.6+later  
resolved 3.60 LTS  
fixed  
none    
none Current SVN  
  3.68  
Admin contact can set site's type
Login to portal as Admin contact. Go to Admin. Then press Open contract (in contract list). Then click on site name (you'll open site details). And there you can change site type.
Notes
(0002973)
ivan   
2010-04-08 15:47   
Thanks
(0004763)
paulh   
2013-04-01 20:05   
r7575 and 97092bf don't allow admins to change the type in the portal, thanks for thsi report





View Issue Details
1570 [SiT!] sites & contacts minor have not tried 2011-06-14 09:38 2013-07-06 17:10
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
map link shouldn't appear if nothing to map
The map link still displays if there is no site address, this shouldn't happen.
Notes
(0003955)
paulh   
2011-06-14 19:28   
The map link doesn't show for me if theres nothing to map (no address1 etc)
(0003963)
Tomse   
2011-06-14 19:51   
I can confirm what Paul says, when there are no address (all fields empty), there is no link to map.
(0004764)
paulh   
2013-04-01 20:21   
02dc9cf adds a new config variable to control how many lines of an address are required before a map link is shown





View Issue Details
1674 [SiT!] billing minor have not tried 2011-08-06 16:49 2013-07-06 17:09
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Per incident billing charges per unit
Even when a contract is set to use per incident billing the Activities menu on an incident shows to record time (and units) spent and recording activity causes the contract to be billed per-unit.
With a contract that has only one service record and that service is set to "per incident" I created an incident.

I then went to activities and started/edited and stopped an activity.

I then closed the incident and went to approve the billing.
sit3.90-billing7.png (30,739) 2011-08-06 16:49
http://bugs.sitracker.org/file_download.php?file_id=181&type=bug
Notes
(0004168)
ivan   
2011-08-06 16:53   
Also if I repeat the experiment but don't add any activity at all before closing the incident it doesn't show for billing approval at all.
(0004761)
paulh   
2013-04-01 15:47   
Looks like we never wrote the code for per incident, I've stared to refactor the code to make it possible
(0004771)
paulh   
2013-04-21 19:22   
342a0ec adds this functionality





View Issue Details
1854 [SiT!] billing major always 2013-03-30 19:33 2013-07-06 17:09
paulh  
paulh  
normal  
resolved 3.65 LTS  
fixed  
none    
none Current GIT  
  3.90beta1  
Per incident billing does not work
Sit supports per unit and per incident billing though the system only uses per unit even if a service is set as per incident it actually performs per unit
Notes
(0004760)
paulh   
2013-04-01 15:46   
Recent commits have refactored the code base so implementing this should now be possible
(0004772)
paulh   
2013-04-21 19:23   
342a0ec adds this functionality





View Issue Details
1677 [SiT!] billing minor have not tried 2011-08-08 15:11 2013-07-06 17:08
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Contract page inconsistant when SLA changed from non-timed to timed
If a contract is created with an SLA that is not timed at all and then later the SLA is changed to Timed, the contract page and the edit balance/edit service pages show unexpected results.

One would expect that the service that was originally created does not have billing. If that is the case it should not be possible to edit the balance, or if it is possible it should also be possible to edit billing parameters on the service.
* Create a new contract against an SLA that is not timed
* Change the SLA to be timed for at least one priority
* View the contract page and see the balance for the service is 0.00
* Click 'Edit Service'
* see that it is not possible to edit the service with relation to billing
* return to the contract page
* Click 'Edit Balance'
* Add 100.00 to the balance
* return to the contract page
* see the balance for the service is now 100.00
* Click 'Edit Service'
* see that it is not possible to edit the service with relation to billing
Also, if a subsequent service record is created, there is no option given for billing parameters. I presume this is related.
Notes
(0004190)
ivan   
2011-08-08 15:12   
Perhaps it should not be possible to change an SLA timed/non-timed once it's being used?
(0004773)
paulh   
2013-04-21 19:31   
034e941 prevents you from changing a contract from timed to non timed (or vica versa) as I agree this is a bad idea and will lead to a confusion etc





View Issue Details
1871 [SiT!] menu minor N/A 2013-04-23 21:38 2013-07-06 17:07
paulh  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta1  
remove edit contract from menu
We don't have direct links for any other edit page so we should remove the edit contract link from contracts menu for consistency and to simply the menu
Notes
(0004775)
paulh   
2013-04-24 08:48   
ea1223c removes this





View Issue Details
1872 [SiT!] other minor always 2013-04-23 21:40 2013-07-06 17:07
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Edit site type box too small
The edit box here is too small for some site types see screenshot, we should make this larger
edit_sitetype.png (5,855) 2013-04-23 21:40
http://bugs.sitracker.org/file_download.php?file_id=226&type=bug
Notes
(0004777)
paulh   
2013-04-24 15:27   
46e27a8 increases the box to 30 characters





View Issue Details
1868 [SiT!] incidents minor always 2013-04-23 21:27 2013-07-06 17:06
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
No title on incident hover on statistics.php
On statistics.php you used to be able to cover over the incidentID links and it gave the incident titles which was useful to get a quick overview of what was going on and to aid identification of the correct incident. In 3.9 this seems to have been removed
Notes
(0004780)
paulh   
2013-04-24 16:07   
2054084 adds this





View Issue Details
1867 [SiT!] incidents minor always 2013-04-23 21:23 2013-07-06 17:06
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Contract dropdown on incident_edit.php
Previously we never permitted changing contract as it messed up SLAs in 3.9 we seem to have a drop down box for contract on incident_edit.php.

On my upgraded system this shows a single record with "No Records" see screenshot
contracts.png (2,167) 2013-04-23 21:23
http://bugs.sitracker.org/file_download.php?file_id=225&type=bug
Notes
(0004778)
paulh   
2013-04-24 15:29   
http://gitorious.org/~paulheaney/sit/paulheaneys-sit/commit/034139d7 [^]

was added to allow changes to contracts with the same SLA, we should display a better error message here
(0004789)
paulh   
2013-04-24 20:18   
4b0aa5a adds an explanation of this field as it confused me for a while until I read previous commits





View Issue Details
1676 [SiT!] billing major have not tried 2011-08-08 11:56 2013-07-06 17:03
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
Activity page "Duration" column is wrong/misleading
When using Activities to record time spent for billing purposes the Activity summary page on an incident shows a column for "Duration" which doesn't show the different between start and completed times as one would expect but actually shows the amount of time that is to be billed based on the customer unit setting in the SLA.
Unfortunately because this is calculated per-row the value shown in the duration column can be incorrect, for example two activities marked complete after one minute should show a total billable time of 1 unit, instead each row shows a duration equal to one unit making a total of 2 units. This disagrees with the Activity Billing section shown below.

See screenshot.
1) Start an activity and mark it complete more or less immediately.
2) Start another activity and mark it complete ore or less immediately.
3) Look at the activities page.
billing-11.png (41,063) 2011-08-08 11:56
http://bugs.sitracker.org/file_download.php?file_id=187&type=bug
Notes
(0004188)
ivan   
2011-08-08 11:57   
I would expect the top column to show Duration as "1 Minute" for both activities, since the top section is showing a summary of the activities as they happened and the bottom section is the one that should be showing how that is billed.
(0004218)
paulh   
2011-08-13 19:29   
Agree, this is weird, believe this was something Kieran implemented and there was (what seemed liked a good) reason at the time for showing it this way but have no idea what it is now
(0004817)
paulh   
2013-05-04 18:23   
9184bd4 resolves this by showing minutes





View Issue Details
1865 [SiT!] incidents minor always 2013-04-23 21:18 2013-07-06 17:03
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
When creating and assigning an incident and the user is not accepting the interface looks ugly
incident_new.php?action=assign when a user is not accepting the no looks ugly see attached screenshot

This is class=error using the default theme


Is error really right here?
ugly.png (2,069) 2013-04-23 21:18
http://bugs.sitracker.org/file_download.php?file_id=224&type=bug
Notes
(0004785)
ivan   
2013-04-24 19:52   
Should not be using class "error" that was lazy. Probably me years ago, sorry.
(0004818)
paulh   
2013-05-04 18:29   
00f485a7cc649c360add13a06d32f6c83d353c56 changes the class to notaccepting - this doesn't yet exist though looks OK in black





View Issue Details
1579 [SiT!] incidents tweak have not tried 2011-06-14 15:38 2013-07-06 17:02
ivan  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
incident update redirect broken
incident_update.php calls html_redirect after the html header was included.
Notes
(0003946)
paulh   
2011-06-14 19:10   
Which line? Just checked this file and can't see a code path where html_redirect is called after including a header?
(0003960)
ivan   
2011-06-14 19:43   
after looking again I don't think it is, but include (APPLICATION_INCPATH . 'incident_html_bottom.inc.php'); is called after the html_redirect() so the includes for header and footer are wrong somewhere.
(0003962)
paulh   
2011-06-14 19:45   
Agree, also the error on line 601 doesn't use html_redirect
(0004821)
paulh   
2013-05-05 13:14   
current git resolves this





View Issue Details
1386 [SiT!] billing trivial always 2010-08-22 12:33 2013-07-06 16:45
Tomse  
 
low  
resolved Current SVN  
fixed  
none    
none Current GIT  
  3.90beta1  
Activities within the same time frame adds up in total.
if you have a 2 hour billing, and you start an activity the customer will be billed for the 2 hours, but if you close the activity after 15 minutes (0:15), start one after 1 hour of the initial start (1:00) and close it again after 15 minutes (1:15).

this shows a total of 4 hours.

when the incident is closed 1 unit is billed though.


sit-billable.png (47,260) 2010-12-04 17:17
http://bugs.sitracker.org/file_download.php?file_id=131&type=bug
Notes
(0003446)
paulh   
2010-10-16 12:57   
Hi Tomse,

where is this showing as 4 hours?
(0003447)
Tomse   
2010-10-16 21:34   
I believe it's in billable_incidents.php

(Run a summary report to screen)

My database is pretty blank right now, so I don't have those test data anymore, but I might redo them tomorrow
(0003495)
Tomse   
2010-12-04 17:21   
added an example.

repro:
the SLA used for this example is the default time values when creating a new SLA.

add activity, add a note, close activity
do that a couple of times

you can view the time by opening the incident (incident details) and clicking on activities.
(0003590)
paulh   
2011-02-12 18:34   
can repro
(0004822)
paulh   
2013-05-05 14:24   
Latest got resolves this by showing the minutes rather than billing periods





View Issue Details
750 [SiT!] billing minor have not tried 2009-06-27 11:59 2013-07-06 16:44
kieran  
paulh  
normal  
resolved  
fixed  
none    
none Current GIT  
  3.90beta1  
Confusing billing terminology
When setting up a new contract, there's the following:

Amount
Incident Rate Required
Free of Charge Above must be completed to allow deductions

It's not completely clear why the Amount differs from the incident rate, or why it's not required. Additionally, the free of charge thing is confusing, what must be completed and why?
Notes
(0001296)
ivan   
2009-07-11 15:49   
I agree this is confusing, I tried to look at this but I can't understand it either. :-/
(0001299)
paulh   
2009-07-12 14:54   
These only appear on contracts with a service level which is marked as timed.

Amount means the amount of money which you are crediting to the contract (i.e. the amount of money on the initial service of that contract)

Unit Rate/Incident rate is the amount that is charged per unit or incident

Free of Charge is whether the customer has paid for this or you are giving it to them for free (so these can be included/excluded from reports).

Even though you might mark it as free of charge you still need to put in an amount and a unit/incident rate as otherwise the service is never used up.

Hope this make sense
(0004824)
paulh   
2013-05-05 17:44   
8b61be4 adds help options for these items





View Issue Details
1870 [SiT!] calendar minor always 2013-04-23 21:34 2013-07-06 16:44
paulh  
paulh  
normal  
resolved Current GIT  
fixed  
none    
none Current GIT  
  3.90beta1  
error on calendary
The following is reported:

 script '<path>/calendar/planner.css.php' not found or unable to stat, referer: http://IP/webtrack/calendar.php?display=month [^]


When accessing calendar.php?display=month
Notes
(0004774)
paulh   
2013-04-23 21:34   
This was a 3.65->3.9 upgrade
(0004781)
paulh   
2013-04-24 16:10   
05c54f6 removes this include, we where not using it anyway and the file had been previously removed





View Issue Details
1693 [SiT!] tasks minor always 2011-08-19 18:10 2013-07-06 16:39
jcaldwell Windows  
Windows  
normal XP+Later  
new 3.64 LTS  
open  
none    
none  
   
Start / End date does not show up
When I am trying to show all my completed tasks from the drop down box it does not tell me on the list what date the task was completed or started.

tasks.php?user=1&show=completed&sort=&order=

It would be nice if this information filled in automatically.

just goto tasks.php?user=1&show=completed&sort=&order=
If anyone could also tell me where I can change the settings for tasks that would be great too.
dates.png (20,994) 2011-08-19 18:19
http://bugs.sitracker.org/file_download.php?file_id=196&type=bug
taskdates.png (27,477) 2011-08-22 18:57
http://bugs.sitracker.org/file_download.php?file_id=197&type=bug
Notes
(0004235)
paulh   
2011-08-19 19:52   
Am I correct in saying that you haven't defined start and end dates on the task? If so this is 'by design' though I agree perhaps end date should be set to the date the task is completed, what do others think?
(0004241)
jcaldwell   
2011-08-19 20:42   
(edited on: 2011-08-19 20:44)
That is right, I have not defined start and end points. This is because the way I am using this system is to track small tasks like deploying a system which will take a day or two. I just want a simple way to see how long a task took.

In my opinion, if you don't set a start date you should have it start on the date that you posted it, if you don't set a due date it is not an issue and the end date should be the date it was closed.

(0004242)
ivan   
2011-08-20 11:55   
I don't agree that tasks should start on the day that you post them. I think it's quite valid to have tasks for which you haven't decided a start date yet.

I think the solution to your problem is to set the start date when you add the task.

The end-date is already set when tasks are marked completed.
(0004252)
jcaldwell   
2011-08-22 16:09   
Start date isnt an issue, the end date is.

It does not show the date on the screen as I posted.
(0004253)
ivan   
2011-08-22 18:56   
I can't reproduce that, setting a task as complete always set