SiT! Bugs - SiT!
View Issue Details
0001007SiT!incidentspublic2009-11-10 13:182010-01-23 19:02
paulh 
paulh 
normalminoralways
closedfixed 
 
3.513.51 
0001007: able to change the priority of an incident to one not defined at that SLA
Possible to set a call to critical when the SLA doesn't support it

results in the following error on the incidents page

could not retrieve service level (SELECT * FROM `servicelevels` WHERE tag='SLA3000' AND priority='4' ) in /var/webtrack/inc/incidents_table.inc.php @ line 112 trigger_error() include()
No tags attached.
Issue History
2009-11-10 13:18paulhNew Issue
2009-11-14 14:23paulhNote Added: 0002149
2009-11-14 14:23paulhAssigned To => paulh
2009-11-14 14:23paulhStatusnew => assigned
2009-11-14 14:23paulhFixed in Version => 3.50p1
2009-11-14 19:27paulhNote Added: 0002150
2009-11-19 21:18ivanNote Added: 0002151
2009-12-23 17:00paulhNote Added: 0002230
2009-12-23 17:00paulhStatusassigned => resolved
2009-12-23 17:00paulhResolutionopen => fixed
2009-12-23 17:00paulhFixed in Version3.50p1 => Current SVN
2009-12-23 17:00paulhTarget Version => 3.50p1
2010-01-23 19:01ivanFixed in VersionCurrent SVN => 3.51
2010-01-23 19:02ivanNote Added: 0002312
2010-01-23 19:02ivanStatusresolved => closed

Notes
(0002149)
paulh   
2009-11-14 14:23   
This problem is due to lines 382-386 of incident_update.php

// // FIXME fix maximum priority
// $servicelevel=maintenance_servicelevel(incident_maintid($id));
// if ($servicelevel == 2 || $servicelevel == 5) $maxpriority = 4;
// else $maxpriority = 3;
    $maxpriority = 4;

Will look at fixing this weekend
(0002150)
paulh   
2009-11-14 19:27   
paulh@uist:~/git/sitracker$ git commit
[master 676df12] * Fix for being able to assign a priority to an incident whos SLA doesn't support it (Mantis 0001007)
 3 files changed, 48 insertions(+), 14 deletions(-)


need to push and move to sitracker3
(0002151)
ivan   
2009-11-19 21:18   
Think this one was my fault, sorry. Off the top of my head I think the function got deprecated and I intended to clean this up later, but clearly forgot.
(0002230)
paulh   
2009-12-23 17:00   
r5968 adds this patch to svn (3.x and trunk)
(0002312)
ivan   
2010-01-23 19:02   
Fix released in v3.51 which is now available