SiT! Bugs - SiT!
View Issue Details
0001061SiT!otherpublic2010-02-10 11:302015-05-04 11:58
ivan 
 
normalminorhave not tried
confirmedopen 
 
 
0001061: Dependency issues in .deb package
We depend on prototype.js and scriptaculous.js and we should set up package dependencies properly rather than bundle these within the .deb file. Bundling is bad because security fixes won't percolate.
No tags attached.
parent of 0001112resolved ivan Move timesheet feature to Project Plugin 
Issue History
2010-02-10 11:30ivanNew Issue
2010-02-10 13:23paulhNote Added: 0002344
2010-02-10 13:23paulhAssigned To => paulh
2010-02-10 13:23paulhStatusnew => confirmed
2010-02-11 20:35paulhNote Added: 0002351
2010-02-11 20:35paulhStatusconfirmed => assigned
2010-02-16 19:40paulhNote Added: 0002378
2010-03-01 14:06ivanRelationship addedparent of 0001112
2010-03-17 14:08ivanAssigned Topaulh => ivan
2010-03-17 14:08ivanNote Added: 0002720
2010-04-12 21:12ivanNote Added: 0003042
2010-04-12 21:15ivanAssigned Toivan => paulh
2015-05-04 11:58paulhAssigned Topaulh =>
2015-05-04 11:58paulhStatusassigned => confirmed

Notes
(0002344)
paulh   
2010-02-10 13:23   
I'll take a look at this
(0002351)
paulh   
2010-02-11 20:35   
From some googling and looking at what libjs-prototype installs the way to do this on Debian is to include the javascript from /javascript/

e.g.

<script language="javascript" type="text/javascript"
src="/javascript/prototype/prototype.js"></script>

rather than symlinking or anything like that, this /javascript/ is done via conf.d/javascript-common.conf this means on building the deb all instances of

{$CONFIG['application_webpath']}scripts/prototype/prototype.js

need changing to /javascript/prototype/prototype.js which isn't a biggie

(0002378)
paulh   
2010-02-16 19:40   
Replacing prototype is straight forward as we just replace {$CONFIG['application_webpath']}scripts/prototype/prototype.js unfortunately scriptaculous isn't as easy as we don't directly include this but instead use $pagescripts and htmlheader.inc.php

if (is_array($pagescripts))
{
    foreach ($pagescripts AS $pscript)
    {
        echo "<script src='{$CONFIG['application_webpath']}scripts/{$pscript}' type='text/javascript'></script>\n";
    }
    unset($pagescripts, $pscript);
}

So we can't just sed this one,
(0002720)
ivan   
2010-03-17 14:08   
I've assigned this to me so that I'll remember to change the way pagescripts works, I'll bat it back to you (paulh) once thats done
(0003042)
ivan   
2010-04-12 21:12   
In Git 623ebb0 scriptaculous is always included instead of using pagescripts. This should make dependency issues a bit easier?