SiT! Bugs - SiT!
View Issue Details
0001182SiT!feedbackpublic2010-03-23 10:592010-03-27 12:30
nicdev 
paulh 
normalminoralways
closedfixed 
3.51 
3.60 LTS3.60 LTS 
0001182: Contact can access the feedback form multiple times
Once completed, a contact can click on the link he received again and the feedback form can be submitted infinitely.
No tags attached.
Issue History
2010-03-23 10:59nicdevNew Issue
2010-03-23 14:14ivanNote Added: 0002838
2010-03-23 14:14ivanTarget Version => 3.60 LTS
2010-03-23 14:37nicdevNote Added: 0002841
2010-03-24 20:18paulhNote Added: 0002854
2010-03-24 20:18paulhStatusnew => confirmed
2010-03-24 21:18paulhStatusconfirmed => assigned
2010-03-24 21:18paulhAssigned To => paulh
2010-03-24 21:23paulhNote Added: 0002857
2010-03-24 21:23paulhResolutionopen => fixed
2010-03-24 21:23paulhFixed in Version => Current SVN
2010-03-24 21:25paulhStatusassigned => resolved
2010-03-27 11:16ivanFixed in VersionCurrent SVN => 3.60 LTS
2010-03-27 12:30ivanStatusresolved => closed

Notes
(0002838)
ivan   
2010-03-23 14:14   
Haven't had chance to confirm this yet, but if it confirmes OK then it needs fixing for 3.60 if we can.
(0002841)
nicdev   
2010-03-23 14:37   
Ivan,

As we discussed in line 386 of feedback.php we need to change the code to:

if (!$_REQUEST['rr'])
{
   $rsql .= "AND completed='no' ";
}

because the contact always arrives from the link with $_REQUEST['rr'] not set, and thus will always see the form. Also we need to change the 'yes' to 'no', to only show the form when it has not been completed.
(0002854)
paulh   
2010-03-24 20:18   
can repro
(0002857)
paulh   
2010-03-24 21:23   
r6336 and bcde971 resolve this