SiT! Bugs - SiT!
View Issue Details
0000144SiT!inbound emailpublic2008-08-12 17:372008-11-21 17:27
user13 
ivan 
normalminoralways
closedfixed 
3.33 
3.403.40 
0000144: js function confirm_delete() in review_incoming_updates.php has unbalanced quotes
On the review_incoming_updates.php page, the checkboxes do not work due to unbalanced quotes in the confirm_delete() function.

The version in the code is this:

        function confirm_delete()
        {
            return window.confirm('<?php echo $strAreYouSureDelete; ?>");
        }

(note window.confirm call starts with apostrophe and ends with doublequotes)

it should be this:

        function confirm_delete()
        {
            return window.confirm("<?php echo $strAreYouSureDelete; ?>");
        }


No tags attached.
Issue History
2008-08-12 17:37user13New Issue
2008-08-12 17:59kieranNote Added: 0000059
2008-08-13 14:02ivanNote Added: 0000060
2008-08-13 14:02ivanStatusnew => resolved
2008-08-13 14:02ivanResolutionopen => fixed
2008-08-13 14:02ivanAssigned To => ivan
2008-08-13 14:02ivanFixed in Version => 3.40
2008-08-13 14:02ivanTarget Version => 3.40
2008-08-13 14:02ivanDescription Updated
2008-11-21 17:27kieranStatusresolved => closed

Notes
(0000059)
kieran   
2008-08-12 17:59   
Which version is this in? Looks to be fixed in svn and probably 3.36.
(0000060)
ivan   
2008-08-13 14:02   
We should not have been using confirm_delete() in any case since this function was obsoleted and replaced by confirm_action(). I've fixed that in svn trunk r3900 and tested, this problem no longer exists.

Thanks for the bug report.