SiT! Bugs - SiT!
View Issue Details
0001599SiT!otherpublic2011-06-15 12:022013-05-04 13:20
Tomse 
paulh 
normalminoralways
resolvedfixed 
Current GIT 
3.90beta1Current GIT 
0001599: statistics page shows wrong feedback stats
it counts 4, but there are only 3
No tags attached.
related to 0001561resolved Tomse Calculation error on feedback report 
related to 0001024assigned Tomse feedback reports only show questions of type rating 
child of 0001458resolved Tomse [META] Working feedback system 
png statistics.png (23,254) 2011-06-15 12:02
http://bugs.sitracker.org/file_download.php?file_id=159&type=bug
png
Issue History
2011-06-15 12:02TomseNew Issue
2011-06-15 12:02TomseFile Added: statistics.png
2011-06-15 12:04TomseRelationship addedchild of 0001458
2011-06-15 12:04TomseRelationship addedrelated to 0001561
2011-06-15 12:05TomseRelationship addedrelated to 0001024
2011-06-15 19:24paulhNote Added: 0004009
2011-06-15 19:24paulhStatusnew => feedback
2011-06-15 19:36TomseNote Added: 0004012
2011-06-15 19:36TomseStatusfeedback => new
2011-06-15 19:36TomseAssigned To => Tomse
2011-06-16 14:28TomseNote Edited: 0004012bug_revision_view_page.php?bugnote_id=4012#r223
2011-08-21 11:34ivanNote Added: 0004249
2011-08-21 11:34ivanStatusnew => confirmed
2011-08-21 11:34ivanTarget Version => 3.90beta1
2013-05-02 10:56TomseNote Added: 0004792
2013-05-04 13:20paulhNote Added: 0004809
2013-05-04 13:20paulhAssigned ToTomse => paulh
2013-05-04 13:20paulhStatusconfirmed => resolved
2013-05-04 13:20paulhResolutionopen => fixed
2013-05-04 13:20paulhFixed in Version => Current GIT

Notes
(0004009)
paulh   
2011-06-15 19:24   
The X results is the number of completed feedback forms not the number of questions or are you saying only 3 forms have been filled in?
(0004012)
Tomse   
2011-06-15 19:36   
(edited on: 2011-06-16 14:28)
From the look of it (also from the code) the code says there are 4 rating fields, but there are only 3.
if it counts the amount of feedback forms submitted, it's way off, as I have perhaps 10

the math is also wrong as a rating of 0 is not 0, but unanswered, therefore
0+0+9 shouldn't be divided by 3, but by 1, this is not shown here in the example though.
I've fixed this bug recently, and this one should have a relationship to it. 0001561

(0004249)
ivan   
2011-08-21 11:34   
I can see stats for 2 but it should actually show stats for 3 (or 5 if it were to count forms for the same incident separately).

I also noticed the stats are hard coded to display for form 1 only.
(0004792)
Tomse   
2013-05-02 10:56   
This is an update as pr ericthefish request:

I haven't tested this recently.

the issue here is that there are 3 questions, but the bottom line calculates as there are 4 questions
(0004809)
paulh   
2013-05-04 13:20   
This was an issue with wording and 03874dd corrects the wording