SiT! Bugs - SiT!
View Issue Details
0001748SiT!incidentspublic2011-12-15 13:402011-12-19 14:51
nicdev 
nicdev 
normalminoralways
resolvedfixed 
Current GIT 
3.90beta1Current GIT 
0001748: Duplicate SLA icon in incident update div
The Incident update icon is duplicated in the Incident update header (see image)
No tags attached.
png Image 005 2011 12 15.png (13,031) 2011-12-15 13:40
http://bugs.sitracker.org/file_download.php?file_id=201&type=bug
png

png Image 006 2011 12 15.png (9,774) 2011-12-15 14:00
http://bugs.sitracker.org/file_download.php?file_id=202&type=bug
png
Issue History
2011-12-15 13:40nicdevNew Issue
2011-12-15 13:40nicdevFile Added: Image 005 2011 12 15.png
2011-12-15 13:41nicdevProduct Version => Current GIT
2011-12-15 14:00nicdevFile Added: Image 006 2011 12 15.png
2011-12-15 14:01nicdevNote Added: 0004366
2011-12-15 14:19nicdevNote Added: 0004367
2011-12-15 14:19nicdevNote Edited: 0004367bug_revision_view_page.php?bugnote_id=4367#r261
2011-12-19 14:51ivanNote Added: 0004370
2011-12-19 14:51ivanStatusnew => resolved
2011-12-19 14:51ivanFixed in Version => Current GIT
2011-12-19 14:51ivanResolutionopen => fixed
2011-12-19 14:51ivanAssigned To => nicdev
2011-12-19 14:51ivanTarget Version => 3.90beta1

Notes
(0004366)
nicdev   
2011-12-15 14:01   
I think the problem is this bit of duplicated code in "incident_details.php" (see econd attached image):

echo icon($updatetypes[$update->type]['icon'], 16, $showhide);
(0004367)
nicdev   
2011-12-15 14:19   
Sorry guys, no-one to confirm but i accidentally comitted the fix to GiT: f6bd59d4
https://gitorious.org/sit/sit/commit/f6bd59d4689f383023a4988fb704b3535cdc1ef8 [^]

i can undo it if required

(0004370)
ivan   
2011-12-19 14:51   
Don't apologise for fixing stuff! :-) Thanks!

I think this one is pretty obviously a bug from the screenshots you provided without me even having to try it. Thanks again.