SiT! Bugs - SiT!
View Issue Details
0001761SiT!menupublic2012-01-19 18:512013-07-06 17:18
paulvh 
paulh 
normaltrivialalways
resolvedfixed 
 
3.90beta1Current GIT 
0001761: Cosmetic Menu choices
Customers -> Sites -> Browse
change to
Customers -> Sites -> Browse Sites

Customers -> Contacts -> Browse
change to
Customers -> Contacts -> Browse Contacts


Customers -> Maintenance -> Browse
change to
Customers -> Maintenance -> Browse Contracts

Diff in Additional Information for lib/strings.inc.php
***************
*** 122,124 ****
  $hmenu[2010] = $hmenu[2010] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}sites.php"),
                         20=> array ( 'perm'=> 2, 'name'=> $strNewSite, 'url'=>"{$CONFIG['application_webpath']}site_add.php?action=showform")
--- 122,124 ----
  $hmenu[2010] = $hmenu[2010] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowseSites, 'url'=>"{$CONFIG['application_webpath']}sites.php?search_string=*&displayinactive=false"),
                         20=> array ( 'perm'=> 2, 'name'=> $strNewSite, 'url'=>"{$CONFIG['application_webpath']}site_add.php?action=showform")
***************
*** 128,130 ****
  $hmenu[2020] = $hmenu[2020] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}contacts.php?search_string=A"),
                         20=> array ( 'perm'=> 1, 'name'=> $strNewContact, 'url'=>"{$CONFIG['application_webpath']}contact_add.php?action=showform")
--- 128,130 ----
  $hmenu[2020] = $hmenu[2020] +
! array (10=> array ( 'perm'=> 11, 'name'=> $strBrowseContacts, 'url'=>"{$CONFIG['application_webpath']}contacts.php?search_string=*"),
                         20=> array ( 'perm'=> 1, 'name'=> $strNewContact, 'url'=>"{$CONFIG['application_webpath']}contact_add.php?action=showform")
***************
*** 134,136 ****
  $hmenu[2030] = $hmenu[2030] +
! array (10=> array ( 'perm'=> 19, 'name'=> $strBrowse, 'url'=>"{$CONFIG['application_webpath']}contracts.php?search_string=A"),
                         20=> array ( 'perm'=> 39, 'name'=> $strNewContract, 'url'=>"{$CONFIG['application_webpath']}contract_add.php?action=showform"),
--- 134,136 ----
  $hmenu[2030] = $hmenu[2030] +
! array (10=> array ( 'perm'=> 19, 'name'=> $strBrowseContracts, 'url'=>"{$CONFIG['application_webpath']}contracts.php?search_string=*"),
                         20=> array ( 'perm'=> 39, 'name'=> $strNewContract, 'url'=>"{$CONFIG['application_webpath']}contract_add.php?action=showform"),
patch
Issue History
2012-01-19 18:51paulvhNew Issue
2012-01-19 18:52paulvhTag Attached: patch
2012-01-22 12:12paulhNote Added: 0004413
2012-01-22 12:12paulhStatusnew => confirmed
2013-02-04 20:41paulhAssigned To => paulh
2013-02-04 20:41paulhStatusconfirmed => assigned
2013-02-04 20:44paulhNote Added: 0004693
2013-02-04 20:44paulhStatusassigned => resolved
2013-02-04 20:44paulhResolutionopen => fixed
2013-02-04 20:44paulhFixed in Version => Current GIT
2013-07-06 17:18ivanTarget Version => 3.90beta1

Notes
(0004413)
paulh   
2012-01-22 12:12   
Thanks Paulvh.

I agree as we have "New Contact" under the contact menu we should be consistent and have "Browse Contact" (or remove Contact from the new link)
(0004693)
paulh   
2013-02-04 20:44   
Thanks again paulvh this has been merged into the next major release in git commit 8d6baca