SiT! Bugs - SiT!
View Issue Details
0001804SiT!sites & contactspublic2012-09-24 08:282014-03-04 20:34
nicdev 
paulh 
normalminoralways
resolvedfixed 
WindowsWindows Server2000+Later
3.67 LTS 
3.90beta2Current GIT 
0001804: Missing country SERBIA from country list
In SiT!, the language dropdown is hardcoded (function country_drop_down), and it does not include "SERBIA" and possibly others.

It could be good to turn this into a DB table, to avoid further issues in the future?

Ciao
No tags attached.
Issue History
2012-09-24 08:28nicdevNew Issue
2012-09-24 09:17paulhNote Added: 0004528
2012-09-24 09:17paulhStatusnew => confirmed
2012-09-24 09:53paulhNote Added: 0004529
2012-09-24 14:13ivanNote Added: 0004530
2012-09-24 14:30nicdevNote Added: 0004531
2013-12-22 20:01paulhAssigned To => paulh
2013-12-22 20:01paulhStatusconfirmed => assigned
2014-03-04 20:34paulhNote Added: 0004921
2014-03-04 20:34paulhStatusassigned => resolved
2014-03-04 20:34paulhResolutionopen => fixed
2014-03-04 20:34paulhFixed in Version => Current GIT
2014-03-04 20:34paulhTarget Version => 3.90beta2

Notes
(0004528)
paulh   
2012-09-24 09:17   
Confirmed, don't think the country list has been updated in the last few years so 'new' countries recognized by ISO haven't been added, we should review the whole list.
(0004529)
paulh   
2012-09-24 09:53   
http://www.textfixer.com/resources/dropdowns/country-list-iso-codes.txt [^]
(0004530)
ivan   
2012-09-24 14:13   
Agreed. A DB table would be good, or the least a file to include or something so that it's easy to update.
(0004531)
nicdev   
2012-09-24 14:30   
Thank you Paul and Ivan.

what do you prefer? For me a DB table jumps to mind first, but involves a lot of changes (especially for the 3.x LTS branch), so from a time limit point of view I suggest a txt file, in /inc/ directory of 3.9x, and just an update of the Country list in that function in 3.x.

If we can come to agreement I propose to do the code changes :-)
(0004921)
paulh   
2014-03-04 20:34   
Fixed in 4ec2bd5, we now store the countries in the db and reference based on ISO code which should permit i18n in the future and also easy addition