SiT! Bugs - SiT! | ||||||||||
View Issue Details | ||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||||
0001843 | SiT! | LDAP | public | 2013-03-01 13:17 | 2013-03-02 13:17 | |||||
Reporter | dipohl | |||||||||
Assigned To | paulh | |||||||||
Priority | normal | Severity | major | Reproducibility | always | |||||
Status | resolved | Resolution | fixed | |||||||
Platform | Linux | OS | Linux | OS Version | 2.6+later | |||||
Product Version | 3.67 LTS | |||||||||
Target Version | 3.68 | Fixed in Version | Current SVN | |||||||
Summary | 0001843: LDAP-Sync: Disabling of contacts fails | |||||||||
Description | contact records, that are disabled or no longer existent in LDAP-Source will not get disabled in SiT DB. The procedure will tell, that the account is already disabled in SiT DB, but that isn't true. | |||||||||
Steps To Reproduce | Delete or disable user account in LDAP-Source (EDIR in my case) and run auto.php Check SiT error log | |||||||||
Additional Information | Wrong program logic in classes.inc.php. Can be fixed by sit-devel/lib # diff -u classes.inc.php.old classes.inc.php --- classes.inc.php.old 2013-02-28 19:51:15.000000000 +0100 +++ classes.inc.php 2013-02-28 19:51:49.000000000 +0100 @@ -504,7 +504,7 @@ $sql = "SELECT 1 FROM `{$GLOBALS['dbContacts']}` WHERE id = {$this->id} AND active = 'false'"; $result = mysql_query($sql); if (mysql_error()) trigger_error(mysql_error(), E_USER_WARNING); - if (mysql_num_rows($result) == 0) + if (mysql_num_rows($result) == 1) { debug_log("Failed to disable contact {$this->username}, was already disabled"); $toReturn = true; @@ -554,4 +554,4 @@ else return false; } } -?> \ No newline at end of file +?> | |||||||||
Tags | patch | |||||||||
Relationships |
| |||||||||
Attached Files | ||||||||||
Issue History | ||||||||||
Date Modified | Username | Field | Change | |||||||
2013-03-01 13:17 | dipohl | New Issue | ||||||||
2013-03-01 13:18 | dipohl | Additional Information Updated | bug_revision_view_page.php?rev_id=298#r298 | |||||||
2013-03-01 13:21 | ivan | Tag Attached: patch | ||||||||
2013-03-01 19:47 | paulh | Note Added: 0004722 | ||||||||
2013-03-01 19:47 | paulh | Assigned To | => paulh | |||||||
2013-03-01 19:47 | paulh | Status | new => assigned | |||||||
2013-03-01 19:48 | paulh | Relationship added | related to 0001424 | |||||||
2013-03-01 19:48 | paulh | Category | scheduler => LDAP | |||||||
2013-03-02 13:17 | paulh | Note Added: 0004725 | ||||||||
2013-03-02 13:17 | paulh | Status | assigned => resolved | |||||||
2013-03-02 13:17 | paulh | Resolution | open => fixed | |||||||
2013-03-02 13:17 | paulh | Fixed in Version | => Current SVN |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|