SiT! Bugs - SiT!
View Issue Details
0000415SiT!triggerspublic2009-01-21 09:062009-02-27 16:27
paulh 
ivan 
normalminorhave not tried
closedfixed 
3.41 
3.453.45 
0000415: {contactphone} not replaced
In email templates {contactphone} is not replaced
No tags attached.
related to 0000423assigned ivan Template editor shows variables that aren't available 
Issue History
2009-01-21 09:06paulhNew Issue
2009-01-21 09:06paulhStatusnew => assigned
2009-01-21 09:06paulhAssigned To => kieran
2009-01-21 09:19kieranNote Added: 0000506
2009-01-21 09:19kieranStatusassigned => resolved
2009-01-21 09:19kieranResolutionopen => fixed
2009-01-21 09:19kieranFixed in Version => 3.45
2009-01-21 09:19kieranTarget Version => 3.45
2009-01-23 11:00ivanNote Added: 0000510
2009-01-23 11:00ivanAssigned Tokieran => ivan
2009-01-23 11:00ivanStatusresolved => assigned
2009-01-23 11:00ivanResolutionfixed => reopened
2009-01-23 11:00ivanFixed in Version3.45 =>
2009-01-23 11:16ivanNote Added: 0000511
2009-01-23 12:50ivanNote Added: 0000514
2009-01-23 13:02ivanRelationship addedrelated to 0000423
2009-01-23 13:35ivanNote Added: 0000517
2009-01-23 13:35ivanStatusassigned => resolved
2009-01-23 13:35ivanResolutionreopened => fixed
2009-01-23 13:35ivanFixed in Version => 3.45
2009-02-27 16:27ivanStatusresolved => closed

Notes
(0000506)
kieran   
2009-01-21 09:19   
Fixed in trunk r4683
(0000510)
ivan   
2009-01-23 11:00   
Reopening this, the r4683 fix didn't seem to work for me or for salford. Trying the variable in a 'support email' template.

Assigning this to me, I'll take a look
(0000511)
ivan   
2009-01-23 11:16   
The problem seems to be that {contactphone} needs contactid as a param, but the incident emails only send incidentid and triggeruserid as params.

I'm not sure if we have a method of setting up "auto-params", like a way of setting contactid from the incidentid, but I think thats what is needed. Looking into it.
(0000514)
ivan   
2009-01-23 12:50   
OK, we define replacement variables several times, with different required params. e.g. {contactemail} is defined to require either incidentid or contactid. So I need to define a new replacement for {contactphone}.

There is another issue that this brings up, the GUI should not let {contactphone} be selected for the template unless the variable requirements are provided. For incident type templates we only provide, incidentid and triggeruserid. I'll open another bug for that.
(0000517)
ivan   
2009-01-23 13:35   
Fixed in trunk svn r4708

There may be other variables that are missing