SiT! Bugs - SiT!
View Issue Details
0000504SiT!portalpublic2009-02-17 21:552009-02-27 16:25
kieran 
ivan 
normalminorhave not tried
closedfixed 
 
3.453.45 
0000504: Errors in the portal
Should we be showing errors in the portal at all? Here's an example of what we reveal:

Application Warning [512]
Error in trigger rule for TRIGGER_INCIDENT_CREATED, check your trigger rules. in /home/kieran/Code/sitracker/lib/triggers.inc.php @ line 110
Backtrace:
/home/kieran/Code/sitracker/lib/triggers.inc.php @ line 110 trigger_error()
/home/kieran/Code/sitracker/portal/add.php @ line 232 trigger()
No tags attached.
Issue History
2009-02-17 21:55kieranNew Issue
2009-02-17 22:37ivanNote Added: 0000637
2009-02-23 10:14ivanNote Added: 0000657
2009-02-23 10:14ivanStatusnew => feedback
2009-02-26 11:07ivanStatusfeedback => assigned
2009-02-26 11:07ivanAssigned To => ivan
2009-02-26 15:23ivanNote Added: 0000668
2009-02-26 15:23ivanStatusassigned => feedback
2009-02-26 15:23ivanResolutionopen => fixed
2009-02-26 15:23ivanFixed in Version => Current SVN
2009-02-26 19:01kieranNote Added: 0000673
2009-02-27 10:14ivanNote Added: 0000674
2009-02-27 13:50ivanNote Added: 0000677
2009-02-27 13:50ivanStatusfeedback => resolved
2009-02-27 13:54ivanFixed in VersionCurrent SVN => 3.45
2009-02-27 16:25ivanStatusresolved => closed

Notes
(0000637)
ivan   
2009-02-17 22:37   
Was giving some thought to this on the train the other night actually.

Do you think we should hide all errors if error logging is on? Perhaps just give a generic 'an error has occurred check the log file" with no other info.?
(0000657)
ivan   
2009-02-23 10:14   
^^
(0000668)
ivan   
2009-02-26 15:23   
svn trunk r5206 prevents displaying of any messages in the web browser if messages are being logged to the error logfile.
(0000673)
kieran   
2009-02-26 19:01   
As the error logfile is blank by default, should we not also provide a generic error message too?
(0000674)
ivan   
2009-02-27 10:14   
I'm not sure about the benefits of a generic message, I think it might be more irritating than helpful. For example we'll probably have hundreds of reports from people saying they get "An error in SiT" which won't help us or them.
(0000677)
ivan   
2009-02-27 13:50   
Marking this resolved for 3.45, we can come back and improve this for 3.50 if required.