SiT! Bugs - SiT!
View Issue Details
0000707SiT!permissionspublic2009-05-24 13:062009-08-16 14:39
paulh 
kieran 
normalminorhave not tried
closedfixed 
 
3.503.50 
0000707: Problem n edit_user_permissions
in edit_user_permissions.php line 56 is an IF though the body of this is not clear
No tags attached.
Issue History
2009-05-24 13:06paulhNew Issue
2009-05-24 13:06paulhNote Added: 0001099
2009-08-15 16:26kieranNote Added: 0001551
2009-08-15 16:26kieranAssigned To => kieran
2009-08-15 16:26kieranStatusnew => resolved
2009-08-15 16:26kieranResolutionopen => fixed
2009-08-15 16:26kieranFixed in Version => Current SVN
2009-08-15 21:31ivanTarget Version => 3.50
2009-08-16 13:15ivanFixed in VersionCurrent SVN => 3.50
2009-08-16 14:39ivanNote Added: 0001700
2009-08-16 14:39ivanStatusresolved => closed

Notes
(0001099)
paulh   
2009-05-24 13:06   
The code is:

        if ($cresult AND mysql_num_rows($cresult) > 0)
        if (empty($seltab)) $seltab = 1;
        while ($pcat = mysql_fetch_object($cresult))
        {
            echo "<li";
            if ($seltab == $pcat->id) echo " class='active'";
            echo "><a href='{$_SERVER['PHP_SELF']}?tab={$pcat->id}'>{$GLOBALS[$pcat->category]}</a>";
            $cat[$pcat->id] = $pcat->category;
        }
        echo "";
        echo "</div>";

What should be in the if?
(0001551)
kieran   
2009-08-15 16:26   
Fixed in trunk svn r5770. The first if check if the result and number of rows so i'm 99.9% sure it goes around everything else so it doesn't get a mysql resource error.
(0001700)
ivan   
2009-08-16 14:39   
Released in 3.50rc1