SiT! Bugs - SiT!
View Issue Details
0000752SiT!incidentspublic2009-06-30 18:322009-08-16 14:40
mfeider67 
paulh 
normalminorsometimes
closedfixed 
3.45 
3.503.50 
0000752: close solution default text...not right
I believe the SQL statement in the additional information has a bug. This statement is found in incident_close.php

The OR statement doesn't have parens and can effect the results by returning something that is not of the right incientid.
    $sql = "SELECT * FROM `{$dbUpdates}` WHERE incidentid='{$id}' AND type='solution' OR type='actionplan' ORDER BY timestamp DESC";

possible solution 1:
    $sql = "SELECT * FROM `{$dbUpdates}` WHERE incidentid='{$id}' AND (type='solution' OR type='actionplan') ORDER BY timestamp DESC";

possibly solution 2:
    $sql = "SELECT * FROM `{$dbUpdates}` WHERE incidentid='{$id}' AND type in ('solution','actionplan') ORDER BY timestamp DESC";
No tags attached.
Issue History
2009-06-30 18:32mfeider67New Issue
2009-06-30 18:47mfeider67Note Added: 0001253
2009-06-30 19:23paulhNote Added: 0001254
2009-06-30 19:23paulhAssigned To => paulh
2009-06-30 19:23paulhStatusnew => resolved
2009-06-30 19:23paulhResolutionopen => fixed
2009-06-30 19:23paulhFixed in Version => Current SVN
2009-08-15 21:31ivanTarget Version => 3.50
2009-08-16 13:15ivanFixed in VersionCurrent SVN => 3.50
2009-08-16 14:40ivanNote Added: 0001725
2009-08-16 14:40ivanStatusresolved => closed

Notes
(0001253)
mfeider67   
2009-06-30 18:47   
This also begs the question - how do you get a SOLUTION entered prior to the close page, such that it will show up by default?

This is not my experience when doing SLA - resolution, but it was partly an expectation. But I know that is of type='slamet'.
(0001254)
paulh   
2009-06-30 19:23   
Hi,

r5494 resolves this, thanks for the fix.

To get a type of solution you can enter a update or email of type "resolution/reprioratisation" which sets the sla as 'solution'

Cheers
Paul
(0001725)
ivan   
2009-08-16 14:40   
Released in 3.50rc1