SiT! Bugs - SiT!
View Issue Details
0000753SiT!inbound emailpublic2009-06-30 23:012009-08-16 14:38
mfeider67 
ivan 
normalminoralways
closedfixed 
3.45 
3.503.50 
0000753: email assign to contact
Any reason for the commenting out of "// $contactsql .= "OR SOUNDEX('$search_string') = SOUNDEX(CONCAT_WS(', ', c.surname, c.forenames)) ";" below? This can be found in incident_add.php

I actually need to uncomment this to get ours to work correctly. As ours comes across in this order. I haven't seen any adverse effect from doing this.

I am also not sure if this is a bug. But it didn't work prior to uncommenting.
   // Filter by contact
    $contactsql .= "AND (c.surname LIKE '%$search_string%' OR c.forenames LIKE '%$search_string%' ";
    $contactsql .= "OR SOUNDEX('$search_string') = SOUNDEX(CONCAT_WS(' ', c.forenames, c.surname)) ";
// $contactsql .= "OR SOUNDEX('$search_string') = SOUNDEX(CONCAT_WS(', ', c.surname, c.forenames)) ";
    $contactsql .= "OR s.name LIKE '%$search_string%') ";
No tags attached.
Issue History
2009-06-30 23:01mfeider67New Issue
2009-07-02 11:57ivanNote Added: 0001255
2009-07-02 11:57ivanStatusnew => feedback
2009-07-02 15:12mfeider67Note Added: 0001256
2009-07-20 22:07ivanNote Added: 0001358
2009-07-20 22:07ivanAssigned To => ivan
2009-07-20 22:07ivanStatusfeedback => resolved
2009-07-20 22:07ivanResolutionopen => fixed
2009-07-20 22:07ivanFixed in Version => Current SVN
2009-07-20 22:07ivanTarget Version => 3.50
2009-08-16 13:16ivanFixed in VersionCurrent SVN => 3.50
2009-08-16 14:38ivanNote Added: 0001632
2009-08-16 14:38ivanStatusresolved => closed

Notes
(0001255)
ivan   
2009-07-02 11:57   
It was a speed issue thing. I think it's ms-outlook that bizarrely puts names the wrong way around. I'm happy to put that line back in if you think speed isn't a concern.
(0001256)
mfeider67   
2009-07-02 15:12   
I have both uncommented now and don't really notice it. It hasn't been bad speed wise, but do have only 50 contacts or so, and won't get above 140 max. I would bet that a higher contact number may be worse for this, but just on the mysql side right? As I understand it when trying to debug it is a matter of Forename, Surname or Surname, Forename. It may be such that you could add a variable to choose, but I don't know if there are cases when both would be required.

I think in our case the Surname, Forename is the only one I need. Unfortunitely also the one commented out.
(0001358)
ivan   
2009-07-20 22:07   
Uncommented and added back in as of trunk svn r5542
(0001632)
ivan   
2009-08-16 14:38   
Released in 3.50rc1