SiT! Bugs - SiT!
View Issue Details
0000974SiT!holidayspublic2009-10-07 15:032010-03-27 12:31
paulh 
ivan 
normalminoralways
closedfixed 
 
3.60 LTS3.60 LTS 
0000974: Holidays taken on holidays.php counts denied holidays
This page count appears to include holidays which have been denied
No tags attached.
Issue History
2009-10-07 15:03paulhNew Issue
2009-10-07 20:53paulhNote Added: 0002073
2010-02-20 19:39ivanNote Added: 0002418
2010-02-20 19:43ivanStatusnew => assigned
2010-02-20 19:43ivanAssigned To => ivan
2010-02-20 19:43ivanNote Added: 0002420
2010-02-20 19:44ivanTarget Version => 3.60 LTS
2010-02-20 19:44ivanNote Edited: 0002420bug_revision_view_page.php?bugnote_id=2420#r68
2010-03-14 13:19ivanNote Added: 0002681
2010-03-14 13:19ivanStatusassigned => feedback
2010-03-17 18:32TomseNote Added: 0002723
2010-03-17 18:41ivanNote Added: 0002724
2010-03-17 18:41ivanStatusfeedback => resolved
2010-03-17 18:41ivanFixed in Version => 3.60 LTS
2010-03-17 18:41ivanResolutionopen => fixed
2010-03-27 12:31ivanStatusresolved => closed

Notes
(0002073)
paulh   
2009-10-07 20:53   
reproduced this with the latest 3.5 code

Steps ro repro

UserA request holiday
UserB declines


User A sees number of days taken incremented by one
(0002418)
ivan   
2010-02-20 19:39   
Can't reproduce this with v3.99 (4.x branch)
(0002420)
ivan   
2010-02-20 19:43   
(edited on: 2010-02-20 19:44)
function user_count_holidays($userid, $type, $date=0,
                             $approved = array(HOL_APPROVAL_NONE, HOL_APPROVAL_GRANTED, HOL_APPROVAL_DENIED))



Such a strange default, we should change this

(0002681)
ivan   
2010-03-14 13:19   
Again I can't reproduce this with svn 3.x branch r6239

I did do some work around this area a few months back (could have been longer) so maybe it got fixed?
(0002723)
Tomse   
2010-03-17 18:32   
I've tried reproducing this aswell in 3.x
not able to do so.

I guess it's fixed?
(0002724)
ivan   
2010-03-17 18:41   
Marking fixed since we can't reproduce it, but not sure which commit actually did the fixing. If this resurfaces please reopen. thanks.