SiT! Bugs

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001061SiT!otherpublic2010-02-10 11:302015-05-04 11:58
Reporterivan 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001061: Dependency issues in .deb package
DescriptionWe depend on prototype.js and scriptaculous.js and we should set up package dependencies properly rather than bundle these within the .deb file. Bundling is bad because security fixes won't percolate.
TagsNo tags attached.
Attached Files

- Relationships
parent of 0001112resolvedivan Move timesheet feature to Project Plugin 

-  Notes
User avatar (0002344)
paulh (administrator)
2010-02-10 13:23

I'll take a look at this
User avatar (0002351)
paulh (administrator)
2010-02-11 20:35

From some googling and looking at what libjs-prototype installs the way to do this on Debian is to include the javascript from /javascript/

e.g.

<script language="javascript" type="text/javascript"
src="/javascript/prototype/prototype.js"></script>

rather than symlinking or anything like that, this /javascript/ is done via conf.d/javascript-common.conf this means on building the deb all instances of

{$CONFIG['application_webpath']}scripts/prototype/prototype.js

need changing to /javascript/prototype/prototype.js which isn't a biggie

User avatar (0002378)
paulh (administrator)
2010-02-16 19:40

Replacing prototype is straight forward as we just replace {$CONFIG['application_webpath']}scripts/prototype/prototype.js unfortunately scriptaculous isn't as easy as we don't directly include this but instead use $pagescripts and htmlheader.inc.php

if (is_array($pagescripts))
{
    foreach ($pagescripts AS $pscript)
    {
        echo "<script src='{$CONFIG['application_webpath']}scripts/{$pscript}' type='text/javascript'></script>\n";
    }
    unset($pagescripts, $pscript);
}

So we can't just sed this one,
User avatar (0002720)
ivan (administrator)
2010-03-17 14:08

I've assigned this to me so that I'll remember to change the way pagescripts works, I'll bat it back to you (paulh) once thats done
User avatar (0003042)
ivan (administrator)
2010-04-12 21:12

In Git 623ebb0 scriptaculous is always included instead of using pagescripts. This should make dependency issues a bit easier?

- Issue History
Date Modified Username Field Change
2010-02-10 11:30 ivan New Issue
2010-02-10 13:23 paulh Note Added: 0002344
2010-02-10 13:23 paulh Assigned To => paulh
2010-02-10 13:23 paulh Status new => confirmed
2010-02-11 20:35 paulh Note Added: 0002351
2010-02-11 20:35 paulh Status confirmed => assigned
2010-02-16 19:40 paulh Note Added: 0002378
2010-03-01 14:06 ivan Relationship added parent of 0001112
2010-03-17 14:08 ivan Assigned To paulh => ivan
2010-03-17 14:08 ivan Note Added: 0002720
2010-04-12 21:12 ivan Note Added: 0003042
2010-04-12 21:15 ivan Assigned To ivan => paulh
2015-05-04 11:58 paulh Assigned To paulh =>
2015-05-04 11:58 paulh Status assigned => confirmed


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker