Anonymous | Login | Signup for a new account | 2021-01-21 08:28 GMT | ![]() |
Main | My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
0001061 | SiT! | other | public | 2010-02-10 11:30 | 2015-05-04 11:58 | ||||||||
Reporter | ivan | ||||||||||||
Assigned To | |||||||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||||||
Status | confirmed | Resolution | open | ||||||||||
Platform | OS | OS Version | |||||||||||
Product Version | |||||||||||||
Target Version | Fixed in Version | ||||||||||||
Summary | 0001061: Dependency issues in .deb package | ||||||||||||
Description | We depend on prototype.js and scriptaculous.js and we should set up package dependencies properly rather than bundle these within the .deb file. Bundling is bad because security fixes won't percolate. | ||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files | |||||||||||||
![]() |
|
paulh (administrator) 2010-02-10 13:23 |
I'll take a look at this |
paulh (administrator) 2010-02-11 20:35 |
From some googling and looking at what libjs-prototype installs the way to do this on Debian is to include the javascript from /javascript/ e.g. <script language="javascript" type="text/javascript" src="/javascript/prototype/prototype.js"></script> rather than symlinking or anything like that, this /javascript/ is done via conf.d/javascript-common.conf this means on building the deb all instances of {$CONFIG['application_webpath']}scripts/prototype/prototype.js need changing to /javascript/prototype/prototype.js which isn't a biggie |
paulh (administrator) 2010-02-16 19:40 |
Replacing prototype is straight forward as we just replace {$CONFIG['application_webpath']}scripts/prototype/prototype.js unfortunately scriptaculous isn't as easy as we don't directly include this but instead use $pagescripts and htmlheader.inc.php if (is_array($pagescripts)) { foreach ($pagescripts AS $pscript) { echo "<script src='{$CONFIG['application_webpath']}scripts/{$pscript}' type='text/javascript'></script>\n"; } unset($pagescripts, $pscript); } So we can't just sed this one, |
ivan (administrator) 2010-03-17 14:08 |
I've assigned this to me so that I'll remember to change the way pagescripts works, I'll bat it back to you (paulh) once thats done |
ivan (administrator) 2010-04-12 21:12 |
In Git 623ebb0 scriptaculous is always included instead of using pagescripts. This should make dependency issues a bit easier? |
![]() |
|||
Date Modified | Username | Field | Change |
2010-02-10 11:30 | ivan | New Issue | |
2010-02-10 13:23 | paulh | Note Added: 0002344 | |
2010-02-10 13:23 | paulh | Assigned To | => paulh |
2010-02-10 13:23 | paulh | Status | new => confirmed |
2010-02-11 20:35 | paulh | Note Added: 0002351 | |
2010-02-11 20:35 | paulh | Status | confirmed => assigned |
2010-02-16 19:40 | paulh | Note Added: 0002378 | |
2010-03-01 14:06 | ivan | Relationship added | parent of 0001112 |
2010-03-17 14:08 | ivan | Assigned To | paulh => ivan |
2010-03-17 14:08 | ivan | Note Added: 0002720 | |
2010-04-12 21:12 | ivan | Note Added: 0003042 | |
2010-04-12 21:15 | ivan | Assigned To | ivan => paulh |
2015-05-04 11:58 | paulh | Assigned To | paulh => |
2015-05-04 11:58 | paulh | Status | assigned => confirmed |
Copyright © 2000 - 2021 MantisBT Team |