SiT! Bugs

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001263SiT!triggerspublic2010-04-12 13:222014-05-06 14:57
Reportersancho78rus 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusconfirmedResolutionopen 
PlatformLinuxOSLinuxOS Version2.6+later
Product Version3.60 LTS 
Target VersionFixed in Version 
Summary0001263: NOTICE_NEW_HELD_EMAIL trigger dont work
DescriptionNOTICE_NEW_HELD_EMAIL trigger dont work for new email.
And should it work if incident logged via portal?
TagsNo tags attached.
Attached Files

- Relationships
related to 0001934new new held email template produces broken link 

-  Notes
User avatar (0003034)
kieran (administrator)
2010-04-12 13:37

As per http://sitracker.org/forum/viewtopic.php?f=4&t=1417049 [^] the SQL code fetches ALL waiting emails but we only want one.

As for the incident logged via portal, no because that's not an email. 4.0 has a TRIGGER_PORTAL_INCIDENT_CREATED trigger though.
(0003035)
sancho78rus (reporter)
2010-04-12 13:47

May be can you include TRIGGER_PORTAL_INCIDENT_CREATED in 3.61 if itis not hard to do? Because its very important trigger.
User avatar (0003037)
kieran (administrator)
2010-04-12 14:08

Unfortunately, 3.x is bug fixes only and this counts as a feature.

It'll be very easy for you to add though, the code is here:

http://gitorious.org/sit/xerosis-sit/commit/75b132d5d56f8fd987256ada5e5b92ec3ca77cc5 [^]

The only difference is the last file for 3.x will be:
trigger('TRIGGER_PORTAL_INCIDENT_CREATED', array('incidentid' => $incidentid));
(0003038)
sancho78rus (reporter)
2010-04-12 14:34

i cannot find where to paste in lib/triggers.inc.php
User avatar (0003039)
kieran (administrator)
2010-04-12 14:53

Sorry, lib/triggers.inc.php is called lib/triggertypes.inc.php in 3.x.
(0003040)
sancho78rus (reporter)
2010-04-12 17:29

thanks! it works now! (I mean TRIGGER_PORTAL_INCIDENT_CREATED)
User avatar (0003108)
kieran (administrator)
2010-04-24 21:24

Test fixed pushed to git 10ca386, might be backported to 3.61 depending on testing.

http://sit.pastebin.com/zJ3qT9Sr [^] for details of creating an appropriate trigger.
User avatar (0003186)
ivan (administrator)
2010-05-29 11:27

(pastebin above pasted here for posterity)

id triggerid userid action template parameters checks
39 TRIGGER_WAITING_HELD_EMAIL 1 ACTION_NOTICE NOTICE_MINS_HELD_EMAIL notifymins=1 {holdingmins} > {notifymins}
User avatar (0003187)
ivan (administrator)
2010-05-29 11:45

I tried this today with 4.x and latest Git and I can't get a notice to appear. Bumping this to 3.62 now since there's no time to fix before 3.61 release (it's already overdue) and this is a longstanding issue that affects a non-core feature.
User avatar (0003296)
ivan (administrator)
2010-07-14 15:37

Un-targetting this since there's no resource to fix it just now and I wouldn't say it was critical for the next release.
User avatar (0003302)
Tomse (developer)
2010-07-16 22:19

I've added the above mentioned trigger to the database, here are some issues:

Link to holding_queue.php points to http://holding_queue.php [^] - code string looks fine though, it has {applicationurl} shown.
every minute a new notice arrives and adds itself to the list.
no minute time is presented. (new message in holding queue for)

- Issue History
Date Modified Username Field Change
2010-04-12 13:22 sancho78rus New Issue
2010-04-12 13:35 kieran Status new => assigned
2010-04-12 13:35 kieran Assigned To => kieran
2010-04-12 13:37 kieran Note Added: 0003034
2010-04-12 13:37 kieran Status assigned => confirmed
2010-04-12 13:37 kieran Status confirmed => assigned
2010-04-12 13:37 kieran Product Version => 3.60 LTS
2010-04-12 13:37 kieran Target Version => 3.61 LTS
2010-04-12 13:47 sancho78rus Note Added: 0003035
2010-04-12 14:08 kieran Note Added: 0003037
2010-04-12 14:34 sancho78rus Note Added: 0003038
2010-04-12 14:53 kieran Note Added: 0003039
2010-04-12 17:29 sancho78rus Note Added: 0003040
2010-04-24 21:24 kieran Note Added: 0003108
2010-04-24 21:24 kieran Status assigned => feedback
2010-05-29 11:27 ivan Note Added: 0003186
2010-05-29 11:45 ivan Note Added: 0003187
2010-05-29 11:45 ivan Target Version 3.61 LTS => 3.62 LTS
2010-07-14 15:37 ivan Note Added: 0003296
2010-07-14 15:37 ivan Target Version 3.62 LTS =>
2010-07-16 22:19 Tomse Note Added: 0003302
2011-02-08 14:29 ivan Status feedback => confirmed
2013-12-22 19:43 paulh Assigned To kieran =>
2014-05-06 14:57 paulh Relationship added related to 0001934


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker