0001341: Disabling Feedback has no effect

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001341

SiT!

feedback

public

2010-06-11 15:53

2010-07-21 21:29

Reporter

jko

Assigned To

paulh

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.60 LTS

Target Version

3.62 LTS

Fixed in Version

3.62 LTS

Summary

0001341: Disabling Feedback has no effect

Description

I disabled the "feedback"-option in the configuration and expected this to skip the "login and give us your feedback"-email when closing incidents.

Unfortunately, it didn't stop SiT from sending this emails. So I did a search for the configuration-variable (feedback_enabled) in all files and found almost no match. Only "real" match is the about page, which makes the whole option pretty pointless.

To get the expected result I did the following tweak to send_feedback in functions.inc.php:

global $CONFIG;
if (!$CONFIG['feedback_enabled']) return false;
foreach ...

Is(was) this an bug or did I misunderstand the feedback concept/module?

Tags

No tags attached.

Attached Files

Relationships

Notes
(0003260) paulh (administrator) 2010-06-19 12:33	Thanks jko, can reproduce this, your understanding is correct, I'll target this for the next release.

(0003261) paulh (administrator) 2010-06-19 12:43	r6512 and fd0e92d resolve this

(0003332) ivan (administrator) 2010-07-18 15:05	Released in v3.62

Issue History
Date Modified	Username	Field	Change
2010-06-11 15:53	jko	New Issue
2010-06-19 12:33	paulh	Note Added: 0003260
2010-06-19 12:33	paulh	Status	new => confirmed
2010-06-19 12:33	paulh	Target Version	=> 3.62 LTS
2010-06-19 12:43	paulh	Note Added: 0003261
2010-06-19 12:43	paulh	Assigned To	=> paulh
2010-06-19 12:43	paulh	Status	confirmed => resolved
2010-06-19 12:43	paulh	Resolution	open => fixed
2010-06-19 12:43	paulh	Fixed in Version	=> Current SVN
2010-07-18 15:05	ivan	Note Added: 0003332
2010-07-18 15:05	ivan	Status	resolved => closed
2010-07-21 21:29	ivan	Fixed in Version	Current SVN => 3.62 LTS