0000144: js function confirm_delete() in review_incoming_updates.php has unbalanced quotes

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000144

SiT!

inbound email

public

2008-08-12 17:37

2008-11-21 17:27

Reporter

user13

Assigned To

ivan

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.33

Target Version

3.40

Fixed in Version

3.40

Summary

0000144: js function confirm_delete() in review_incoming_updates.php has unbalanced quotes

Description

On the review_incoming_updates.php page, the checkboxes do not work due to unbalanced quotes in the confirm_delete() function.

The version in the code is this:

        function confirm_delete()
        {
            return window.confirm('<?php echo $strAreYouSureDelete; ?>");
        }

(note window.confirm call starts with apostrophe and ends with doublequotes)

it should be this:

        function confirm_delete()
        {
            return window.confirm("<?php echo $strAreYouSureDelete; ?>");
        }

Tags

No tags attached.

Attached Files

Relationships

Notes
(0000059) kieran (administrator) 2008-08-12 17:59	Which version is this in? Looks to be fixed in svn and probably 3.36.

(0000060) ivan (administrator) 2008-08-13 14:02	We should not have been using confirm_delete() in any case since this function was obsoleted and replaced by confirm_action(). I've fixed that in svn trunk r3900 and tested, this problem no longer exists. Thanks for the bug report.

Issue History
Date Modified	Username	Field	Change
2008-08-12 17:37	user13	New Issue
2008-08-12 17:59	kieran	Note Added: 0000059
2008-08-13 14:02	ivan	Note Added: 0000060
2008-08-13 14:02	ivan	Status	new => resolved
2008-08-13 14:02	ivan	Resolution	open => fixed
2008-08-13 14:02	ivan	Assigned To	=> ivan
2008-08-13 14:02	ivan	Fixed in Version	=> 3.40
2008-08-13 14:02	ivan	Target Version	=> 3.40
2008-08-13 14:02	ivan	Description Updated
2008-11-21 17:27	kieran	Status	resolved => closed