0001502: function "reassign_incident()" in incident.inc.php contains errors

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001502

SiT!

incidents

public

2011-05-02 10:50

2011-07-17 14:25

Reporter

nicdev

Assigned To

paulh

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Windows

Windows Server

OS Version

2000+Later

Product Version

3.63p1

Target Version

3.64 LTS

Fixed in Version

3.64 LTS

Summary

0001502: function "reassign_incident()" in incident.inc.php contains errors

Description

When trying to realise this function I noticed these issues that causes it to function incorrectly.

The parameter passed to the function as follows (line 385 of incident.inc.php):
function reassign_incident($incident, $user, $tuser = '', $nextaction = '', $type = 'full')

According to the info on this function $incident is an integer (the incident id to re-assign), but in line 391 we equate: $incident->nextaction = $nextaction .. making it an array??

The in line 411 we insert in to the "Updates" table a value "$incidentid", where this should be $incident.

The re-assign part works, but there is no entry into the DB for that incident.

Tags

No tags attached.

Attached Files

Relationships

child of

0001501

closed

Reopening an incident keeps the User assignment even when they are out of office

Notes
(0003767) nicdev (developer) 2011-05-02 11:53	Just found another fault in line this function: $result = mysql_query($sql); mysql_query($sql); The Sql query gets executed twice ;-)

(0003770) paulh (administrator) 2011-05-02 17:49	Agree, suspect this function has been partly changed to expect a incident object rather than an ID as line 391 is referencing a Object

(0003771) paulh (administrator) 2011-05-02 17:53	r7132 and 93a3acb resolve

(0004126) ivan (administrator) 2011-07-17 14:25	Fix released in version 3.64 available now

Issue History
Date Modified	Username	Field	Change
2011-05-02 10:50	nicdev	New Issue
2011-05-02 11:53	nicdev	Note Added: 0003767
2011-05-02 12:34	nicdev	Relationship added	child of 0001501
2011-05-02 17:49	paulh	Note Added: 0003770
2011-05-02 17:49	paulh	Status	new => confirmed
2011-05-02 17:51	paulh	Assigned To	=> paulh
2011-05-02 17:51	paulh	Status	confirmed => assigned
2011-05-02 17:53	paulh	Note Added: 0003771
2011-05-02 17:53	paulh	Status	assigned => resolved
2011-05-02 17:53	paulh	Resolution	open => fixed
2011-05-02 17:53	paulh	Fixed in Version	=> Current SVN
2011-07-17 12:46	ivan	Target Version	=> 3.64 LTS
2011-07-17 13:14	ivan	Fixed in Version	Current SVN => 3.64 LTS
2011-07-17 14:25	ivan	Note Added: 0004126
2011-07-17 14:25	ivan	Status	resolved => closed