|Anonymous | Login | Signup for a new account||2020-07-05 11:35 BST|
|Main | My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001712||SiT!||other||public||2011-09-05 16:21||2011-09-06 11:01|
|Platform||Windows||OS||Windows Server||OS Version||2000+Later|
|Product Version||3.65 LTS|
|Target Version||Fixed in Version|
|Summary||0001712: Error in function calculate_working_time|
|Description||The function (in functions.inc.php):|
function calculate_working_time($t1, $t2, $publicholidays) calls for a 3rd parameter $publicholidays that is not used in the function except in some commented code.
This function is used in some of our plugins, and we weren't sure if this parameter is going to be kept or not.
If it is kept we have to change our plugin (which is not an issue), but if not it is easier to remove it or give it a default value instead.
|Tags||No tags attached.|
I can't find an error with this but the $publicholidays holidays parameter should be there and it is used and AFAICT it should have a default value.
You are correct that it does nothing though, there is some commented code inside the function referring to it but it has no effect whatsoever.
It is intended to receive an array containing a list of public holidays, as returned by the function get_public_holidays()
As I recall, the reason we didn't finish this is because we had a hard time making it work with reasonable performance, but this bug report has reminded me we really ought to look into this again.
|2011-09-05 16:21||nicdev||New Issue|
|2011-09-05 16:30||ivan||Relationship added||related to 0000041|
|2011-09-06 11:00||ivan||Note Added: 0004295|
|2011-09-06 11:01||ivan||Status||new => acknowledged|
|Copyright © 2000 - 2020 MantisBT Team|