SiT! Bugs

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001712SiT!otherpublic2011-09-05 16:212011-09-06 11:01
Reporternicdev 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformWindowsOSWindows ServerOS Version2000+Later
Product Version3.65 LTS 
Target VersionFixed in Version 
Summary0001712: Error in function calculate_working_time
DescriptionThe function (in functions.inc.php):
function calculate_working_time($t1, $t2, $publicholidays) calls for a 3rd parameter $publicholidays that is not used in the function except in some commented code.

This function is used in some of our plugins, and we weren't sure if this parameter is going to be kept or not.

If it is kept we have to change our plugin (which is not an issue), but if not it is easier to remove it or give it a default value instead.
TagsNo tags attached.
Attached Files

- Relationships
related to 0000041confirmed Make SLA's take Public Holidays into account 

-  Notes
User avatar (0004295)
ivan (administrator)
2011-09-06 11:00

I can't find an error with this but the $publicholidays holidays parameter should be there and it is used and AFAICT it should have a default value.

You are correct that it does nothing though, there is some commented code inside the function referring to it but it has no effect whatsoever.

It is intended to receive an array containing a list of public holidays, as returned by the function get_public_holidays()

As I recall, the reason we didn't finish this is because we had a hard time making it work with reasonable performance, but this bug report has reminded me we really ought to look into this again.

- Issue History
Date Modified Username Field Change
2011-09-05 16:21 nicdev New Issue
2011-09-05 16:30 ivan Relationship added related to 0000041
2011-09-06 11:00 ivan Note Added: 0004295
2011-09-06 11:01 ivan Status new => acknowledged


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker