0001765: Contact Details Edit

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001765

SiT!

portal

public

2012-01-24 13:57

2013-02-03 15:22

Reporter

paulvh

Assigned To

paulh

Priority

normal

Severity

minor

Reproducibility

always

Status

assigned

Resolution

open

Platform

OS Version

Product Version

3.65 LTS

Target Version

Fixed in Version

Summary

0001765: Contact Details Edit

Description

If we are using LDAP the contact should not be able to edit their information.

See Diff in additional information for contactdetails.php

Additional Information

***************
*** 182,187 ****
      echo ' '.gravatar($user->email, 32);
! echo "</h2>";

! echo "<form action='{$_SERVER[PHP_SELF]}?action=update' method='post'>";
      echo "<table align='center' class='vertical'>";
--- 182,190 ----
      echo ' '.gravatar($user->email, 32);
! echo "</h2>\n\n";

! if ($_SESSION['contact_source'] == 'sit')
! {
! echo "<form action='{$_SERVER[PHP_SELF]}?action=update' method='post'>";
! }
      echo "<table align='center' class='vertical'>";
***************
*** 250,252 ****
      }
! else
      {
--- 253,255 ----
      }
! elseif ($_SESSION['contact_source'] == 'sit')
      {
***************
*** 254,255 ****
--- 257,262 ----
      }
+ else
+ {
+ echo "{$user->fax}";
+ }
      echo "</td></tr>";
***************
*** 260,262 ****
      }
! else
      {
--- 267,269 ----
      }
! elseif ($_SESSION['contact_source'] == 'sit')
      {
***************
*** 265,269 ****
      }
      echo "</td></tr>\n";

! if ( $_SESSION['contact_source'] == 'sit' )
      {
--- 272,280 ----
      }
+ else
+ {
+ echo "{$user->email}";
+ }
      echo "</td></tr>\n";

! if ($_SESSION['contact_source'] == 'sit')
      {
***************
*** 274,277 ****
      echo "<p align='center'>";
! echo "<input type='hidden' name='id' value='{$id}' />";
! echo "<input type='submit' value='{$strUpdate}' />

</form>";

--- 285,291 ----
echo "<p align='center'>";
! if ($_SESSION['contact_source'] == 'sit')
! {
! echo "<input type='hidden' name='id' value='{$id}' />";
! echo "<input type='submit' value='{$strUpdate}' />

</form>";
! }

Notes
(0004666) paulh (administrator) 2013-02-03 15:22	Thanks for this report paulvh I'll look at merging this ASAP

Issue History
Date Modified	Username	Field	Change
2012-01-24 13:57	paulvh	New Issue
2012-01-24 13:57	paulvh	Tag Attached: patch
2013-02-03 15:22	paulh	Assigned To	=> paulh
2013-02-03 15:22	paulh	Status	new => assigned
2013-02-03 15:22	paulh	Note Added: 0004666

Relationships