SiT! Bugs

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001804SiT!sites & contactspublic2012-09-24 08:282014-03-04 20:34
Reporternicdev 
Assigned Topaulh 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformWindowsOSWindows ServerOS Version2000+Later
Product Version3.67 LTS 
Target Version3.90beta2Fixed in VersionCurrent GIT 
Summary0001804: Missing country SERBIA from country list
DescriptionIn SiT!, the language dropdown is hardcoded (function country_drop_down), and it does not include "SERBIA" and possibly others.

It could be good to turn this into a DB table, to avoid further issues in the future?

Ciao
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
User avatar (0004528)
paulh (administrator)
2012-09-24 09:17

Confirmed, don't think the country list has been updated in the last few years so 'new' countries recognized by ISO haven't been added, we should review the whole list.
User avatar (0004529)
paulh (administrator)
2012-09-24 09:53

http://www.textfixer.com/resources/dropdowns/country-list-iso-codes.txt [^]
User avatar (0004530)
ivan (administrator)
2012-09-24 14:13

Agreed. A DB table would be good, or the least a file to include or something so that it's easy to update.
User avatar (0004531)
nicdev (developer)
2012-09-24 14:30

Thank you Paul and Ivan.

what do you prefer? For me a DB table jumps to mind first, but involves a lot of changes (especially for the 3.x LTS branch), so from a time limit point of view I suggest a txt file, in /inc/ directory of 3.9x, and just an update of the Country list in that function in 3.x.

If we can come to agreement I propose to do the code changes :-)
User avatar (0004921)
paulh (administrator)
2014-03-04 20:34

Fixed in 4ec2bd5, we now store the countries in the db and reference based on ISO code which should permit i18n in the future and also easy addition

- Issue History
Date Modified Username Field Change
2012-09-24 08:28 nicdev New Issue
2012-09-24 09:17 paulh Note Added: 0004528
2012-09-24 09:17 paulh Status new => confirmed
2012-09-24 09:53 paulh Note Added: 0004529
2012-09-24 14:13 ivan Note Added: 0004530
2012-09-24 14:30 nicdev Note Added: 0004531
2013-12-22 20:01 paulh Assigned To => paulh
2013-12-22 20:01 paulh Status confirmed => assigned
2014-03-04 20:34 paulh Note Added: 0004921
2014-03-04 20:34 paulh Status assigned => resolved
2014-03-04 20:34 paulh Resolution open => fixed
2014-03-04 20:34 paulh Fixed in Version => Current GIT
2014-03-04 20:34 paulh Target Version => 3.90beta2


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker