0001913: Days to approve : shows the previous day.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001913

SiT!

holidays

public

2014-01-24 12:51

2014-01-24 13:41

Reporter

Frans

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

Windows

Windows Server

OS Version

2000+Later

Product Version

3.67 LTS

Target Version

Fixed in Version

Summary

0001913: Days to approve : shows the previous day.

Description

holidays.php.
Show the days to approve.
The list shows all the days previous to the requested days
Example: Requested 12/02/2014. Shows 11/02/2014.
The time zone conversion causes this.
The database table has the value 12/02/2014.

Steps To Reproduce

Time zone south america.
A user requests holidays.
Show the days to approve.
The list shows all the requested days minus one.
The time zone conversion causes this.

Additional Information

Solution
I added 8 hours to the unixtime in line 114 of holidays.php.

$dates->date = mysql2date($dates->date, TRUE);
$dates->date += 8*3600; // Add 8 hours for timezone conversion. Frans

Tags

No tags attached.

Attached Files

holidays.php [^] (11,201 bytes) 2014-01-24 12:51

Relationships

Notes
(0004894) Frans (reporter) 2014-01-24 13:00	The same happens in holiday_request.php: line 63.

(0004895) Frans (reporter) 2014-01-24 13:20	The same happens in holiday_request.php: line 248 (or 250).

(0004896) Frans (reporter) 2014-01-24 13:25	The same happens in holiday.php: line 193.

(0004897) Frans (reporter) 2014-01-24 13:41	holidays.php line 198 change date to ldate echo ldate('jS F Y', $dates->date); To show in the right language !

Issue History
Date Modified	Username	Field	Change
2014-01-24 12:51	Frans	New Issue
2014-01-24 12:51	Frans	File Added: holidays.php
2014-01-24 13:00	Frans	Note Added: 0004894
2014-01-24 13:20	Frans	Note Added: 0004895
2014-01-24 13:25	Frans	Note Added: 0004896
2014-01-24 13:41	Frans	Note Added: 0004897