0001915: Condition in schedule_actions_due

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001915

SiT!

scheduler

public

2014-02-06 14:45

Reporter

Frans

Assigned To

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

Windows

Windows Server

OS Version

2000+Later

Product Version

3.67 LTS

Target Version

Fixed in Version

Summary

0001915: Condition in schedule_actions_due

Description

I think the following line in the function schedule_actions_due()
     $sql .= "AND IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(lastran), -1) <= IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(laststarted), 0)";
has no sense, because ....
1 - When the job is running the condicion results in TRUE, and the job will be selected to run again,
    which is not the intention of this function ! (lastran < laststarted)
2 - When the job is not running the condicion is true: ok.

I thought to change this line to:
    $sql .= "AND IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(laststarted), -1) <= IF(UNIX_TIMESTAMP(laststarted) > 0, UNIX_TIMESTAMP(lastran), 0)";
but this situation never exists, because the function schedule_action_done updates both fields in one sql.

I think the original intention of the programmer is to check that the job is NOT running, like this:
    $sql .= "AND laststarted = NULL";
Please inform me of the correct solutuon.

Issue History
Date Modified	Username	Field	Change
2014-02-06 14:45	Frans	New Issue

Relationships

Notes
There are no notes attached to this issue.