0001944: Program error in incident_email.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001944

SiT!

outbound email

public

2014-06-06 21:58

2014-06-15 18:27

Reporter

Frans

Assigned To

paulh

Priority

low

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Linux

centOS

OS Version

2.6+later

Product Version

3.67 LTS

Target Version

Fixed in Version

Current GIT

Summary

0001944: Program error in incident_email.

Description

The size-check has a program error.
2014-06-06T12:51:05-03:00 incident_email.php Warning [2] trigger_error() expects at most 2 parameters, 3 given (in line ... of file incident_email.php)

Between size and filesize : has a comma instead of a point.
I checked in version 3.90 and I found the same error present in this file.

// Check file size before sending
if (filesize($filename) > $CONFIG['upload_max_filesize'] || filesize($filename) == FALSE)
      {
    trigger_error("User Error: Attachment too large or file upload error, filename: {$filename}, perms: ".fileperms($filename).", size:", filesize($filename), E_USER_WARNING);
   // throwing an error isn't the nicest thing to do for the user but there seems to be no way of
   // checking file sizes at the client end before the attachment is uploaded. - INL
   }

Tags

No tags attached.

Attached Files

Relationships

Notes
(0004947) paulh (administrator) 2014-06-15 18:25	Cheers Frans, good spot

(0004948) paulh (administrator) 2014-06-15 18:27	efa9e07 and r7597 resolve this, many thanks again Frans

Issue History
Date Modified	Username	Field	Change
2014-06-06 21:58	Frans	New Issue
2014-06-15 18:25	paulh	Note Added: 0004947
2014-06-15 18:25	paulh	Assigned To	=> paulh
2014-06-15 18:25	paulh	Status	new => confirmed
2014-06-15 18:27	paulh	Note Added: 0004948
2014-06-15 18:27	paulh	Status	confirmed => resolved
2014-06-15 18:27	paulh	Resolution	open => fixed
2014-06-15 18:27	paulh	Fixed in Version	=> Current GIT