0000500: Possible to create two identical triggers

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000500

SiT!

triggers

public

2009-02-17 10:27

2009-08-16 14:39

Reporter

ivan

Assigned To

kieran

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.50

Fixed in Version

3.50

Summary

0000500: Possible to create two identical triggers

Description

It's possible to set up two perfectly identical trigger actions, with identical rules. This serves no purpose and just causes duplicate emails etc.

We should prevent exactly duplicates from being created, if thats possible.

Additional Information

from #sit on freenode just now:

[10:22] <martian> I have a slight issue:
[10:22] <martian> SiT appears to send out two auto acknowledgement emails every time - is this a SiT issue or possibly a PHP one? It only happens with the first auto acknowledgement
[10:23] <ericthefish> at a quick guess I'd say that you probably have an extra trigger rule that you don't want
[10:23] <martian> oh ok that's a good clue
[10:23] <ericthefish> not seen that before, but it is triggers that define how that gets sent
[10:24] <martian> y the same trigger was defined twice on "Incident Created"
[10:25] <ericthefish> we could do with putting checks in to stop that happening really
[10:25] * ericthefish logs a bug for it
[10:25] <martian> that's fixed it, thanks

Tags

No tags attached.

Attached Files

Relationships

Notes
(0001119) paulh (administrator) 2009-05-27 19:44	Should be reasonably straight forward to check for this. Could also put a key on the table?

(0001198) kieran (administrator) 2009-06-13 10:00	Just checked and it's not possible to do it DB side, it exceeds the maximum key length, fairly simply to do in the code though.

(0001201) kieran (administrator) 2009-06-13 10:42	Fixed in trunk r5451.

(0001661) ivan (administrator) 2009-08-16 14:39	Released in 3.50rc1

Issue History
Date Modified	Username	Field	Change
2009-02-17 10:27	ivan	New Issue
2009-03-25 14:49	kieran	Assigned To	=> kieran
2009-03-25 14:49	kieran	Status	new => confirmed
2009-03-25 14:49	kieran	Target Version	=> 3.50
2009-05-27 19:44	paulh	Note Added: 0001119
2009-06-13 10:00	kieran	Note Added: 0001198
2009-06-13 10:00	kieran	Status	confirmed => assigned
2009-06-13 10:42	kieran	Note Added: 0001201
2009-06-13 10:42	kieran	Status	assigned => resolved
2009-06-13 10:42	kieran	Fixed in Version	=> Current SVN
2009-06-13 10:42	kieran	Resolution	open => fixed
2009-08-16 13:16	ivan	Fixed in Version	Current SVN => 3.50
2009-08-16 14:39	ivan	Note Added: 0001661
2009-08-16 14:39	ivan	Status	resolved => closed