Anonymous | Login | Signup for a new account | 2022-05-18 13:12 BST | ![]() |
Main | My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0000987 | SiT! | outbound email | public | 2009-10-19 10:32 | 2010-01-23 19:02 | ||||
Reporter | nicdev | ||||||||
Assigned To | nicdev | ||||||||
Priority | normal | Severity | major | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | Windows | OS | Windows Server | OS Version | 2000+Later | ||||
Product Version | 3.50 | ||||||||
Target Version | 3.51 | Fixed in Version | 3.51 | ||||||
Summary | 0000987: When adding an attachment 'MAX_FILE_SIZE' does not work | ||||||||
Description | When sending a mail from an incident, and we choose a file to attach (which is bigger than the php limitation set in php.ini), the script does not return an error to say the file is too big. When we send the email, the email is sent "with the message - email sent ok" but the message has not attachment and no warning. The message actually arrives at the intended recipient, but has no attachment. To the engineer/user it looks like everything is ok, but it is not. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | |||||||||
![]() |
|
nicdev (developer) 2009-10-20 10:58 edited on: 2009-10-20 10:59 |
In fact there are 2 issues here related to the 2 limits set in php.ini. The first limit is "upload_max_filesize" and the second is "post_max_size". The 2 are quite different but related because when we attach a file PHP uses the POST method to send the binary data to the server. If you attach a file that is bigger than (>) "post_max_size": There is a bug in PHP (< version 5.2.2) that causes the entire $_FILES and $_POST globals to be reset to ''. In this case the SiT incident_email.php script cannot continue due to empty POST values and the script returns to the first "send email" step or the "last draft" step. (read more here: http://bugs.php.net/bug.php?id=40921 [^]) If you attach a file that is smaller than (<) "post_max_size" but bigger than (>) "upload_max_filesize" then the email sent "success" even though the attachment did not get sent with the email. For this issue i have changed the incident_email.php script. I will post the details of the commit ASAP |
nicdev (developer) 2009-10-22 14:24 |
For the changed code see: http://github.com/nicdev007/sitracker/commit/f8e2b4e39d5d99f876fc6692ce50a785254d9041 [^] |
ivan (administrator) 2009-12-12 13:55 |
Also ported to svn trunk as r5964 |
ivan (administrator) 2010-01-23 19:02 |
Fix released in v3.51 which is now available |
![]() |
|||
Date Modified | Username | Field | Change |
2009-10-19 10:32 | nicdev | New Issue | |
2009-10-20 10:58 | nicdev | Note Added: 0002110 | |
2009-10-20 10:59 | nicdev | Note Edited: 0002110 | View Revisions |
2009-10-20 10:59 | nicdev | Status | new => assigned |
2009-10-20 10:59 | nicdev | Assigned To | => nicdev |
2009-10-20 10:59 | nicdev | Status | assigned => confirmed |
2009-10-22 14:24 | nicdev | Note Added: 0002113 | |
2009-10-22 14:24 | nicdev | Status | confirmed => resolved |
2009-10-22 14:24 | nicdev | Fixed in Version | => Current SVN |
2009-10-22 14:24 | nicdev | Resolution | open => fixed |
2009-10-23 14:12 | ivan | Target Version | => 3.50p1 |
2009-12-12 13:55 | ivan | Note Added: 0002224 | |
2010-01-23 19:01 | ivan | Fixed in Version | Current SVN => 3.51 |
2010-01-23 19:02 | ivan | Note Added: 0002323 | |
2010-01-23 19:02 | ivan | Status | resolved => closed |
Copyright © 2000 - 2022 MantisBT Team |