SiT! Bugs - SiT!
View Issue Details
0001735SiT!plugin hookspublic2011-10-11 08:432012-07-07 18:10
nicdev 
nicdev 
normalminoralways
closedfixed 
3.65 LTS 
3.66 LTS3.66 LTS 
0001735: Add 2 new plugin contexts to incident_details.php for plugins to access each incident update
On the incident_details.php page I have created some plugins that can add some functionality to each incident update depending on it's type (email, emailin etc.).

For this we need to have a plugin hook in each update's "header" and "update" area. (See the screenshot attached).

This way it is possible for us to add some links .etc for our plugins.
What we suggest is as follows:
1. Inside the <div> 'detailhead' -
"plugin_do ('incident_details_iupdate_head');"
just before the closing if the DIV tag for the update header thus just before
line 766 of incident_detail.php:
"766 echo "</div>\n";"

2. Just after line 766 and just before the next <div> of the update body:
        
plugin_do ('incident_details_iupdate_entry');
thus in effect we will have:

766 plugin_do ('incident_details_iupdate_head');
767 echo "</div>\n";
768 plugin_do ('incident_details_iupdate_entry');
No tags attached.
png Image 097.png (36,279) 2011-10-11 08:43
https://bugs.sitracker.org/file_download.php?file_id=199&type=bug
png
Issue History
2011-10-11 08:43nicdevNew Issue
2011-10-11 08:43nicdevFile Added: Image 097.png
2011-10-13 16:32ivanNote Added: 0004330
2011-10-13 16:32ivanStatusnew => confirmed
2011-10-13 16:33ivanTarget Version => 3.66 LTS
2011-10-13 16:35ivanAssigned To => nicdev
2011-10-13 16:35ivanStatusconfirmed => assigned
2011-10-19 08:59nicdevNote Added: 0004331
2011-12-14 20:28nicdevNote Added: 0004364
2011-12-14 20:30nicdevNote Added: 0004365
2011-12-14 20:30nicdevStatusassigned => resolved
2011-12-14 20:30nicdevFixed in Version => Current GIT
2011-12-14 20:30nicdevResolutionopen => fixed
2012-07-07 18:10ivanFixed in VersionCurrent GIT => 3.66 LTS
2012-07-07 18:10ivanStatusresolved => closed

Notes
(0004330)
ivan   
2011-10-13 16:32   
Confirming this but would prefer to use these names

incident_details_update_content_row

and

incident_details_updatehead_content_row
(0004331)
nicdev   
2011-10-19 08:59   
Already fixed in svn 3.x:
http://sitracker.svn.sourceforge.net/viewvc/sitracker?view=revision&revision=7438 [^]

still to be ported to GiT, 3.9x
(0004364)
nicdev   
2011-12-14 20:28   
Ported to Git:
https://gitorious.org/sit/sit/commit/a7a4aef61f9f0223e3ed56a639bfd645cf42404a [^]
(0004365)
nicdev   
2011-12-14 20:30   
SVN commit 7438 and Git a7a4aef6