SiT! Bugs - SiT!
View Issue Details
0000566SiT!triggerspublic2009-03-10 09:352009-08-16 14:39
nicdev 
ivan 
normalminoralways
closedfixed 
3.41 
3.503.50 
0000566: The trigger TRIGGER_INCIDENT_UPDATED_EXTERNAL does not pass the incident id
When creating a new notice, using trigger "TRIGGER_INCIDENT_UPDATED_EXTERNAL" the script does not pass the 'incidentid' to the next script and thus the link to open the incident from the notice or the displayed notice is not correct.
No tags attached.
Issue History
2009-03-10 09:35nicdevNew Issue
2009-03-10 09:49nicdevNote Added: 0000766
2009-03-10 11:33ivanNote Added: 0000767
2009-03-10 11:33ivanAssigned To => nicdev
2009-03-10 11:33ivanStatusnew => feedback
2009-03-10 12:15nicdevNote Added: 0000768
2009-03-10 12:34nicdevNote Added: 0000769
2009-03-10 12:34nicdevAssigned Tonicdev => ivan
2009-03-10 12:34nicdevStatusfeedback => confirmed
2009-03-10 12:49nicdevNote Edited: 0000768
2009-03-10 12:50nicdevNote Edited: 0000769
2009-03-10 15:06ivanNote Added: 0000770
2009-03-10 15:06ivanStatusconfirmed => assigned
2009-03-10 15:06ivanTarget Version => 3.50
2009-05-20 11:45ivanNote Added: 0001082
2009-05-20 11:45ivanStatusassigned => resolved
2009-05-20 11:45ivanResolutionopen => fixed
2009-05-20 11:45ivanFixed in Version => Current SVN
2009-08-16 13:16ivanFixed in VersionCurrent SVN => 3.50
2009-08-16 14:39ivanNote Added: 0001659
2009-08-16 14:39ivanStatusresolved => closed

Notes
(0000766)
nicdev   
2009-03-10 09:49   
Just for information i used "javascript:incident_details_window({incidentid})" as the link in the template. The popup appears but it passes the following: "javascript:incident_details_window()"
(0000767)
ivan   
2009-03-10 11:33   
The trigger passes incident ID as 'incident' not 'incidentid' apparently. Not sure if this is a bug or not at the moment. Looks like it probably is.
(0000768)
nicdev   
2009-03-10 12:15   
(edited on: 2009-03-10 12:49)
Hi Ivan,

In the triggertypes.php:

$triggerarray['TRIGGER_INCIDENT_UPDATED_EXTERNAL'] =
array('name' => 'Incident updated externally',
      'description' => 'Occurs when an incident is updated by someone external',
      'required' => array('incidentid'),
      'params' => array('incidentid'),
      );
I assume if i use: "javascript:incident_details_window({incident})", then it should work??

(0000769)
nicdev   
2009-03-10 12:34   
(edited on: 2009-03-10 12:50)
Hi Ivan,

Yes it is a bug, i have changed inboundemail.php line 438 to read:
" trigger('TRIGGER_INCIDENT_UPDATED_EXTERNAL', array('incidentid' => $incidentid));"

it used to say:
" trigger('TRIGGER_INCIDENT_UPDATED_EXTERNAL', array('incident' => $incidentid));

I have tested it and it works fine now...

:-)

(0000770)
ivan   
2009-03-10 15:06   
Thanks. I'll take a look soon as I get a few minutes. Busy busy right now. :-(
(0001082)
ivan   
2009-05-20 11:45   
This is resolved as of svn trunk r5392. Thanks nicdev!
(0001659)
ivan   
2009-08-16 14:39   
Released in 3.50rc1