SiT! Bugs - SiT!
View Issue Details
0000616SiT!inbound emailpublic2009-03-26 20:292009-08-16 14:40
smelvin 
 
normalminoralways
closedfixed 
3.45 
3.503.50 
0000616: Empty ($CONFIG['spam_email_subject']) causes warnings in holding queue
If you clear the contents of the Spam Subject field on the Email config page, every email displays a warning about an invalid delimiter. Please see screen capture.

It can be resolved by making the following change in the holding_queue.php file at line 276.

Replace...
while ($updates = mysql_fetch_array($result))
    {
        if (!stristr($updates['subject'], $CONFIG['spam_email_subject']))
        {
            $queuerows[$updates['id']] = generate_row($updates);
        }
        else
        {
            $spamcount++;
        }
    }

With ...
if (!empty($CONFIG['spam_email-subject']))
    {
        while ($updates = mysql_fetch_array($result))
        {
            if (!stristr($updates['subject'], $CONFIG['spam_email_subject']))
            {
                $queuerows[$updates['id']] = generate_row($updates);
            }
            else
            {
                $spamcount++;
            }
        }
    }
    else
    {
        while ($updates = mysql_fetch_array($result))
        {
            $queuerows[$updates['id']] = generate_row($updates);
        }
    }

This way the system checks to see if the variable is empty before entering into the loop.

Hopefully this helps.
No tags attached.
png Delimiter Error.png (37,759) 2009-03-26 20:29
https://bugs.sitracker.org/file_download.php?file_id=21&type=bug
png
Issue History
2009-03-26 20:29smelvinNew Issue
2009-03-26 20:29smelvinFile Added: Delimiter Error.png
2009-03-26 20:53kieranNote Added: 0000844
2009-03-26 20:53kieranStatusnew => resolved
2009-03-26 20:53kieranResolutionopen => fixed
2009-03-26 20:53kieranFixed in Version => Current SVN
2009-08-15 21:31ivanTarget Version => 3.50
2009-08-16 13:15ivanFixed in VersionCurrent SVN => 3.50
2009-08-16 14:40ivanNote Added: 0001745
2009-08-16 14:40ivanStatusresolved => closed

Notes
(0000844)
kieran   
2009-03-26 20:53   
Cheers for the report, I commited the fix to svn.
(0001745)
ivan   
2009-08-16 14:40   
Released in 3.50rc1